[HTTP] Default to oldest in dev
#203225
Merged
[HTTP] Default to oldest in dev
#203225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
discuss
Feature:http
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
afharo
approved these changes
Dec 12, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12376919228 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 17, 2024
## Summary Changes the default HTTP version resolution in dev to `oldest` (matches non-dev). The original intention was to guide developers to always sending a versioned header when interacting with Kibana. In practice, however, developers just set-and-forget the following configuration to get around this annoyance: ```yaml server.versioned.versionResolution: 'oldest' ``` ...undoing the original intention. Having this guidance does not justify the confusion/annoyance that this dev-only default creates and so this proposal simply removes it. To better guide developers we can consider other options like: make `version` required in core's HTTP client interface (lots of updates...), doing something in tests, adding docs, something else or any combo of these. Given the fact that developers generally discover this workaround and undo the originally intended guidance, I'm proposing not blocking on first having another approach in place. (cherry picked from commit c1bda1d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stephmilovic
pushed a commit
that referenced
this pull request
Dec 17, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[HTTP] Default to `oldest` in dev (#203225)](#203225) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jean-Louis Leysens","email":"jeanlouis.leysens@elastic.co"},"sourceCommit":{"committedDate":"2024-12-17T16:10:34Z","message":"[HTTP] Default to `oldest` in dev (#203225)\n\n## Summary\r\n\r\nChanges the default HTTP version resolution in dev to `oldest` (matches\r\nnon-dev).\r\n\r\nThe original intention was to guide developers to always sending a\r\nversioned header when interacting with Kibana. In practice, however,\r\ndevelopers just set-and-forget the following configuration to get around\r\nthis annoyance:\r\n\r\n```yaml\r\nserver.versioned.versionResolution: 'oldest'\r\n```\r\n\r\n...undoing the original intention. Having this guidance does not justify\r\nthe confusion/annoyance that this dev-only default creates and so this\r\nproposal simply removes it.\r\n\r\nTo better guide developers we can consider other options like: make\r\n`version` required in core's HTTP client interface (lots of updates...),\r\ndoing something in tests, adding docs, something else or any combo of\r\nthese.\r\n\r\nGiven the fact that developers generally discover this workaround and\r\nundo the originally intended guidance, I'm proposing not blocking on\r\nfirst having another approach in place.","sha":"c1bda1d50145f764956de9ed8557bd21f6ba136f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["discuss","Feature:http","Team:Core","release_note:skip","v9.0.0","backport:version","v8.18.0"],"title":"[HTTP] Default to `oldest` in dev","number":203225,"url":"https://github.com/elastic/kibana/pull/203225","mergeCommit":{"message":"[HTTP] Default to `oldest` in dev (#203225)\n\n## Summary\r\n\r\nChanges the default HTTP version resolution in dev to `oldest` (matches\r\nnon-dev).\r\n\r\nThe original intention was to guide developers to always sending a\r\nversioned header when interacting with Kibana. In practice, however,\r\ndevelopers just set-and-forget the following configuration to get around\r\nthis annoyance:\r\n\r\n```yaml\r\nserver.versioned.versionResolution: 'oldest'\r\n```\r\n\r\n...undoing the original intention. Having this guidance does not justify\r\nthe confusion/annoyance that this dev-only default creates and so this\r\nproposal simply removes it.\r\n\r\nTo better guide developers we can consider other options like: make\r\n`version` required in core's HTTP client interface (lots of updates...),\r\ndoing something in tests, adding docs, something else or any combo of\r\nthese.\r\n\r\nGiven the fact that developers generally discover this workaround and\r\nundo the originally intended guidance, I'm proposing not blocking on\r\nfirst having another approach in place.","sha":"c1bda1d50145f764956de9ed8557bd21f6ba136f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203225","number":203225,"mergeCommit":{"message":"[HTTP] Default to `oldest` in dev (#203225)\n\n## Summary\r\n\r\nChanges the default HTTP version resolution in dev to `oldest` (matches\r\nnon-dev).\r\n\r\nThe original intention was to guide developers to always sending a\r\nversioned header when interacting with Kibana. In practice, however,\r\ndevelopers just set-and-forget the following configuration to get around\r\nthis annoyance:\r\n\r\n```yaml\r\nserver.versioned.versionResolution: 'oldest'\r\n```\r\n\r\n...undoing the original intention. Having this guidance does not justify\r\nthe confusion/annoyance that this dev-only default creates and so this\r\nproposal simply removes it.\r\n\r\nTo better guide developers we can consider other options like: make\r\n`version` required in core's HTTP client interface (lots of updates...),\r\ndoing something in tests, adding docs, something else or any combo of\r\nthese.\r\n\r\nGiven the fact that developers generally discover this workaround and\r\nundo the originally intended guidance, I'm proposing not blocking on\r\nfirst having another approach in place.","sha":"c1bda1d50145f764956de9ed8557bd21f6ba136f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jean-Louis Leysens <jeanlouis.leysens@elastic.co>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
## Summary Changes the default HTTP version resolution in dev to `oldest` (matches non-dev). The original intention was to guide developers to always sending a versioned header when interacting with Kibana. In practice, however, developers just set-and-forget the following configuration to get around this annoyance: ```yaml server.versioned.versionResolution: 'oldest' ``` ...undoing the original intention. Having this guidance does not justify the confusion/annoyance that this dev-only default creates and so this proposal simply removes it. To better guide developers we can consider other options like: make `version` required in core's HTTP client interface (lots of updates...), doing something in tests, adding docs, something else or any combo of these. Given the fact that developers generally discover this workaround and undo the originally intended guidance, I'm proposing not blocking on first having another approach in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the default HTTP version resolution in dev to
oldest(matches non-dev).The original intention was to guide developers to always sending a versioned header when interacting with Kibana. In practice, however, developers just set-and-forget the following configuration to get around this annoyance:
...undoing the original intention. Having this guidance does not justify the confusion/annoyance that this dev-only default creates and so this proposal simply removes it.
To better guide developers we can consider other options like: make
versionrequired in core's HTTP client interface (lots of updates...), doing something in tests, adding docs, something else or any combo of these.Given the fact that developers generally discover this workaround and undo the originally intended guidance, I'm proposing not blocking on first having another approach in place.