-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Sustainable Kibana Architecture: Move modules owned by @elastic/docs
(#202416)
#203401
Conversation
elastic#202416) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. We kindly ask you to: * Review the moved files, as some of them contain relative paths that have been updated. * Review the updated files, as some of them contain references that have been updated. * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: * customised eslint rules * docs pointing to source code * We kindly ask you to: * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. * Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below. #### 1 package(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/doc-links` | `src/platform/packages/shared/kbn-doc-links` | <details> <summary>Updated references</summary> ``` ./docs/upgrade-notes.asciidoc ./package.json ./packages/kbn-repo-packages/package-map.json ./packages/kbn-ts-projects/config-paths.json ./src/core/tsconfig.type_check.json ./src/platform/packages/shared/kbn-doc-links/jest.config.js ./src/plugins/ai_assistant_management/selection/tsconfig.type_check.json ./tsconfig.base.json ./tsconfig.base.type_check.json ./tsconfig.refs.json ./x-pack/plugins/alerting/tsconfig.type_check.json ./x-pack/plugins/search_connectors/tsconfig.type_check.json ./x-pack/plugins/search_inference_endpoints/tsconfig.type_check.json ./x-pack/plugins/search_playground/tsconfig.type_check.json ./x-pack/plugins/security_solution/tsconfig.type_check.json ./x-pack/plugins/serverless_search/tsconfig.type_check.json ./x-pack/plugins/threat_intelligence/tsconfig.type_check.json ./yarn.lock ``` </details> <details> <summary>Updated relative paths</summary> ``` src/platform/packages/shared/kbn-doc-links/jest.config.js:12 src/platform/packages/shared/kbn-doc-links/tsconfig.json:2 src/platform/packages/shared/kbn-doc-links/tsconfig.type_check.json:2 ``` </details> <details> <summary>Script errors</summary> ``` ``` </details> (cherry picked from commit b2d49b8) # Conflicts: # .github/CODEOWNERS
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
💚 Build Succeeded
Metrics [docs]
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport
This will backport the following commits from
main
to8.x
:@elastic/docs
(#202416)Questions ?
Please refer to the Backport tool documentation