[Cloud Security] Fix for Session View Icon Cutoff Issue #203888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
animehart
added
v8.18.0
Team:Cloud Security
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12321778127 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 13, 2024
## Summary This PR addresses the issue where Session View gets cutoff. The issue comes from number of Default Action button is not updated after 'Add Notes' button was introduced. Max amount button should now be 6 instead of 5 <img width="1192" alt="Screenshot 2024-12-11 at 11 18 11 AM" src="https://github.com/user-attachments/assets/100f9a9f-1df3-407f-9218-10ea809ab64c" /> <img width="956" alt="Screenshot 2024-12-11 at 11 18 21 AM" src="https://github.com/user-attachments/assets/5f3fa9cb-cd05-49b8-8fe6-4da024ff5290" /> (cherry picked from commit f9e1089)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 13, 2024
… (#204276) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Fix for Session View Icon Cutoff Issue (#203888)](#203888) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rickyanto Ang","email":"rickyangwyn@gmail.com"},"sourceCommit":{"committedDate":"2024-12-13T19:24:24Z","message":"[Cloud Security] Fix for Session View Icon Cutoff Issue (#203888)\n\n## Summary\r\n\r\nThis PR addresses the issue where Session View gets cutoff. The issue\r\ncomes from number of Default Action button is not updated after 'Add\r\nNotes' button was introduced. Max amount button should now be 6 instead\r\nof 5\r\n<img width=\"1192\" alt=\"Screenshot 2024-12-11 at 11 18 11 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/100f9a9f-1df3-407f-9218-10ea809ab64c\"\r\n/>\r\n<img width=\"956\" alt=\"Screenshot 2024-12-11 at 11 18 21 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/5f3fa9cb-cd05-49b8-8fe6-4da024ff5290\"\r\n/>","sha":"f9e1089893a421a972c610029791719d0c25e3b3","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor","v8.18.0"],"title":"[Cloud Security] Fix for Session View Icon Cutoff Issue","number":203888,"url":"https://github.com/elastic/kibana/pull/203888","mergeCommit":{"message":"[Cloud Security] Fix for Session View Icon Cutoff Issue (#203888)\n\n## Summary\r\n\r\nThis PR addresses the issue where Session View gets cutoff. The issue\r\ncomes from number of Default Action button is not updated after 'Add\r\nNotes' button was introduced. Max amount button should now be 6 instead\r\nof 5\r\n<img width=\"1192\" alt=\"Screenshot 2024-12-11 at 11 18 11 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/100f9a9f-1df3-407f-9218-10ea809ab64c\"\r\n/>\r\n<img width=\"956\" alt=\"Screenshot 2024-12-11 at 11 18 21 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/5f3fa9cb-cd05-49b8-8fe6-4da024ff5290\"\r\n/>","sha":"f9e1089893a421a972c610029791719d0c25e3b3"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203888","number":203888,"mergeCommit":{"message":"[Cloud Security] Fix for Session View Icon Cutoff Issue (#203888)\n\n## Summary\r\n\r\nThis PR addresses the issue where Session View gets cutoff. The issue\r\ncomes from number of Default Action button is not updated after 'Add\r\nNotes' button was introduced. Max amount button should now be 6 instead\r\nof 5\r\n<img width=\"1192\" alt=\"Screenshot 2024-12-11 at 11 18 11 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/100f9a9f-1df3-407f-9218-10ea809ab64c\"\r\n/>\r\n<img width=\"956\" alt=\"Screenshot 2024-12-11 at 11 18 21 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/5f3fa9cb-cd05-49b8-8fe6-4da024ff5290\"\r\n/>","sha":"f9e1089893a421a972c610029791719d0c25e3b3"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Rickyanto Ang <rickyangwyn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the issue where Session View gets cutoff. The issue comes from number of Default Action button is not updated after 'Add Notes' button was introduced. Max amount button should now be 6 instead of 5
