[kbn-code-owners] General improvements #204023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following improvements have been made: - Added `--json` flag to CLI command to output result as JSON - Terminology updated to more accurately reflect object contents - Code owner teams are always returned as an array - Proper handling of inline comments - Better logging for `scripts/check_ftr_code_owners.js` Existing usage of the `@kbn/code-owners` package has been updated accordingly, without modifying outcomes.
dolaru
added
release_note:skip
wayneseymour
requested changes
Dec 12, 2024
packages/kbn-test/src/functional_test_runner/run_check_ftr_code_owners.ts
Show resolved
Hide resolved
wayneseymour
approved these changes
Dec 12, 2024
+ move `CODE_OWNERS_FILE` constant to `path.ts`
💚 Build Succeeded
Metrics [docs]History
cc @dolaru |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following improvements have been made:
--jsonflag to CLI command to output result as JSONscripts/check_ftr_code_owners.jsExisting usage of the
@kbn/code-ownerspackage has been updated accordingly, without modifying outcomes.