-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon #204286
base: main
Are you sure you want to change the base?
[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon #204286
Conversation
Pinging @elastic/security-solution (Team: SecuritySolution) |
...security_solution/public/detection_engine/rule_creation_ui/components/ai_assistant/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Integration Assistant plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detection Engine area LGTM
...platform/packages/shared/kbn-elastic-assistant/impl/assistant/assistant_body/empty_convo.tsx
Outdated
Show resolved
Hide resolved
08fdb43
to
c8296b0
Compare
x-pack/solutions/security/packages/upselling/sections/attack_discovery/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/solutions/security/plugins/security_solution/public/assistant/get_comments/index.tsx
Show resolved
Hide resolved
...ssistant/public/components/create_integration/create_integration_assistant/header/header.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @clintandrewhall for the new Assistant logo and beacon! 🙏
✅ Desk tested locally
LGTM 🚀
Thank you for your diligence, @andrew-goldstein ... it's very appreciated! |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
References to deprecated APIs
History
|
Summary
This PR integrates the new Assistant Icon, Beacon, and Avatar into solutions and packages owned by Security. In most cases this was a 1:1 replacement, but in a few, Icon was replaced with Beacon for consistency, (e.g. welcome screens, upsells, etc)
Note: the scaling of the icon/avatar before was one different from EUI. The new components match EUI directly and represent a 2x scale change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).