Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon #204286

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

clintandrewhall
Copy link
Contributor

A follow-up to #203879

Summary

This PR integrates the new Assistant Icon, Beacon, and Avatar into solutions and packages owned by Security. In most cases this was a 1:1 replacement, but in a few, Icon was replaced with Beacon for consistency, (e.g. welcome screens, upsells, etc)

Note: the scaling of the icon/avatar before was one different from EUI. The new components match EUI directly and represent a 2x scale change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).

@clintandrewhall clintandrewhall added review release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 labels Dec 13, 2024
@clintandrewhall clintandrewhall requested review from a team as code owners December 13, 2024 22:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@clintandrewhall clintandrewhall removed the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Dec 13, 2024
@clintandrewhall clintandrewhall requested review from joeypoon, parkiino and vitaliidm and removed request for joeypoon, parkiino and vitaliidm December 13, 2024 22:17
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner December 13, 2024 22:37
@clintandrewhall clintandrewhall requested a review from a team as a code owner December 16, 2024 12:36
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Integration Assistant plugin

Copy link
Contributor

@vitaliidm vitaliidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection Engine area LGTM

@clintandrewhall clintandrewhall force-pushed the ai/assistant-logo-security branch from 08fdb43 to c8296b0 Compare December 18, 2024 15:51
@clintandrewhall clintandrewhall requested review from a team as code owners December 18, 2024 15:51
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clintandrewhall for the new Assistant logo and beacon! 🙏
✅ Desk tested locally
LGTM 🚀

@clintandrewhall
Copy link
Contributor Author

Thank you for your diligence, @andrew-goldstein ... it's very appreciated!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
integrationAssistant 475 479 +4
observabilityAIAssistant 118 117 -1
observabilityAIAssistantApp 426 425 -1
observabilityAiAssistantManagement 395 394 -1
searchAssistant 262 261 -1
securitySolution 6507 6504 -3
securitySolutionEss 117 122 +5
securitySolutionServerless 152 157 +5
total +7

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/elastic-assistant 145 144 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
integrationAssistant 880.8KB 881.5KB +733.0B
observabilityAIAssistantApp 294.1KB 294.1KB +5.0B
searchAssistant 163.4KB 163.2KB -177.0B
securitySolution 21.4MB 21.4MB +2.8KB
securitySolutionEss 62.1KB 64.6KB +2.4KB
securitySolutionServerless 133.2KB 135.6KB +2.4KB
total +8.2KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/elastic-assistant 10 9 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAIAssistantApp 14.7KB 14.5KB -182.0B
securitySolutionServerless 26.4KB 26.4KB +1.0B
total -181.0B
Unknown metric groups

API count

id before after diff
@kbn/elastic-assistant 174 172 -2

async chunk count

id before after diff
integrationAssistant 2 3 +1
securitySolutionEss 4 5 +1
securitySolutionServerless 16 17 +1
total +3

References to deprecated APIs

id before after diff
@kbn/ecs-data-quality-dashboard 2 0 -2
integrationAssistant 4 0 -4
securitySolution 489 464 -25
total -31

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes review v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants