[Security Solution] Preview navigation in document details flyout #204292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
added
backport
v9.0.0
Team:Threat Hunting
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
code LGTM and desk tested. In combination with the history functionality, this thing is awesome!
I left a comment, if you're making a push to the branch to solve the failing build, would you mind maybe renaming the few isEnabled variables to something a bit more clear like isNavigationEnabled or isLinkEnabled...? If you do this in the components directly (instead of in the hook) you shouldn't have to change any of the unit tests...
.../security_solution/public/flyout/document_details/right/components/correlations_overview.tsx
Outdated
Show resolved
Hide resolved
PhilippeOberti
approved these changes
Dec 16, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12362533615 |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
|
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
christineweng
added a commit
to christineweng/kibana
that referenced
this pull request
Dec 17, 2024
…astic#204292) ## Summary This PR enables navigation when an user is viewing an alert/event preview. - To see the new navigation, enable feature flag `newExpandableFlyoutNavigationEnabled` - This PR only covers navigations available in the alert/event preview. Links in host and user flyouts will be done in a separate PR How navigation used to work: - When a document details flyout is open, many sections have nevigation links to open the details panel in the left - However, these navigations were disabled in a preview mode, and user is limited to stay in the original flyout context Preview navigations now available - When the feature flag is on, navigation links is available - For example, an user is on an alert preview, and click on `Entities`, a new flyout will be opened (for the alert context) and the entities details section will be available. **Before** <img width="1483" alt="image" src="https://github.com/user-attachments/assets/a8a21b86-21c1-48d4-ae4e-4ca5b337a2b0" /> **After** <img width="1449" alt="image" src="https://github.com/user-attachments/assets/2db865f3-3a31-440c-bc84-3003928c1f6a" /> https://github.com/user-attachments/assets/ae62b553-1ec9-4663-9ed3-ff20b2355061 ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit d638475) # Conflicts: # x-pack/plugins/security_solution/public/flyout/document_details/right/components/notes.test.tsx # x-pack/plugins/security_solution/public/flyout/document_details/right/components/notes.tsx
This was referenced Dec 17, 2024
christineweng
added a commit
to christineweng/kibana
that referenced
this pull request
Dec 17, 2024
…astic#204292) ## Summary This PR enables navigation when an user is viewing an alert/event preview. - To see the new navigation, enable feature flag `newExpandableFlyoutNavigationEnabled` - This PR only covers navigations available in the alert/event preview. Links in host and user flyouts will be done in a separate PR How navigation used to work: - When a document details flyout is open, many sections have nevigation links to open the details panel in the left - However, these navigations were disabled in a preview mode, and user is limited to stay in the original flyout context Preview navigations now available - When the feature flag is on, navigation links is available - For example, an user is on an alert preview, and click on `Entities`, a new flyout will be opened (for the alert context) and the entities details section will be available. **Before** <img width="1483" alt="image" src="https://github.com/user-attachments/assets/a8a21b86-21c1-48d4-ae4e-4ca5b337a2b0" /> **After** <img width="1449" alt="image" src="https://github.com/user-attachments/assets/2db865f3-3a31-440c-bc84-3003928c1f6a" /> https://github.com/user-attachments/assets/ae62b553-1ec9-4663-9ed3-ff20b2355061 ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit d638475) # Conflicts: # x-pack/plugins/security_solution/public/flyout/document_details/right/components/notes.test.tsx # x-pack/plugins/security_solution/public/flyout/document_details/right/components/notes.tsx
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
christineweng
added a commit
that referenced
this pull request
Dec 18, 2024
…ut (#204292) (#204514) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Preview navigation in document details flyout (#204292)](#204292) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-16T22:34:26Z","message":"[Security Solution] Preview navigation in document details flyout (#204292)\n\n## Summary\r\n\r\nThis PR enables navigation when an user is viewing an alert/event\r\npreview.\r\n\r\n- To see the new navigation, enable feature flag\r\n`newExpandableFlyoutNavigationEnabled`\r\n- This PR only covers navigations available in the alert/event preview.\r\nLinks in host and user flyouts will be done in a separate PR\r\n\r\nHow navigation used to work:\r\n- When a document details flyout is open, many sections have nevigation\r\nlinks to open the details panel in the left\r\n- However, these navigations were disabled in a preview mode, and user\r\nis limited to stay in the original flyout context\r\n\r\nPreview navigations now available\r\n- When the feature flag is on, navigation links is available\r\n- For example, an user is on an alert preview, and click on `Entities`,\r\na new flyout will be opened (for the alert context) and the entities\r\ndetails section will be available.\r\n\r\n**Before**\r\n<img width=\"1483\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a8a21b86-21c1-48d4-ae4e-4ca5b337a2b0\"\r\n/>\r\n\r\n**After**\r\n<img width=\"1449\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2db865f3-3a31-440c-bc84-3003928c1f6a\"\r\n/>\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae62b553-1ec9-4663-9ed3-ff20b2355061\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d638475c6760b844f8ef928a21d382ef279566df","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","v9.0.0","Team:Threat Hunting","release_note:feature","Team:Threat Hunting:Investigations","v8.18.0"],"number":204292,"url":"https://github.com/elastic/kibana/pull/204292","mergeCommit":{"message":"[Security Solution] Preview navigation in document details flyout (#204292)\n\n## Summary\r\n\r\nThis PR enables navigation when an user is viewing an alert/event\r\npreview.\r\n\r\n- To see the new navigation, enable feature flag\r\n`newExpandableFlyoutNavigationEnabled`\r\n- This PR only covers navigations available in the alert/event preview.\r\nLinks in host and user flyouts will be done in a separate PR\r\n\r\nHow navigation used to work:\r\n- When a document details flyout is open, many sections have nevigation\r\nlinks to open the details panel in the left\r\n- However, these navigations were disabled in a preview mode, and user\r\nis limited to stay in the original flyout context\r\n\r\nPreview navigations now available\r\n- When the feature flag is on, navigation links is available\r\n- For example, an user is on an alert preview, and click on `Entities`,\r\na new flyout will be opened (for the alert context) and the entities\r\ndetails section will be available.\r\n\r\n**Before**\r\n<img width=\"1483\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a8a21b86-21c1-48d4-ae4e-4ca5b337a2b0\"\r\n/>\r\n\r\n**After**\r\n<img width=\"1449\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2db865f3-3a31-440c-bc84-3003928c1f6a\"\r\n/>\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae62b553-1ec9-4663-9ed3-ff20b2355061\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d638475c6760b844f8ef928a21d382ef279566df"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204292","number":204292,"mergeCommit":{"message":"[Security Solution] Preview navigation in document details flyout (#204292)\n\n## Summary\r\n\r\nThis PR enables navigation when an user is viewing an alert/event\r\npreview.\r\n\r\n- To see the new navigation, enable feature flag\r\n`newExpandableFlyoutNavigationEnabled`\r\n- This PR only covers navigations available in the alert/event preview.\r\nLinks in host and user flyouts will be done in a separate PR\r\n\r\nHow navigation used to work:\r\n- When a document details flyout is open, many sections have nevigation\r\nlinks to open the details panel in the left\r\n- However, these navigations were disabled in a preview mode, and user\r\nis limited to stay in the original flyout context\r\n\r\nPreview navigations now available\r\n- When the feature flag is on, navigation links is available\r\n- For example, an user is on an alert preview, and click on `Entities`,\r\na new flyout will be opened (for the alert context) and the entities\r\ndetails section will be available.\r\n\r\n**Before**\r\n<img width=\"1483\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a8a21b86-21c1-48d4-ae4e-4ca5b337a2b0\"\r\n/>\r\n\r\n**After**\r\n<img width=\"1449\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2db865f3-3a31-440c-bc84-3003928c1f6a\"\r\n/>\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae62b553-1ec9-4663-9ed3-ff20b2355061\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d638475c6760b844f8ef928a21d382ef279566df"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
…astic#204292) ## Summary This PR enables navigation when an user is viewing an alert/event preview. - To see the new navigation, enable feature flag `newExpandableFlyoutNavigationEnabled` - This PR only covers navigations available in the alert/event preview. Links in host and user flyouts will be done in a separate PR How navigation used to work: - When a document details flyout is open, many sections have nevigation links to open the details panel in the left - However, these navigations were disabled in a preview mode, and user is limited to stay in the original flyout context Preview navigations now available - When the feature flag is on, navigation links is available - For example, an user is on an alert preview, and click on `Entities`, a new flyout will be opened (for the alert context) and the entities details section will be available. **Before** <img width="1483" alt="image" src="https://github.com/user-attachments/assets/a8a21b86-21c1-48d4-ae4e-4ca5b337a2b0" /> **After** <img width="1449" alt="image" src="https://github.com/user-attachments/assets/2db865f3-3a31-440c-bc84-3003928c1f6a" /> https://github.com/user-attachments/assets/ae62b553-1ec9-4663-9ed3-ff20b2355061 ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables navigation when an user is viewing an alert/event preview.
newExpandableFlyoutNavigationEnabledHow navigation used to work:
Preview navigations now available
Entities, a new flyout will be opened (for the alert context) and the entities details section will be available.Before
After
Screen.Recording.2024-12-13.at.5.12.45.PM.mov
Checklist