Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [ai][assistant] Refactor search to use new Assistant logo and beacon (#204287) #204772

Merged
merged 1 commit into from
Dec 18, 2024
Merged

[8.x] [ai][assistant] Refactor search to use new Assistant logo and beacon (#204287) #204772

merged 1 commit into from
Dec 18, 2024
+15 −25

Conversation

clintandrewhall
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@clintandrewhall
[ai][assistant] Refactor search to use new Assistant logo and beacon (e…
3508eeb 
…lastic#204287)

> A follow-up to elastic#203879

## Summary

This PR integrates the new Assistant Icon, Beacon, and Avatar into
solutions and packages owned by Search. In most cases this was a 1:1
replacement, but in a few, Icon was replaced with Beacon or Beacon was
added for consistency, (e.g. welcome screens, upsells, etc), .

Note: the scaling of the icon/avatar _before_ was one different from
EUI. The new components match EUI directly and represent a 2x scale
change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit e078673)
@clintandrewhall clintandrewhall enabled auto-merge (squash) December 18, 2024 15:08
@clintandrewhall clintandrewhall mentioned this pull request Dec 18, 2024
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityAIAssistantApp 427 434 +7
observabilityAiAssistantManagement 367 380 +13
searchAssistant 253 260 +7
total +27

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistantApp 294.2KB 297.2KB +3.0KB
searchAssistant 162.0KB 165.0KB +3.0KB
total +6.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAIAssistantApp 14.2KB 14.3KB +114.0B
searchAssistant 4.9KB 5.0KB +104.0B
total +218.0B
Unknown metric groups

async chunk count

id before after diff
observabilityAIAssistantApp 7 8 +1
searchAssistant 1 2 +1
total +2

References to deprecated APIs

id before after diff
@kbn/ai-assistant 4 0 -4
searchAssistant 2 0 -2
total -6

Samiul-TheSoccerFan
Samiul-TheSoccerFan approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clintandrewhall clintandrewhall merged commit 8c436c2 into elastic:8.x Dec 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samiul-TheSoccerFan Samiul-TheSoccerFan Samiul-TheSoccerFan approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clintandrewhall @elasticmachine @Samiul-TheSoccerFan