[Lens] Align Lens style with Borealis #204839
Conversation
no fontsize change applied
markov00
added
Team:Visualizations
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
| @@ -79,7 +79,7 @@ export function ColorPicker({ | |||
| close(); | |||
| deleteStep(); | |||
| }} | |||
| style={{ paddingBottom: 8 }} | |||
| css={{ paddingBottom: 8 }} | |||
There was a problem hiding this comment.
Suggestion: We could also use a token here instead of a static value.
css={({ euiTheme }) => ({
paddingBottom: euiTheme.size.s
})}
ℹ️ In case this causes a typescript error on the euiTheme not being defined, see this related comment on required steps.
| const selectedColorSwatchStyle = { | ||
| outline: 'currentcolor solid 2px', | ||
| outlineOffset: '-1px', | ||
| border: `2px solid ${euiTheme.colors.borderBaseFormsColorSwatch}`, |
There was a problem hiding this comment.
Suggestion: We could use euiTheme.border.width.thick here instead of 2px.
| gap: ${euiTheme.size.s}; | ||
| min-height: ${euiTheme.size.xl}; | ||
| padding: ${euiTheme.size.xs} ${euiTheme.size.s}; | ||
| background-color: ${euiTheme.colors.backgroundBaseSubdued}; |
There was a problem hiding this comment.
I don't know what this renders, but based on color value mappings alone, this might rather be using backgroundBasePlain.
Feel free to ignore if this is already expected as is 🙂
There was a problem hiding this comment.
This color was specified by @MichaelMarcialis
| > | ||
| <div | ||
| css={css` | ||
| max-width: 400px; |
There was a problem hiding this comment.
ℹ️ Just fyi, once this EUI upgrade PR is merged, you could use euiTheme.components.forms.maxWidth.
| @@ -363,7 +363,7 @@ export function LayerPanel(props: LayerPanelProps) { | |||
| className="lnsLayerPanel" | |||
| data-test-subj={`lns-layerPanel-${layerIndex}`} | |||
| > | |||
| <EuiPanel paddingSize="none"> | |||
| <EuiPanel paddingSize="none" hasShadow={false} hasBorder={true}> | |||
There was a problem hiding this comment.
Nit, this could use shorthand: hasBorder instead of hasBorder={true}
There was a problem hiding this comment.
thanks, done in f33c9ff
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
Summary
This PR updates the style of Lens to align it with the new Borealis theme.
It covers the set of tasks in #203050 within the
Lens editor panelslist.Comments are applied in order as in the mentioned issue