[ML] Migrate ml-info-icon to React/EUI. Fixes related IE11 error. #20610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
|
Once EUI |
| content={text} | ||
| position={position} | ||
| /> | ||
| <span id={'ml_aria_description_' + id} className="ml-info-tooltip-text">{text}</span> |
There was a problem hiding this comment.
nit, id could be a template literal
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jul 11, 2018
…astic#20610) - Migrates the ml-info-icon directive to use React/EUI. This fixes a related error in IE11. - For now a hard-coded override is used to size the icon because EuiIconTip doesn't pass on the size attribute to the wrapped EuiIcon directive. - The (simple) React component is kept within the directive's, because previously the directive template also wasn't in a separate file. - Removes the unused mlJsonTooltipService angular service.
88 tasks
walterra
added a commit
that referenced
this pull request
Jul 12, 2018
…0610) (#20665) - Migrates the ml-info-icon directive to use React/EUI. This fixes a related error in IE11. - For now a hard-coded override is used to size the icon because EuiIconTip doesn't pass on the size attribute to the wrapped EuiIcon directive. - The (simple) React component is kept within the directive's, because previously the directive template also wasn't in a separate file. - Removes the unused mlJsonTooltipService angular service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ml-info-icondirective to use React/EUI. This fixes a related error in IE11.EuiIconTipdoesn't pass on thesizeattribute to the wrappedEuiIcondirective.mlJsonTooltipServiceangular service.