-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup unnecessary params for date_histogram #20710
Conversation
💔 Build Failed |
💚 Build Succeeded |
Jenkins, test this |
💔 Build Failed |
Jenkins, test this - flaky tag cloud test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not enough because our current visualisation depends on the output created by the min_doc_count:1
. 'm attaching two area chart examples
Or we need to change the vis lib to correct this behaviour, or it's better to wait for EUICharts for remove these query params
💚 Build Succeeded |
Same as @markov00 here. |
hmm, have a hard time finding it, but there is an enchantment request asking for this option :) we should make the
the zero filling should in my opinion happen on kibana side, so we have full control over it and its something that shouldn't require many resources. |
I will close this, since we cannot simply remove this parameters. That will then also be a trouble switching over to date auto histogram unless those parameters are enabled there. |
This PR tests if we can safely remove the
extended_bounds
andmin_doc_count
of thedate_histogram
.The
extended_bounds
seems never to be set so we should safely be able to remove it, since it was never be part of the query.Without
min_doc_count
(which was always1
as far as I can see) we will get empty buckets within the available data range, which should just increase the response slightly but not change anything else.Since both of those params won't be available on the new auto date histogram aggregation in ES (and @colings86 is thinking about removing at least
min_doc_count
completely also from date histogram) we need to check out if we actually still need them in Kibana.