Default to chromium and add deprecation warning for phantom. #21505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
added
:Sharing
(Deprecated) Feature:Reporting
💔 Build Failed |
|
Seems like build failure may have been an interruption: jenkins, test this |
💚 Build Succeeded |
stacey-gammon
force-pushed
the
2018-07-31-default-to-chromium
branch
from
e09c617 to
a543b04
Compare
💚 Build Succeeded |
chrisdavies
approved these changes
Sep 5, 2018
| return true; | ||
| } | ||
| const releaseNumber = parseInt(release, 10); | ||
| return releaseNumber >= 7.0; |
There was a problem hiding this comment.
It's a bit odd to see a parseInt followed by a floating point comparison. I know this is JS, and it doesn't matter, but it seems like this should be >= 7.
…07-31-default-to-chromium
💚 Build Succeeded |
|
cc @LeeDr @rashidkpc @w33ble -- We have flipped the default switch to Chromium. When testing the canvas merge, please rebase and let us know if there are any issues! I'm hoping their won't be because Canvas only worked on chromium as it was, but, wanted all to be aware! |
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Sep 11, 2018
…#21505) * Default to chromium and add deprecation warning for phantom. * use int, not float
stacey-gammon
added a commit
that referenced
this pull request
Sep 11, 2018
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll start rolling out chromium as the default to our cloud users in 6.4. As long as that goes smoothly, we will default to chromium starting in 6.5.
Doing this now, instead of waiting till the last minute in 6.5 will give us some more chromium usage, any time dev's create reports.
If we hit any blockers, we can roll back the PR and switch back to phantom.