Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GIS] plugin #21508

Closed
wants to merge 209 commits into from
Closed

[GIS] plugin #21508

wants to merge 209 commits into from

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Jul 31, 2018 •
edited
Loading

DO NOT MERGE

For discussion purposes only.

High:

  • @thomasneirynck Remove errors and crashes (fine if no-op, but shouldn't crash)
    • click add layer
    • click on layer for layer details
    • click on remove layer
  • @aaronjcaldwell Syncing of app-state to Openlayers map tears down the layers and rebuilds from scratch. This causes slow and choppy user experience. Instead, changes in state should result in the appropriate method calls to manipulate the OL-state.
  • @thomasneirynck Model sources as pointers to data, and not the actual data. This is especially important for "linked" layers (such as EMS), but also for dynamic data (e.g. from Elasticsearch) where the data will be dependent on query/time. Model each source that is listed here Kibana GIS UI Phase 1 #19582 individually.
  • Heatmap layer with data round-trip to Elasticsearch (based on extent + zoom level)
  • Heatmap styling
  • layer removal

Mid:

  • @thomasneirynck Avoid loading EMS metadata at startup. This will hurt our on-prem users. No requests to EMS should be made if there is no EMS data on the map
  • @aaronjcaldwell use toast to indicate a layer has been added after clicking "add to map"
  • @aaronjcaldwell map should not stretch when screen resizes (e.g. when closing the phone home banner)
  • improve action semantics. e.g. selectAction should be a generic "previewer"-action, that can work with all source and layer-types
  • WMS data source
  • Kibana region layers data source

thomasneirynck and others added 30 commits May 29, 2018 11:06
@thomasneirynck
initial checkin
da5178e 
format
@thomasneirynck
add timepicker boilerplate
cfb82c4
@thomasneirynck
simplify init
0c78731
@thomasneirynck
add dummy file structure
9cc0e3b
@thomasneirynck
don't make layer/sources shims react components
ca5d1e2
@thomasneirynck
boilerplate for layer control
4c62706
@thomasneirynck
boilerplate for layr table of contents
b166e76
@thomasneirynck
introduce layer abstract class
f393567
@thomasneirynck
Merge branch 'master' into enh/gis-plugin
f47c4b5
@thomasneirynck
add jquery-ui-sortable stubs
5bc6835
@thomasneirynck
wire basic layer reordering with drag&drop
985a2d9
@thomasneirynck
remove cruft
6b1d816
First pass placeholder for index pattern import class
148c2f2
Formatting
9ea6619
Flyout placeholder logic embedded in kibana map component
05c9f1c
Add placeholder GIS util file
2321421
Merge branch 'enh/gis-plugin' of github.com:elastic/kibana into enh/g…
ad659ba 
…is-plugin
@thomasneirynck
hide flyout
3835dd8
@thomasneirynck
check in boilerplate for loading modules from kibana-core
56c733d
@thomasneirynck
add boilerplate to load kibana OSS modules from xpack
b9862fd
@thomasneirynck
add ems-file hook/boilerplate for vectorlayer
f766563
@thomasneirynck
remove console.log
5fba1ff
@thomasneirynck
add layer name display
f0d8865
@thomasneirynck
add ems tms source
575e9b9
@thomasneirynck
add source for kbn yml tilemap configuration
c3e2c57
@thomasneirynck
add vector source for layers in kibana.yml
96a1c7b
@thomasneirynck
wire visibility state to Layer
5e607cb
@thomasneirynck
rename for consistency
c3e614b
@thomasneirynck
add visibility toggle ui (basic func)
0cf8425
@thomasneirynck
add legend icon placeholder
eca4f6f
Aaron Caldwell and others added 16 commits July 23, 2018 12:25
Add back openlayers dependency
938e3ba
Add layer visible toggle action. Add bindings to action in toc_entry …
1243cc0 
…container
Move visibility toggle under toc_entry
8993151
Handle visible toggle action in reducer
12f42ee
Add selector for grabbing layer by id
181ab39
Connect layer toggle actions in view
6a516fe
Interpret layer visible prop to ol layers
4401953
Placeholder code to reset layers between modifications. Allows demo o…
95a705a 
…f layer visbile functionality
Fix some broken code to allow flyout
7a1c4ed
Apply temporary style to temporary layers
ada62c0
Add back layer click flyout behavior that somehow got removed
f14416c
Build map outside of component and pass in as props
c4ebd70
More optimal use of reselect
48bbdc3
Get map constants for ol selectors
ef3070e
@thomasneirynck
update yarn.lock
ba2d069
@thomasneirynck
Merge branch 'master' into enh/gis-plugin
76b00db
@thomasneirynck thomasneirynck requested a review from kindsun July 31, 2018 21:17
@thomasneirynck thomasneirynck changed the title [GIS] Add tms [GIS] Add tms (against master) Jul 31, 2018
@thomasneirynck thomasneirynck changed the title [GIS] Add tms (against master) [GIS] plugin Jul 31, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@thomasneirynck
remove console errors for flyout
4bba3d2
@thomasneirynck
Remove error on panel open.
3e36a73 
Function syntax does not play nice with redux connect()
@thomasneirynck
don't break on remove layer
b62d5c0 
add boilerplate

Add exception to stateless comp rule:wq
@thomasneirynck
dont crash on cancel
7b1bf12
@thomasneirynck
add tms
1251f82
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@thomasneirynck
Copy link
Contributor Author

Closing this in favor of #22194. That one is opened against the actual upstream branch iso personal fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindsun kindsun Awaiting requested review from kindsun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.