-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translate tutorials(kafka_logs, kafka_metrics, kibana_metrics, kubern… #22122
translate tutorials(kafka_logs, kafka_metrics, kibana_metrics, kubern… #22122
Conversation
…etes_metrics, logstash_logs, logstash_metrics, memcached_metrics)
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a duplicated string ID.
Is it possible to have the framework throw an error if this happens?
shortDescription: i18n.translate('kbn.server.tutorials.memcachedMetrics.shortDescription', { | ||
defaultMessage: 'Fetch internal metrics from the Memcached server.', | ||
}), | ||
longDescription: i18n.translate('kbn.server.tutorials.memcachedMetrics.shortDescription', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kbn.server.tutorials.memcachedMetrics.longDescription
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed. thanks!
@tsullivan I believe we do not need to throw errors. Soon we will have such validations like duplicating ids in our CI pipeline. So we will not be able to merge pull request if we have duplicating ids |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
elastic#22122) translate tutorials(kafka_logs, kafka_metrics, kibana_metrics, kubernetes_metrics, logstash_logs, logstash_metrics, memcached_metrics) # Conflicts: # src/core_plugins/kibana/server/tutorials/logstash_logs/index.js
#21957
translate tutorials(kafka_logs, kafka_metrics, kibana_metrics, kubernetes_metrics, logstash_logs, logstash_metrics, memcached_metrics)