Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert timepicker to EUI #22433

Closed
wants to merge 24 commits into from
Closed

Convert timepicker to EUI #22433

wants to merge 24 commits into from

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 27, 2018 •
edited
Loading

@elastic/kibana-design This PR needs some clean-up work. Here are the areas that need attention. I am sure there are more

  • Step forward and backwards buttons. I just placed them at the top of the quick select popover. Not sure where to place them.
  • Styling when from and to are invalid. To view, set the from to be after to.
  • Go button does not look right
  • I added a text input to the absolute form. There needs to be a way to edit the absolute date/time by typing into an input. This is used in all of our functional tests. I did not think it made sense to overload the element used to open the popover. That displays the formatted value and seemed like it should be read only since we do not allow the user to modify that value for relative times.
  • General styling of the timepicker when displayed in the nav bar needs some help

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor

snide commented Aug 28, 2018

Gonna take a stab at cleaning this up tomorrow.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@tsullivan tsullivan self-requested a review September 11, 2018 21:44
@nreese nreese mentioned this pull request Sep 19, 2018
Merged
@nreese nreese added v6.6.0 and removed v6.5.0 labels Oct 25, 2018
@cchaos
Copy link
Contributor

cchaos commented Nov 20, 2018

EUI updates to the global pattern have been merged: elastic/eui#1219

It should now have all that's needed to complete this PR.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese
Copy link
Contributor Author

nreese commented Dec 7, 2018

Closing, moving component directly into EUI - elastic/eui#1351

@nreese nreese closed this Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan Awaiting requested review from tsullivan

Assignees
No one assigned
Labels
chore Feature:Timepicker Timepicker v6.6.0 v7.0.0 WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @snide @cchaos