[ML] Migrates Anomaly Explorer Swimlanes to React #22641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-ui |
88 tasks
9 tasks
jgowdyelastic
approved these changes
Sep 4, 2018
|
|
||
| // Listen for dragSelect events | ||
| const that = this; | ||
| this.dragSelectListener = function ({ action, elements = [] }) { |
There was a problem hiding this comment.
if these were converted to arrow functions you should mean the assignment of that could be removed.
cellClick could also be made a method and an arrow function.
probably not for this PR, but maybe a future refactor
There was a problem hiding this comment.
thanks, took a note in #22642
| @@ -443,7 +72,6 @@ module.directive('mlExplorerSwimlane', function ($compile, Private, mlExplorerDa | |||
| chartWidth: '=', | |||
| appState: '=' | |||
| }, | |||
| link: link, | |||
| template: template | |||
| link: link | |||
peteharverson
approved these changes
Sep 4, 2018
| * React component for rendering Explorer dashboard swimlanes. | ||
| */ | ||
|
|
||
| //import PropTypes from 'prop-types'; |
There was a problem hiding this comment.
Can this commented out line be removed?
| // Listen for dragSelect events | ||
| const that = this; | ||
| this.dragSelectListener = function ({ action, elements = [] }) { | ||
| if (action === 'newSelection' && elements.length > 0) { |
There was a problem hiding this comment.
These action 'types' could be moved into constants - either at the top of the file or a separate file
There was a problem hiding this comment.
Thanks, took a note in the follow-up issue: #22642
| class: 'lane', | ||
| }); | ||
|
|
||
| //$lane.on('mouseover', cellMouseover); |
There was a problem hiding this comment.
Can these commented out lines be removed?
💔 Build Failed |
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Sep 4, 2018
- This PR migrates the Anomaly Explorer Swimlanes from angularjs to React. - The approach is similar to the one from elastic#22622: Try to refactor as little of the actual logic as possible, just make sure everything works inside the React component lifecycle. So as a guide for the review: No actual code within all the functions/methods changed, only the bits and pieces which needed to be tied into the React component lifecycle. - The remaining wrapping angular directive is now only listening for data changes and passes its scope and other necessary data on as props to the React component.
walterra
added a commit
that referenced
this pull request
Sep 4, 2018
- This PR migrates the Anomaly Explorer Swimlanes from angularjs to React. - The approach is similar to the one from #22622: Try to refactor as little of the actual logic as possible, just make sure everything works inside the React component lifecycle. So as a guide for the review: No actual code within all the functions/methods changed, only the bits and pieces which needed to be tied into the React component lifecycle. - The remaining wrapping angular directive is now only listening for data changes and passes its scope and other necessary data on as props to the React component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the Anomaly Explorer Swimlanes from angularjs to React.
The approach is similar to the one from #22622: Try to refactor as little of the actual logic as possible, just make sure everything works inside the React component lifecycle. So as a guide for the review: No actual code within all the functions/methods changed, only the bits and pieces which needed to be tied into the React component lifecycle.
The remaining wrapping angular directive is now only listening for data changes and passes its scope and other necessary data on as props to the React component.