[ML] Make field type icon component keyboard accessible #22708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
release_note:fix
Project:Accessibility
v7.0.0
:ml
Feature:ml-results
|
Pinging @elastic/ml-ui |
peteharverson
changed the title
💔 Build Failed |
|
jenkins test this |
💔 Build Failed |
peteharverson
force-pushed
the
ml-field-type-icon-a11y
branch
from
792f167 to
6b3ef33
Compare
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Sep 5, 2018
peteharverson
added a commit
that referenced
this pull request
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of accessibility issues with the field type icon component, as used on the cards in the Data Visualizer, which were highlighted by #22414:
aria-labelattribute is now the same as that used in the tooltip referenced by thearia-describedbyattribute, so that the text read out by the screen reader matches the text shown visually in the tooltip. The text also now matches the names of the types, as shown in the 'filter by type' dropdown of the Data Visualizer.Related to #22414