Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _source formatting #22800

Merged
merged 4 commits into from
Sep 10, 2018
Merged

Fix _source formatting #22800

merged 4 commits into from
Sep 10, 2018

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Sep 7, 2018 •
edited
Loading

Fix ESA-2018-14 / CVE-2018-3830

This PR fixes #22770

@markov00 markov00 added bug Fixes for quality problems that affect the customer experience :Management v7.0.0 v6.5.0 v6.4.1 labels Sep 7, 2018
@markov00 markov00 requested review from epixa and timroes September 7, 2018 10:00
timroes
timroes approved these changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the described behavior

@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@epixa epixa mentioned this pull request Sep 7, 2018
Closed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

epixa
epixa approved these changes Sep 8, 2018
View reviewed changes
Copy link
Contributor

@epixa epixa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markov00 markov00 merged commit 45e4791 into elastic:master Sep 10, 2018
@markov00 markov00 mentioned this pull request Sep 10, 2018
Merged
markov00 added a commit to markov00/kibana that referenced this pull request Sep 10, 2018
@markov00
Fix _source formatting (elastic#22800)
c30d8d0 
* Fix _source formatting

* Update unit test

* Add functional test

* Fix CI error, move functional test to the end
@markov00 markov00 mentioned this pull request Sep 10, 2018
Merged
markov00 added a commit to markov00/kibana that referenced this pull request Sep 10, 2018
@markov00
Fix _source formatting (elastic#22800)
23399f9 
* Fix _source formatting

* Update unit test

* Add functional test

* Fix CI error, move functional test to the end
@markov00 markov00 mentioned this pull request Sep 10, 2018
Merged
markov00 added a commit that referenced this pull request Sep 10, 2018
@markov00
Fix _source formatting (#22800) (#22865)
c74da9c 
* Fix _source formatting

* Update unit test

* Add functional test

* Fix CI error, move functional test to the end
markov00 added a commit that referenced this pull request Sep 10, 2018
@markov00
Fix _source formatting (#22800) (#22864)
e4c7e21 
* Fix _source formatting

* Update unit test

* Add functional test

* Fix CI error, move functional test to the end
epixa pushed a commit that referenced this pull request Sep 10, 2018
@markov00 @epixa
[5.6] Fix _source formatting (#22800) (#22867)
a073474 
* Backport fix to 5.6 structure

* Fix CI error, update functional test to use 5.6 visualize page objects

* removed async and anon function
@LeeDr LeeDr added the v5.6.12 label Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@epixa epixa epixa approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience v5.6.12 v6.4.1 v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuring a Top Hit metric on _source throws fatal error
5 participants
@markov00 @elasticmachine @epixa @timroes @LeeDr