[APM] Minor cleanup #22827
Merged
[APM] Minor cleanup #22827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
added
Team:APM
|
Pinging @elastic/apm-ui |
sorenlouv
commented
Sep 7, 2018
| @@ -31,4 +31,6 @@ export const ERROR_LOG_MESSAGE = 'error.log.message'; | |||
| export const ERROR_EXC_MESSAGE = 'error.exception.message'; | |||
| export const ERROR_EXC_HANDLED = 'error.exception.handled'; | |||
|
|
|||
| export const REQUEST_URL_FULL = 'context.request.url.full'; | |||
There was a problem hiding this comment.
This was duplicated so added it as a constants
sorenlouv
commented
Sep 7, 2018
| url={url} | ||
| stickyProperties={stickyProperties} | ||
| /> | ||
| <StickyProperties stickyProperties={stickyProperties} /> |
There was a problem hiding this comment.
StickyProperties component now only takes a list of properties, so everything should be declared in that structure (previously url and timestamp was passed in separately).
💔 Build Failed |
sorenlouv
force-pushed
the
apm-cleanup
branch
from
13857ae to
ef5d1cd
Compare
sorenlouv
force-pushed
the
apm-cleanup
branch
from
ef5d1cd to
124fd2d
Compare
💚 Build Succeeded |
💚 Build Succeeded |
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Sep 8, 2018
# Conflicts: # x-pack/plugins/apm/public/components/app/TransactionOverview/view.js
sorenlouv
added a commit
that referenced
this pull request
Sep 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the DT PR I found myself fixing a couple of minor things. Moving that to a separate PR. Sorry for the mixed bag!