[core/public/navLinks] migrate ui/chrome/navLinks API #23217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
migrate-new-platform/nav-links
branch
2 times, most recently
from
c6105be to
7f174ba
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
migrate-new-platform/nav-links
branch
3 times, most recently
from
0d80cad to
3a8b25d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
migrate-new-platform/nav-links
branch
3 times, most recently
from
4291a12 to
f0f3772
Compare
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
migrate-new-platform/nav-links
branch
3 times, most recently
from
627b317 to
ee50248
Compare
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
migrate-new-platform/nav-links
branch
2 times, most recently
from
1c99c94 to
164d7ea
Compare
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
migrate-new-platform/nav-links
branch
2 times, most recently
from
8a08266 to
9110e82
Compare
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
migrate-new-platform/nav-links
branch
from
9110e82 to
076a4b0
Compare
spalger
force-pushed
the
migrate-new-platform/nav-links
branch
2 times, most recently
from
0b6e468 to
bf7954c
Compare
spalger
force-pushed
the
migrate-new-platform/nav-links
branch
2 times, most recently
from
1e23418 to
1e5803c
Compare
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
migrate-new-platform/nav-links
branch
from
1e5803c to
d91acd6
Compare
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
migrate-new-platform/nav-links
branch
from
d91acd6 to
ac78e17
Compare
This comment has been minimized.
This comment has been minimized.
added 2 commits
September 20, 2018 11:53
spalger
force-pushed
the
migrate-new-platform/nav-links
branch
from
ac78e17 to
50f31b6
Compare
💚 Build Succeeded |
|
I forgot to port over a pretty important feature here that is going to take some time to get in, and since tomorrow is my last day before vacation I'm going to close this and try to get this in once I'm back. |
spalger
pushed a commit
that referenced
this pull request
Oct 17, 2018
In `ui/public/config/config.js` we have subscription logic that delivers values from an observable synchronously and also ensuring that values are received within a digest cycle. I need to do the same in #23217 but want to keep as few checks for `$rootScope.$$phase` as possible, so I broke the subscription logic into a shared util. In order to make the utility a little more helpful it will also trigger fatal errors if an observable errors without having an error handler, or if `observer.next()`, `observer.error()`, or `observer.complete()` throw, which would normally be swallowed by RxJS.
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 17, 2018
In `ui/public/config/config.js` we have subscription logic that delivers values from an observable synchronously and also ensuring that values are received within a digest cycle. I need to do the same in elastic#23217 but want to keep as few checks for `$rootScope.$$phase` as possible, so I broke the subscription logic into a shared util. In order to make the utility a little more helpful it will also trigger fatal errors if an observable errors without having an error handler, or if `observer.next()`, `observer.error()`, or `observer.complete()` throw, which would normally be swallowed by RxJS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another part of #19992, based on #23341