Timelion less to sass #23339
Merged
Timelion less to sass #23339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moves styles closer to their actual components in `public/vis/…` (agg stuff did not get naming updates) - Also fixes responsive layout to actually show the visualization - Updated to `<icon/>` EUI usage where possible
# Conflicts: # src/core_plugins/kibana/public/visualize/editor/styles/_editor.less
Introduce legacyIcon
- And fixed up Markdown options (the only one) that relied on it - Removed unnecessary flex parents
- Also updated ems-hotlink
- The embeddable `/vis` now imports the compiled `index.css` that lives one folder up
…o-sass # Conflicts: # src/core_plugins/input_control_vis/public/register_vis.js # src/core_plugins/markdown_vis/public/markdown_vis.js # src/core_plugins/markdown_vis/public/markdown_vis_params.html # src/ui/public/styles/variables/for-theme.less # src/ui/public/vis/editors/default/_agg_group.scss # src/ui/public/vis/editors/default/_index.scss # src/ui/public/vis/editors/default/agg_group.html # x-pack/plugins/ml/public/jobs/new_job/wizard/steps/index_or_search/index_or_search.html
|
Ugh, it looks like the error is happening because the bundler hasn't built the I've updated the PR to actually import the scss files it needs for embedded visualizations in |
💔 Build Failed |
💚 Build Succeeded |
timroes
reviewed
Sep 20, 2018
| * 1. Anchor suggestions beneath input. | ||
| * 2. Allow for option of positioning suggestions absolutely. | ||
| */ | ||
| .timExpressionInput__container { |
There was a problem hiding this comment.
🎨 unnecessary leading space
timroes
reviewed
Sep 20, 2018
| </div> | ||
| </div> | ||
| <div ng-show="page === 2"> | ||
| <div ng-show="!es.valid"> | ||
| <div class="doc-container-content"> | ||
| <div > |
There was a problem hiding this comment.
🎨 remove that unnecessary space
timroes
approved these changes
Sep 20, 2018
| </div> | ||
| </div> | ||
| <div ng-show="es.valid"> | ||
| <div class="doc-container-content"> | ||
| <div > |
| </div> | ||
| </div> | ||
| </div> | ||
| <div ng-show="page === 3"> | ||
| <div class="doc-container-content"> | ||
| <div > |
| </div> | ||
| </div> | ||
|
|
||
| <div ng-show="page === 4"> | ||
| <div class="doc-container-content"> | ||
| <div > |
| </div> | ||
| </div> | ||
| <div ng-show="page === 5"> | ||
| <div class="doc-container-content"> | ||
| <div > |
💔 Build Failed |
|
Seems flakey, Jenkins, test this |
💔 Build Failed |
|
OI... Jenkins, test this |
💚 Build Succeeded |
|
@snide Do you want to take a quick peruse? |
chrisronline
pushed a commit
that referenced
this pull request
Sep 21, 2018
cchaos
added a commit
to cchaos/kibana
that referenced
this pull request
Sep 21, 2018
cchaos
added a commit
that referenced
this pull request
Sep 22, 2018
chrisronline
added a commit
that referenced
this pull request
Sep 24, 2018
* Merge in boilerplate branch * Manually copy over the specific metrics and UIs * Add api integration tests * Fix tests * Remove unused metrics * Update snapshot * Fix tests * Remove types agg * Use ApmClusterMetric * provide description for apm-server monitoring metrics (#23331) * Vis LESS to SASS (cont.) (#23199) * Tweak migrations integraiton tests to have a stable sort (#23265) * Fix: plugin api route with security enabled (#23334) Closes #23266 This is more of a quick fix than the final solution. The issue was that Canvas tries to check the plugins API without checking to see if the user it logged in. As a result, instead of the plugins response, it gets the HTML from the login page and that causes an error to be thrown when attempting to parse the results. For now, this PR just disables the auth requirement on the Canvas plugin API endpoint. * [migrations/tests] sort results before assertion (#23347) There have been several failures in this test, seemingly caused by a lack of sorting in the results. It makes sense that since both migrations are run simultaneously that sometimes one would succeed and sometimes another would, so I've just sorted the results before checking.  cc: @chrisdavies * [ML] Moves custom URL editor Add button and form to top of flyout (#23326) * [ML] Moves custom URL editor Add button and form to top of flyout * [ML] Edits to custom URL editor class name * Graph LESS to SASS (#23348) * Developer documentation for integrating with the telemetry service (#23295) * Developer documentation for integrating with the telemetry service * open with a bang * more faqs * thing about tracking ui interactions * talk to the plat team * create and register * Fix a bug where ES sends a string and migrations expect a boolean (#23313) * chore: use cheerio in i18n.html.getDirectiveMessages (#23342) this was only using jsdom to parse html, but cheerio allows parsing html without requiring a dom. cheerio was also already in the dependency list. * [core/utils] add shareWeakReplay() operator (#23333) * Chore: fix canvas test runner (#23336) Blocked by #23342 This fixes the local test runner in Canvas. It should not affect anything else, including the CI test runner. - Bumps JSDOM to ^12.0.0 - I matched Kibana's version on migration, but nothing else in X-Pack uses JSDOM, so we can use the newer version (which has a very different API) - I had to match it because of a script that enforces version matching, but #23342 removed jsdom from Kibana, so we no longer have a version to match - Restores the local `.babelrc` file - I thought it was only used for building plugins; I was wrong 😢 * Convert Discover open top nav to EUI flyout (#22971) * move find logic to SavedObjectFinder component since savedObjectClient is no longer coupled to angular * implement flyout open saved searches * remove old open stuff * add jest test for OpenSearchPanel and simplify panel title * fix functional tests * fix _lab_mode functional test * Migrate save top nav in Discover and Visualize to EUI (#23190) * extract reusable save component from DashboardSaveModal * update discover search to use SavedObjectSaveModal * create generic show_save_model that works for both discover and dashboard * fix last bits of discover save * remove old save functionallity * migrate visualize save to EUI * fix functional tests * disable save button if title is empty * mark title input as invalid when title is not provided * fix funtional tests * Moves styleSheetPath to uiExports (#23007) This was previously defined in uiExports.app, which limited plugins which are not an app of providing a stylesheet. This allows any plugin to define a stylesheet which will be available on page load. * Timelion less to sass (#23339) * Consistent casing * Fix snapshot * Update tests
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Sep 24, 2018
* Merge in boilerplate branch * Manually copy over the specific metrics and UIs * Add api integration tests * Fix tests * Remove unused metrics * Update snapshot * Fix tests * Remove types agg * Use ApmClusterMetric * provide description for apm-server monitoring metrics (elastic#23331) * Vis LESS to SASS (cont.) (elastic#23199) * Tweak migrations integraiton tests to have a stable sort (elastic#23265) * Fix: plugin api route with security enabled (elastic#23334) Closes elastic#23266 This is more of a quick fix than the final solution. The issue was that Canvas tries to check the plugins API without checking to see if the user it logged in. As a result, instead of the plugins response, it gets the HTML from the login page and that causes an error to be thrown when attempting to parse the results. For now, this PR just disables the auth requirement on the Canvas plugin API endpoint. * [migrations/tests] sort results before assertion (elastic#23347) There have been several failures in this test, seemingly caused by a lack of sorting in the results. It makes sense that since both migrations are run simultaneously that sometimes one would succeed and sometimes another would, so I've just sorted the results before checking.  cc: @chrisdavies * [ML] Moves custom URL editor Add button and form to top of flyout (elastic#23326) * [ML] Moves custom URL editor Add button and form to top of flyout * [ML] Edits to custom URL editor class name * Graph LESS to SASS (elastic#23348) * Developer documentation for integrating with the telemetry service (elastic#23295) * Developer documentation for integrating with the telemetry service * open with a bang * more faqs * thing about tracking ui interactions * talk to the plat team * create and register * Fix a bug where ES sends a string and migrations expect a boolean (elastic#23313) * chore: use cheerio in i18n.html.getDirectiveMessages (elastic#23342) this was only using jsdom to parse html, but cheerio allows parsing html without requiring a dom. cheerio was also already in the dependency list. * [core/utils] add shareWeakReplay() operator (elastic#23333) * Chore: fix canvas test runner (elastic#23336) Blocked by elastic#23342 This fixes the local test runner in Canvas. It should not affect anything else, including the CI test runner. - Bumps JSDOM to ^12.0.0 - I matched Kibana's version on migration, but nothing else in X-Pack uses JSDOM, so we can use the newer version (which has a very different API) - I had to match it because of a script that enforces version matching, but elastic#23342 removed jsdom from Kibana, so we no longer have a version to match - Restores the local `.babelrc` file - I thought it was only used for building plugins; I was wrong 😢 * Convert Discover open top nav to EUI flyout (elastic#22971) * move find logic to SavedObjectFinder component since savedObjectClient is no longer coupled to angular * implement flyout open saved searches * remove old open stuff * add jest test for OpenSearchPanel and simplify panel title * fix functional tests * fix _lab_mode functional test * Migrate save top nav in Discover and Visualize to EUI (elastic#23190) * extract reusable save component from DashboardSaveModal * update discover search to use SavedObjectSaveModal * create generic show_save_model that works for both discover and dashboard * fix last bits of discover save * remove old save functionallity * migrate visualize save to EUI * fix functional tests * disable save button if title is empty * mark title input as invalid when title is not provided * fix funtional tests * Moves styleSheetPath to uiExports (elastic#23007) This was previously defined in uiExports.app, which limited plugins which are not an app of providing a stylesheet. This allows any plugin to define a stylesheet which will be available on page load. * Timelion less to sass (elastic#23339) * Consistent casing * Fix snapshot * Update tests
chrisronline
added a commit
that referenced
this pull request
Sep 24, 2018
* Merge in boilerplate branch * Manually copy over the specific metrics and UIs * Add api integration tests * Fix tests * Remove unused metrics * Update snapshot * Fix tests * Remove types agg * Use ApmClusterMetric * provide description for apm-server monitoring metrics (#23331) * Vis LESS to SASS (cont.) (#23199) * Tweak migrations integraiton tests to have a stable sort (#23265) * Fix: plugin api route with security enabled (#23334) Closes #23266 This is more of a quick fix than the final solution. The issue was that Canvas tries to check the plugins API without checking to see if the user it logged in. As a result, instead of the plugins response, it gets the HTML from the login page and that causes an error to be thrown when attempting to parse the results. For now, this PR just disables the auth requirement on the Canvas plugin API endpoint. * [migrations/tests] sort results before assertion (#23347) There have been several failures in this test, seemingly caused by a lack of sorting in the results. It makes sense that since both migrations are run simultaneously that sometimes one would succeed and sometimes another would, so I've just sorted the results before checking.  cc: @chrisdavies * [ML] Moves custom URL editor Add button and form to top of flyout (#23326) * [ML] Moves custom URL editor Add button and form to top of flyout * [ML] Edits to custom URL editor class name * Graph LESS to SASS (#23348) * Developer documentation for integrating with the telemetry service (#23295) * Developer documentation for integrating with the telemetry service * open with a bang * more faqs * thing about tracking ui interactions * talk to the plat team * create and register * Fix a bug where ES sends a string and migrations expect a boolean (#23313) * chore: use cheerio in i18n.html.getDirectiveMessages (#23342) this was only using jsdom to parse html, but cheerio allows parsing html without requiring a dom. cheerio was also already in the dependency list. * [core/utils] add shareWeakReplay() operator (#23333) * Chore: fix canvas test runner (#23336) Blocked by #23342 This fixes the local test runner in Canvas. It should not affect anything else, including the CI test runner. - Bumps JSDOM to ^12.0.0 - I matched Kibana's version on migration, but nothing else in X-Pack uses JSDOM, so we can use the newer version (which has a very different API) - I had to match it because of a script that enforces version matching, but #23342 removed jsdom from Kibana, so we no longer have a version to match - Restores the local `.babelrc` file - I thought it was only used for building plugins; I was wrong 😢 * Convert Discover open top nav to EUI flyout (#22971) * move find logic to SavedObjectFinder component since savedObjectClient is no longer coupled to angular * implement flyout open saved searches * remove old open stuff * add jest test for OpenSearchPanel and simplify panel title * fix functional tests * fix _lab_mode functional test * Migrate save top nav in Discover and Visualize to EUI (#23190) * extract reusable save component from DashboardSaveModal * update discover search to use SavedObjectSaveModal * create generic show_save_model that works for both discover and dashboard * fix last bits of discover save * remove old save functionallity * migrate visualize save to EUI * fix functional tests * disable save button if title is empty * mark title input as invalid when title is not provided * fix funtional tests * Moves styleSheetPath to uiExports (#23007) This was previously defined in uiExports.app, which limited plugins which are not an app of providing a stylesheet. This allows any plugin to define a stylesheet which will be available on page load. * Timelion less to sass (#23339) * Consistent casing * Fix snapshot * Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the LESS files for the Timeline plugin and replaces them with Sass.
Process taken
src/core_plugins/timelion/index.jsfile was updated to buildsrc/core_plugins/timelion/public/index.scssinto a css file.styling_constants.scssfromui/public/stylesin Kibana. This a placeholder file that includes all theming and invisible sass globals from EUI.timelion/public/...directory were replaced with sass counterparts._index.scssand_component_names.scssfiles next to the components or views they live next to.timwas added to all selectors to namespace them and avoid conflicts.Enhancements
The help/tutorial section at the top had no text styles whatsover. I added the
.euiTextclass to the wrapping div just to apply some basic semantic styles:Before
After
@elastic/kibana-app or @elastic/kibana-visualizations teams, please assign a reviewer