Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fixes Anomaly Explorer resize listener. #23427

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

walterra
Copy link
Contributor

Fixes the cleanup of the resize listener once you change to another page within the ML plugin.

Note: This fix is still based on the existing jQuery code which we're trying to get away from eventually. I just fixed the bug here without a migration to avoid introducing any regressions.


Part of #22626.

@walterra walterra added bug Fixes for quality problems that affect the customer experience v7.0.0 :ml Feature:ml-results legacy - do not use v6.5.0 labels Sep 24, 2018
@walterra walterra self-assigned this Sep 24, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@walterra walterra merged commit 55d5500 into elastic:master Sep 24, 2018
@walterra walterra deleted the ml-fix-resize-listener branch September 24, 2018 11:58
walterra added a commit to walterra/kibana that referenced this pull request Sep 24, 2018
Fixes the cleanup of the resize listener once you change to another page within the ML plugin.
walterra added a commit that referenced this pull request Sep 24, 2018
Fixes the cleanup of the resize listener once you change to another page within the ML plugin.
@sophiec20 sophiec20 added the Feature:Anomaly Detection ML anomaly detection label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection Feature:ml-results legacy - do not use :ml v6.5.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants