Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.4] Fixes the positioning of a button popover in index management #23801

Merged
merged 4 commits into from
Oct 5, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented Oct 4, 2018

Fixes #23647

This ups 6.4's EUI version to 3.07, which backports a mutation observer fix for popovers.

For the tests to pass I also cherry picked out #20996 which was needed for the tests to pass.

snide and others added 3 commits October 3, 2018 22:30
* add mutation observer polyfill for jest test env

* use polyfill from npm

* set bluebird scheduler

* use correct version in comment about bluebird
@snide snide requested a review from cjcenizal October 4, 2018 05:46
@snide snide added v6.4.3 release_note:fix bug Fixes for quality problems that affect the customer experience backport labels Oct 4, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Oct 4, 2018

Shoot. Yarn link strikes again. I'll fix in morning

@snide
Copy link
Contributor Author

snide commented Oct 4, 2018

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good locally! Great work @snide. Thanks for handling this.

@snide snide merged commit 142540f into elastic:6.4 Oct 5, 2018
@snide snide deleted the mgmt_popovers branch October 5, 2018 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Fixes for quality problems that affect the customer experience release_note:fix v6.4.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants