Upgrade assistant - Phase 1 #25168

joshdover · 2018-11-05T21:07:53Z

Summary

Closes #26210

Adds a "7.0 Upgrade Assistant" to the Elasticsearch section of the Management app.
UI shows deprecation warnings for cluster and nodes
Shows a button to open the reindexing steps in the Console

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~Documentation was added for features that require explanation or tutorials~~ (Being handled by @gchaps)
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2018-11-05T21:07:55Z

Pinging @elastic/kibana-operations

elasticmachine · 2018-11-05T23:17:14Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-11-08T20:19:27Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-11-08T22:33:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-11-09T20:34:50Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-11-10T00:23:06Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-11-14T00:27:15Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-11-14T23:35:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

joshdover · 2018-11-15T22:47:16Z

I've updated this to use tables when grouping by issue. This should help with customers who have a thousands of indices that have the same problem. With a table we get pagination and sorting that allows them easily see issues without blowing up the size of the page while also being able to quickly see index-specific details in the right column.

elasticmachine · 2018-12-14T21:18:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-12-17T18:01:20Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-12-17T20:35:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

tylersmalley · 2018-12-18T20:40:59Z

x-pack/plugins/upgrade_assistant/public/components/tabs/checkup/deprecations/list.test.tsx

+
+    test('shows simple messages when index field is not present', () => {
+      expect(shallow(<DeprecationList {...defaultProps} />)).toMatchInlineSnapshot(`
+<div>


dedent is nice to keep this inline - not necessary to change, just an FYI.

tylersmalley · 2018-12-18T20:49:04Z

I am not seeing the open in console button show up for indices which need re-indexed.

joshdover · 2018-12-18T20:54:12Z

I am not seeing the open in console button show up for indices which need re-indexed.

Ah yeah it won't work when you're running off master since it's looking for the 7.0 -> 8.0 upgrade message. You can override this by changin this file: x-pack/plugins/upgrade_assistant/common/version.ts

tylersmalley

LGTM

tylersmalley · 2018-12-18T21:45:47Z

As discussed, we removed console reindexing templates until we ensure it's the correct guidance.

elasticmachine · 2018-12-18T21:47:19Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

tylersmalley · 2018-12-18T21:51:30Z

x-pack/plugins/upgrade_assistant/server/lib/es_migration_apis.test.ts

+import { getUpgradeAssistantStatus } from './es_migration_apis';
+
+import { DeprecationAPIResponse } from 'src/legacy/core_plugins/elasticsearch';
+import { CURRENT_MAJOR_VERSION } from '../../common/version';


Looks like this can be removed.

elasticmachine · 2018-12-18T22:38:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Get basic scaffolding working * Wire up cluster checkup data * Add types for elasticsearch plugin * Implement basics of checkup tab * Update style of deprecations * Add copy and reload button to checkup * Add filtering by warning level * Add deprecation logging tab * Copy updates and cleanup * Type cleanup * Move deprecation logging to overview tab * Make filters togglable * Move sections into tabs and add support for grouping * Cleanup and add clearer labels * Use tables for message grouping * Cleanup and small fixes * Allow console to load relative URLs * Add reindex in console button to reindex tasks * Merge documentation UI and uiButtons * Fix tests * Filter bar tweaks * Filter out index settings that can't be set * Fix types * Add tests for deprecation_logging * Add tests for reindex templates * Make KibanaConfig generic * Simplify integration test * Finish backend unit tests * Fixup types * Fix uiButton updating for reindex items * Fixed background color stretching * Pulling tabs out and re-ordering filter buttons * Making accordions more item-list like * Turned Healths into Badges - Couldn’t do the conversion within the cell because it only passed color * Fix overflow issue * Optional filter and expand/collapse controls * Reorganizing - Added placeholder for moving action button up into accordion header - Removed repetitive message name outputs - Slightly better listing of each message when sorting by index - Only showing number of severity when sorting by index - Still need to allow showing all severity levels - Added indice count when sorting by issue * Putting `Deprecation logging` in a `EuiDescribedFormGroup` * Added some stats, empty prompts, and all clear prompt * Added docs link * Cleaned up sass files * Revert changes to fake_deprecations * Update blacklisted settings * wip * Move data fetching and tab control * Wire up overview summary * Cleanup docs/uiButtons + move actions to index table * Add expand/collapse all functionality * Wire up search box * Wire up severity indicators * Fix types * Round out functional tests * Fix fake data * Remove info deprecation level * Fix extra space on cluster tab control bar * Cleanup code and localize majority of UI controls * Change overview tab to steps layout * Update copy * Localize overview tab * Complete localization of checkup tabs * Make ES version dynamic based on branch * Add pagination to checkup tabs * Rename checkup -> assistant * Cleanup filter and group by bars * WIP UI unit tests * Copy tweaks * Fix i18n formatting issues * Update tests for copy * Add tests for remaining UI * Fix pagination w/ filter changes + table button color * Small cleanup * Add reindex button to old index deprecations * Add shrunken indices setting to copy settings blacklist for elastic#18469 * Add next steps to overview tab + update copy * Remove usage of migration assistance API * Use all/critical toggle for filter buttons * Cloud upgrade copy * Translate reindex button * Remove hacked EUI type * Show incomplete banner on all tabs * Update copy for waiting for next version * Review comments * Update deprecation level type * Update checkup tab snapshots * Remove dependencies on types from elastic#25168 * Use types from new global type defs * Remove 'Reindex in Console' button * Remove unused variable

elasticmachine · 2018-12-18T23:58:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Upgrade assistant - Phase 1 (#25168) * Get basic scaffolding working * Wire up cluster checkup data * Add types for elasticsearch plugin * Implement basics of checkup tab * Update style of deprecations * Add copy and reload button to checkup * Add filtering by warning level * Add deprecation logging tab * Copy updates and cleanup * Type cleanup * Move deprecation logging to overview tab * Make filters togglable * Move sections into tabs and add support for grouping * Cleanup and add clearer labels * Use tables for message grouping * Cleanup and small fixes * Allow console to load relative URLs * Add reindex in console button to reindex tasks * Merge documentation UI and uiButtons * Fix tests * Filter bar tweaks * Filter out index settings that can't be set * Fix types * Add tests for deprecation_logging * Add tests for reindex templates * Make KibanaConfig generic * Simplify integration test * Finish backend unit tests * Fixup types * Fix uiButton updating for reindex items * Fixed background color stretching * Pulling tabs out and re-ordering filter buttons * Making accordions more item-list like * Turned Healths into Badges - Couldn’t do the conversion within the cell because it only passed color * Fix overflow issue * Optional filter and expand/collapse controls * Reorganizing - Added placeholder for moving action button up into accordion header - Removed repetitive message name outputs - Slightly better listing of each message when sorting by index - Only showing number of severity when sorting by index - Still need to allow showing all severity levels - Added indice count when sorting by issue * Putting `Deprecation logging` in a `EuiDescribedFormGroup` * Added some stats, empty prompts, and all clear prompt * Added docs link * Cleaned up sass files * Revert changes to fake_deprecations * Update blacklisted settings * wip * Move data fetching and tab control * Wire up overview summary * Cleanup docs/uiButtons + move actions to index table * Add expand/collapse all functionality * Wire up search box * Wire up severity indicators * Fix types * Round out functional tests * Fix fake data * Remove info deprecation level * Fix extra space on cluster tab control bar * Cleanup code and localize majority of UI controls * Change overview tab to steps layout * Update copy * Localize overview tab * Complete localization of checkup tabs * Make ES version dynamic based on branch * Add pagination to checkup tabs * Rename checkup -> assistant * Cleanup filter and group by bars * WIP UI unit tests * Copy tweaks * Fix i18n formatting issues * Update tests for copy * Add tests for remaining UI * Fix pagination w/ filter changes + table button color * Small cleanup * Add reindex button to old index deprecations * Add shrunken indices setting to copy settings blacklist for #18469 * Add next steps to overview tab + update copy * Remove usage of migration assistance API * Use all/critical toggle for filter buttons * Cloud upgrade copy * Translate reindex button * Remove hacked EUI type * Show incomplete banner on all tabs * Update copy for waiting for next version * Review comments * Update deprecation level type * Update checkup tab snapshots * Remove dependencies on types from #25168 * Use types from new global type defs * Remove 'Reindex in Console' button * Remove unused variable * Update snapshots

joshdover · 2018-12-19T00:54:00Z

6.x: 6721466

Get basic scaffolding working

dfbca71

joshdover added WIP Work in progress Team:Operations Team label for Operations Team v7.0.0 v6.6.0 labels Nov 5, 2018

joshdover added 3 commits November 6, 2018 12:06

Wire up cluster checkup data

6272b61

Add types for elasticsearch plugin

96fee8b

Implement basics of checkup tab

c85ea7b

joshdover added 3 commits November 8, 2018 14:39

Update style of deprecations

bc68417

Add copy and reload button to checkup

c837c2d

Add filtering by warning level

35b8fa7

joshdover added 2 commits November 9, 2018 14:02

Add deprecation logging tab

8850f0c

Copy updates and cleanup

2e4cdac

Type cleanup

6b4ef02

joshdover added 4 commits November 13, 2018 12:23

Merge remote-tracking branch 'upstream/master' into upgrade-checkup

056cf1f

Move deprecation logging to overview tab

3f46e59

Make filters togglable

014f67b

Move sections into tabs and add support for grouping

2d37317

joshdover added 2 commits November 14, 2018 14:30

Cleanup and add clearer labels

dec8827

Merge remote-tracking branch 'upstream/master' into upgrade-checkup

f463bf2

Use tables for message grouping

f104f68

Update checkup tab snapshots

c386377

Remove dependencies on types from elastic#25168

b620615

joshdover added the release_note:enhancement label Dec 17, 2018

joshdover added 2 commits December 17, 2018 12:53

Merge remote-tracking branch 'upstream/master' into upgrade-checkup

42ddd6e

Use types from new global type defs

338299c

tylersmalley reviewed Dec 18, 2018

View reviewed changes

Remove 'Reindex in Console' button

685d336

tylersmalley approved these changes Dec 18, 2018

View reviewed changes

tylersmalley reviewed Dec 18, 2018

View reviewed changes

Remove unused variable

e056575

joshdover merged commit 4d295c7 into elastic:master Dec 18, 2018

joshdover deleted the upgrade-checkup branch December 18, 2018 23:08

joshdover mentioned this pull request Dec 18, 2018

[6.x] Upgrade assistant - Phase 1 (#25168) #27452

Merged

joshdover added backport pending and removed review labels Dec 18, 2018

joshdover added backported and removed backport pending labels Dec 19, 2018

bhavyarm mentioned this pull request Jan 11, 2019

[meta] Accessibility Audit for Kibana 6.6 #28599

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade assistant - Phase 1 #25168

Upgrade assistant - Phase 1 #25168

joshdover commented Nov 5, 2018 •

edited

Loading

elasticmachine commented Nov 5, 2018

elasticmachine commented Nov 5, 2018

elasticmachine commented Nov 8, 2018

elasticmachine commented Nov 8, 2018

elasticmachine commented Nov 9, 2018

elasticmachine commented Nov 10, 2018

elasticmachine commented Nov 14, 2018

elasticmachine commented Nov 14, 2018

joshdover commented Nov 15, 2018

elasticmachine commented Dec 14, 2018

elasticmachine commented Dec 17, 2018

elasticmachine commented Dec 17, 2018

tylersmalley Dec 18, 2018

tylersmalley commented Dec 18, 2018

joshdover commented Dec 18, 2018

tylersmalley left a comment

tylersmalley commented Dec 18, 2018

elasticmachine commented Dec 18, 2018

tylersmalley Dec 18, 2018

elasticmachine commented Dec 18, 2018

elasticmachine commented Dec 18, 2018

joshdover commented Dec 19, 2018

Upgrade assistant - Phase 1 #25168

Upgrade assistant - Phase 1 #25168

Conversation

joshdover commented Nov 5, 2018 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Nov 5, 2018

elasticmachine commented Nov 5, 2018

💚 Build Succeeded

elasticmachine commented Nov 8, 2018

💔 Build Failed

elasticmachine commented Nov 8, 2018

💔 Build Failed

elasticmachine commented Nov 9, 2018

💔 Build Failed

elasticmachine commented Nov 10, 2018

💔 Build Failed

elasticmachine commented Nov 14, 2018

💔 Build Failed

elasticmachine commented Nov 14, 2018

💚 Build Succeeded

joshdover commented Nov 15, 2018

elasticmachine commented Dec 14, 2018

💚 Build Succeeded

elasticmachine commented Dec 17, 2018

💚 Build Succeeded

elasticmachine commented Dec 17, 2018

💚 Build Succeeded

tylersmalley Dec 18, 2018

Choose a reason for hiding this comment

tylersmalley commented Dec 18, 2018

joshdover commented Dec 18, 2018

tylersmalley left a comment

Choose a reason for hiding this comment

tylersmalley commented Dec 18, 2018

elasticmachine commented Dec 18, 2018

💔 Build Failed

tylersmalley Dec 18, 2018

Choose a reason for hiding this comment

elasticmachine commented Dec 18, 2018

💚 Build Succeeded

elasticmachine commented Dec 18, 2018

💚 Build Succeeded

joshdover commented Dec 19, 2018

joshdover commented Nov 5, 2018 •

edited

Loading