Fix Painless script used by TSVB #25307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's at the moment unclear if this is a Painless regression (looks like), but this seems to fix it based on testing. I'm doing this change in the 6.5 branch, for a couple of reasons: I tested it in 6.5 only, because master didn't seem to exhibit this issue. And it is not the right fix, if Painless has a true regression. Closes elastic/beats#8957.
exekias
approved these changes
Nov 7, 2018
💚 Build Succeeded |
tsg
added a commit
to tsg/kibana
that referenced
this pull request
Dec 13, 2018
This is a loose forward-port of elastic#25307, which was rushed in for 6.5. I created this PR to make sure we don't lose the fix. Part of #elastic/beats#8957.
tsg
added a commit
that referenced
this pull request
Dec 15, 2018
This is a loose forward-port of #25307, which was rushed in for 6.5. I created this PR to make sure we don't lose the fix. Part of #elastic/beats#8957.
exekias
pushed a commit
to exekias/kibana
that referenced
this pull request
Jan 11, 2019
This is a loose forward-port of elastic#25307, which was rushed in for 6.5. I created this PR to make sure we don't lose the fix. Part of #elastic/beats#8957.
exekias
pushed a commit
to exekias/kibana
that referenced
this pull request
Jan 11, 2019
This is a loose forward-port of elastic#25307, which was rushed in for 6.5. I created this PR to make sure we don't lose the fix. Part of #elastic/beats#8957.
exekias
added a commit
that referenced
this pull request
Jan 11, 2019
This is a loose forward-port of #25307, which was rushed in for 6.5. I created this PR to make sure we don't lose the fix. Part of #elastic/beats#8957.
exekias
added a commit
that referenced
this pull request
Jan 11, 2019
This is a loose forward-port of #25307, which was rushed in for 6.5. I created this PR to make sure we don't lose the fix. Part of #elastic/beats#8957.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's at the moment unclear if this is a Painless regression (looks like),
but this seems to fix it based on testing.
I'm doing this change in the 6.5 branch, for a couple of reasons: I tested
it in 6.5 only, because master didn't seem to exhibit this issue. And it is
not the right fix, if Painless has a true regression.
Closes elastic/beats#8957.
Removed checklist because none applies.