Feature/translate monitoring server(part_2) #25402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
second merge
|
Pinging @elastic/kibana-monitoring |
💔 Build Failed |
💔 Build Failed |
chrisronline
approved these changes
Nov 13, 2018
| const instanceMemoryTitle = i18n.translate('xpack.monitoring.metrics.apmInstance.memoryTitle', { | ||
| defaultMessage: 'Memory' | ||
| }); | ||
| const transformationsTitle = i18n.translate('xpack.monitoring.metrics.apm.transformationsTitle', { |
There was a problem hiding this comment.
Should this be apmInstance.transformationsTitle?
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Nov 23, 2018
* Translate monitoring -> server -> metrics * Add monitooring path to i18nrx.json file * Fix issues * Remove eslint rule disabling
maryia-lapata
added a commit
that referenced
this pull request
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate monitoring -> server -> metrics folder
Part_1 : #25195
Fixes: #24713