Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show drop partial buckets option #25520

Merged
merged 3 commits into from
Nov 23, 2018
Merged

show drop partial buckets option #25520

merged 3 commits into from
Nov 23, 2018

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Nov 12, 2018 •
edited
Loading

Summary

Check for showing 'show partial buckets' option was broken, this fixes it.

resolves #25521

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@ppisljar ppisljar added review v7.0.0 v6.5.0 v6.6.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 12, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@ppisljar ppisljar mentioned this pull request Nov 12, 2018
Merged
markov00
markov00 reviewed Nov 12, 2018
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested locally on chrome/OSX.
Can you add a simple functional test for this option?

markov00
markov00 reviewed Nov 12, 2018
View reviewed changes
test/functional/apps/visualize/_vertical_bar_chart.js Outdated

const expectedChartValues = [37, 202, 740, 1437, 1371, 751, 188, 31, 42, 202, 683,
1361, 1415, 707, 177, 27, 32, 175, 707, 1408, 1355, 726, 201, 29
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to change this test as the following:

  • create a bar chart with a different timestamp than the standard one (one that contains partial buckets)
  • test the expected values before applying the drop partial bucket option
  • apply the drop partial bucket option
  • test and expect a smaller amount of values as expected data.

So we can test either the partial bucket option checkbox and the functionality

@elasticmachine
Copy link
Contributor

💔 Build Failed

@ppisljar ppisljar force-pushed the fix/dropPartialBuckets branch from b9c6c1e to 0e0d39f Compare November 12, 2018 12:21
@elasticmachine
Copy link
Contributor

💔 Build Failed

@LeeDr LeeDr added v6.5.1 and removed v6.5.0 labels Nov 12, 2018
@ppisljar
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@markov00
Copy link
Member

seems a legit fail:

    └- ✖ fail: "visualize app vertical bar chart should have `drop partial buckets` option"
19:02:10            │      retry.try timeout: Error: expected [ 82,
19:02:10            │   218,
19:02:10            │   341,
19:02:10            │   440,
19:02:10            │   480,
19:02:10            │   517,
19:02:10            │   522,
19:02:10            │   446,
19:02:10            │   403,
19:02:10            │   321,
19:02:10            │   258,
19:02:10            │   172,
19:02:10            │   95,
19:02:10            │   55,
19:02:10            │   38,
19:02:10            │   24,
19:02:10            │   3,
19:02:10            │   4,
19:02:10            │   11,
19:02:10            │   14,
19:02:10            │   17,
19:02:10            │   38,
19:02:10            │   49,
19:02:10            │   115,
19:02:10            │   152,
19:02:10            │   216,
19:02:10            │   315,
19:02:10            │   402,
19:02:11            │   446,
19:02:11            │   513,
19:02:11            │   520,
19:02:11            │   474,
19:02:11            │   421,
19:02:11            │   307,
19:02:11            │   230,
19:02:11            │   170,
19:02:11            │   99,
19:02:11            │   48,
19:02:11            │   30,
19:02:11            │   15,
19:02:11            │   10,
19:02:11            │   2,
19:02:11            │   8,
19:02:11            │   7,
19:02:11            │   17,
19:02:11            │   34,
19:02:11            │   37,
19:02:11            │   104,
19:02:11            │   153,
19:02:11            │   241,
19:02:11            │   313,
19:02:11            │   404,
19:02:11            │   492,
19:02:11            │   512,
19:02:11            │   503,
19:02:11            │   473,
19:02:11            │   379,
19:02:11            │   293,
19:02:11            │   277,
19:02:11            │   156,
19:02:11            │   56 ] to sort of equal [ 12,
19:02:11            │   119,
19:02:11            │   181,
19:02:11            │   218,
19:02:11            │   341,
19:02:11            │   440,
19:02:11            │   480,
19:02:11            │   517,
19:02:11            │   522,
19:02:11            │   446,
19:02:11            │   403,
19:02:11            │   321,
19:02:11            │   258,
19:02:11            │   172,
19:02:11            │   95,
19:02:11            │   55,
19:02:11            │   38,
19:02:11            │   24,
19:02:11            │   3,
19:02:11            │   4,
19:02:11            │   11,
19:02:11            │   14,
19:02:11            │   17,
19:02:11            │   38,
19:02:11            │   49,
19:02:11            │   115,
19:02:11            │   152,
19:02:11            │   216,
19:02:11            │   315,
19:02:11            │   402,
19:02:11            │   446,
19:02:11            │   513,
19:02:11            │   520,
19:02:11            │   474,
19:02:11            │   421,
19:02:11            │   307,
19:02:11            │   230,
19:02:11            │   170,
19:02:11            │   99,
19:02:11            │   48,
19:02:11            │   30,
19:02:11            │   15,
19:02:11            │   10,
19:02:11            │   2,
19:02:11            │   8,
19:02:11            │   7,
19:02:11            │   17,
19:02:11            │   34,
19:02:11            │   37,
19:02:11            │   104,
19:02:11            │   153,
19:02:11            │   241,
19:02:11            │   313,
19:02:11            │   404,
19:02:11            │   492,
19:02:11            │   512,
19:02:11            │   503,
19:02:11            │   473,
19:02:11            │   379,
19:02:11            │   293,
19:02:11            │   157 ]

@spalger spalger added v6.5.1 and removed v6.5.1 labels Nov 14, 2018
@spalger spalger added v6.5.2 and removed v6.5.1 labels Nov 22, 2018
@ppisljar ppisljar force-pushed the fix/dropPartialBuckets branch from 0e0d39f to 3df64bd Compare November 23, 2018 09:31
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ppisljar ppisljar merged commit b0a107f into elastic:master Nov 23, 2018
@ppisljar ppisljar mentioned this pull request Nov 23, 2018
Merged
ppisljar added a commit to ppisljar/kibana that referenced this pull request Nov 23, 2018
@ppisljar
show drop partial buckets option (elastic#25520)
7d6fb9d
@ppisljar ppisljar deleted the fix/dropPartialBuckets branch November 23, 2018 10:43
ppisljar added a commit that referenced this pull request Nov 26, 2018
@ppisljar
show drop partial buckets option (#25520) (#26116)
c4fd5d3
@timroes timroes mentioned this pull request Dec 7, 2018
Merged
timroes pushed a commit to timroes/kibana that referenced this pull request Dec 7, 2018
@ppisljar @timroes
show drop partial buckets option (elastic#25520)
007ecd2
@timroes timroes added v6.5.4 and removed v6.5.2 labels Dec 7, 2018
timroes added a commit that referenced this pull request Dec 12, 2018
@timroes
show drop partial buckets option (#25520) (#26798)
1052c53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 left review comments

@timroes timroes Awaiting requested review from timroes

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

Assignees
No one assigned
Labels
review Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.5.4 v6.6.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show partial buckets option is gone
6 participants
@ppisljar @elasticmachine @markov00 @timroes @spalger @LeeDr