Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate Machine Learning datavisualizer #25527

Merged

Conversation

tibmt
Copy link
Contributor

@tibmt tibmt commented Nov 12, 2018

translate Machine Learning datavisualizer

#25454

Guidline
Readme

@tibmt tibmt self-assigned this Nov 12, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update ids according to namespace xpack.ml. and use concatenation instead of eslint rule disabling.

.i18nrc.json Outdated Show resolved Hide resolved
@tibmt tibmt added the v6.6.0 label Nov 13, 2018
@tibmt tibmt mentioned this pull request Nov 13, 2018
60 tasks
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor

Nox911 commented Dec 19, 2018

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit 1603335 into elastic:master Dec 20, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Dec 21, 2018
* translate Machine Learning datavisualizer

* change some ids, change some structures and dont translate unnesesary scripts

* update i18nrc.json

* update datavisualizer_selector.js - remove eslint-disable

* add html_ prefix to values containing html

* use i18n angular service.

translate missed labels

* Fix syntax in i18n-values

* Replace FormatedMessage to intl.formatMessage for  betaBadgeLabel

* Fix issue
maryia-lapata added a commit that referenced this pull request Dec 21, 2018
* translate Machine Learning datavisualizer

* change some ids, change some structures and dont translate unnesesary scripts

* update i18nrc.json

* update datavisualizer_selector.js - remove eslint-disable

* add html_ prefix to values containing html

* use i18n angular service.

translate missed labels

* Fix syntax in i18n-values

* Replace FormatedMessage to intl.formatMessage for  betaBadgeLabel

* Fix issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants