add timestamp to inspector request stats #25667
Conversation
nreese
added
v7.0.0
Feature:Inspector
💔 Build Failed |
💚 Build Succeeded |
| @@ -43,6 +43,13 @@ export class RequestResponder { | |||
| ...(this.request.stats || {}), | |||
| ...stats, | |||
| }; | |||
| if (this.request.startTime) { | |||
There was a problem hiding this comment.
We will always set startTime and it's a mandatory field on the interface, so no need for the if here.
| @@ -43,6 +43,13 @@ export class RequestResponder { | |||
| ...(this.request.stats || {}), | |||
| ...stats, | |||
| }; | |||
| if (this.request.startTime) { | |||
| const startDate = new Date(this.request.startTime); | |||
| this.request.stats['Request timestamp'] = { | |||
There was a problem hiding this comment.
Since most of the vis parts already have been internationalized, you should use internationalization here directly:
import { i18n } from '@kbn/i18n';
const timestampKey = i18n.translate('common.ui.inspector.reqTimestampKey', {
defaultMessage: 'Request timestamp'
});
this.request.stats[timestampKey] = {
value: startDate.toISOString(),
description: i18n.translate('common.ui.inspector.reqTimestampDescription', {
defaultMessage: 'Request start timestamp'
})
}| const startDate = new Date(this.request.startTime); | ||
| this.request.stats['Request timestamp'] = { | ||
| value: startDate.toISOString(), | ||
| description: 'Request start timestamp', |
There was a problem hiding this comment.
I would also suggest making this description slightly more detailed. Something like:
Time when the start of the request has been logged.
Since we put this in the generic adapter I find it a bit hard what to put in here. Since we don't actually know if that's the start of the actual request e.g. in courier it's not, because it might wait a bit in the queue after the request has been logged before the request actually started. So we don't know much more than that's the time when the request has started been logging.
💚 Build Succeeded |
|
@timroes I made the requested changes. Mind taking another look? |
* add timestamp to inspector request stats * remove if wrapper, internationalize
Add
Request timestampto request inspector statsThe Kibana GIS app is using the inspector request stats to verify functional tests. Comparing timestamps provides a way for functional tests to ensure a new request has been made.