Remove version and snapshots from readme #25747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So long as we are referencing the version of Kibana in our readme, we cannot reliably automate the bumping of the Kibana version as part of our release process. None of the other repos in the stack include version information or links to snapshots in the readme. If folks want to know what version they're looking at, the package.json is the source of truth.
epixa
added
chore
non-issue
jbudz
approved these changes
Nov 15, 2018
spalger
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
LGTM, for people who are interested these snapshots are still going to be created and accessible via completed https://kibana-ci.elastic.co/job/elastic+kibana+master/ jobs.
|
Just for clarification: They will also still be available as part of the nightly snapshots through the release manager, which is what these linked to. Since that requires a successful build of ALL products, it's possible some days are missed. If you absolutely need the most up-to-date snapshot then use the ones created from the Kibana CI job Spencer linked to. |
💚 Build Succeeded |
epixa
added a commit
that referenced
this pull request
Nov 15, 2018
So long as we are referencing the version of Kibana in our readme, we cannot reliably automate the bumping of the Kibana version as part of our release process. None of the other repos in the stack include version information or links to snapshots in the readme. If folks want to know what version they're looking at, the package.json is the source of truth.
epixa
added a commit
that referenced
this pull request
Nov 15, 2018
So long as we are referencing the version of Kibana in our readme, we cannot reliably automate the bumping of the Kibana version as part of our release process. None of the other repos in the stack include version information or links to snapshots in the readme. If folks want to know what version they're looking at, the package.json is the source of truth.
epixa
added a commit
that referenced
this pull request
Nov 15, 2018
So long as we are referencing the version of Kibana in our readme, we cannot reliably automate the bumping of the Kibana version as part of our release process. None of the other repos in the stack include version information or links to snapshots in the readme. If folks want to know what version they're looking at, the package.json is the source of truth.
epixa
added a commit
that referenced
this pull request
Nov 15, 2018
So long as we are referencing the version of Kibana in our readme, we cannot reliably automate the bumping of the Kibana version as part of our release process. None of the other repos in the stack include version information or links to snapshots in the readme. If folks want to know what version they're looking at, the package.json is the source of truth.
epixa
added a commit
that referenced
this pull request
Nov 15, 2018
So long as we are referencing the version of Kibana in our readme, we cannot reliably automate the bumping of the Kibana version as part of our release process. None of the other repos in the stack include version information or links to snapshots in the readme. If folks want to know what version they're looking at, the package.json is the source of truth.
epixa
added a commit
that referenced
this pull request
Nov 15, 2018
So long as we are referencing the version of Kibana in our readme, we cannot reliably automate the bumping of the Kibana version as part of our release process. None of the other repos in the stack include version information or links to snapshots in the readme. If folks want to know what version they're looking at, the package.json is the source of truth.
epixa
added a commit
that referenced
this pull request
Nov 15, 2018
So long as we are referencing the version of Kibana in our readme, we cannot reliably automate the bumping of the Kibana version as part of our release process. None of the other repos in the stack include version information or links to snapshots in the readme. If folks want to know what version they're looking at, the package.json is the source of truth.
epixa
added a commit
that referenced
this pull request
Nov 15, 2018
So long as we are referencing the version of Kibana in our readme, we cannot reliably automate the bumping of the Kibana version as part of our release process. None of the other repos in the stack include version information or links to snapshots in the readme. If folks want to know what version they're looking at, the package.json is the source of truth.
|
heya @epixa I think you also need to remove the link to the removed "Snapshot Builds" section from up above in the README file. |
epixa
added a commit
to epixa/kibana
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in elastic#25747, so there should be no link to them.
|
@javanna Good catch! I've fixed it |
epixa
added a commit
to epixa/kibana
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in elastic#25747, so there should be no link to them.
epixa
added a commit
to epixa/kibana
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in elastic#25747, so there should be no link to them.
epixa
added a commit
to epixa/kibana
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in elastic#25747, so there should be no link to them.
epixa
added a commit
to epixa/kibana
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in elastic#25747, so there should be no link to them.
epixa
added a commit
to epixa/kibana
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in elastic#25747, so there should be no link to them.
epixa
added a commit
to epixa/kibana
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in elastic#25747, so there should be no link to them.
epixa
added a commit
to epixa/kibana
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in elastic#25747, so there should be no link to them.
epixa
added a commit
to epixa/kibana
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in elastic#25747, so there should be no link to them.
epixa
added a commit
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in #25747, so there should be no link to them.
epixa
added a commit
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in #25747, so there should be no link to them.
epixa
added a commit
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in #25747, so there should be no link to them.
epixa
added a commit
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in #25747, so there should be no link to them.
epixa
added a commit
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in #25747, so there should be no link to them.
epixa
added a commit
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in #25747, so there should be no link to them.
epixa
added a commit
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in #25747, so there should be no link to them.
epixa
added a commit
that referenced
this pull request
Nov 25, 2018
The snapshot builds were removed from the readme in #25747, so there should be no link to them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So long as we are referencing the version of Kibana in our readme, we
cannot reliably automate the bumping of the Kibana version as part of
our release process.
None of the other repos in the stack include version information or
links to snapshots in the readme. If folks want to know what version
they're looking at, the package.json is the source of truth.