Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixes fill of minor markers in Single Metric Viewer #25816

Merged
merged 1 commit into from
Nov 17, 2018
Merged

[ML] Fixes fill of minor markers in Single Metric Viewer #25816

merged 1 commit into from
Nov 17, 2018

Conversation

peteharverson
Copy link
Contributor

Fixes the fill style of minor severity anomaly markers by correcting a regression from the less to sass conversion in #25574.

Before:
markers_before

After:
markers_after

@peteharverson peteharverson added review non-issue Indicates to automation that a pull request should not appear in the release notes v7.0.0 :ml Feature:ml-results legacy - do not use v6.6.0 labels Nov 16, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

walterra
walterra approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit 85a6ec5 into elastic:master Nov 17, 2018
@peteharverson peteharverson deleted the ml-single-metric-minor-marker branch November 17, 2018 10:21
@peteharverson peteharverson mentioned this pull request Nov 17, 2018
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Nov 17, 2018
@peteharverson
[ML] Fixes fill of minor markers in Single Metric Viewer (elastic#25816)
8ff587c
peteharverson added a commit that referenced this pull request Nov 17, 2018
@peteharverson
[ML] Fixes fill of minor markers in Single Metric Viewer (#25816) (#2…
7cfb3e3 
…5845)
@sophiec20 sophiec20 added the Feature:Anomaly Detection ML anomaly detection label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra walterra approved these changes

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection Feature:ml-results legacy - do not use :ml non-issue Indicates to automation that a pull request should not appear in the release notes review v6.6.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peteharverson @elasticmachine @walterra @alvarezmelissa87 @sophiec20