Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/pm] Implement --prefer-offline flag #25840

Merged
merged 4 commits into from
Nov 19, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Nov 17, 2018

This updates @kbn/pm to accept a --prefer-offline flag that will try to install modules without going to the network, and sets the yarn-offline-mirror config variable to instruct yarn to build an offline cache that is slightly more efficient/safe than copying from the extracted files in the cache.

@spalger spalger added WIP Work in progress review Team:Operations Team label for Operations Team v7.0.0 v6.6.0 and removed WIP Work in progress labels Nov 17, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@spalger spalger requested a review from tylersmalley November 17, 2018 01:03
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jbudz jbudz mentioned this pull request Nov 19, 2018
@spalger
Copy link
Contributor Author

spalger commented Nov 19, 2018

retest

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit 992daf5 into elastic:master Nov 19, 2018
spalger pushed a commit to spalger/kibana that referenced this pull request Nov 19, 2018
* [kbn/pm/bootstrap] add support for --prefer-offline

* [ci] try to use offline cache of modules

* [yarn] set yarn-offline-mirror directory
spalger pushed a commit that referenced this pull request Nov 20, 2018
Backports the following commits to 6.x:
 - [kbn/pm] Implement --prefer-offline flag  (#25840)
@spalger
Copy link
Contributor Author

spalger commented Nov 20, 2018

6.x/6.6: 2bb70a9

@spalger spalger deleted the implement/prefer-offline branch November 20, 2018 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Operations Team label for Operations Team v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants