-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kbn/pm] Implement --prefer-offline flag #25840
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
WIP
Work in progress
review
Team:Operations
Team label for Operations Team
v7.0.0
v6.6.0
and removed
WIP
Work in progress
labels
Nov 17, 2018
Pinging @elastic/kibana-operations |
💔 Build Failed |
💚 Build Succeeded |
retest |
tylersmalley
approved these changes
Nov 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 19, 2018
* [kbn/pm/bootstrap] add support for --prefer-offline * [ci] try to use offline cache of modules * [yarn] set yarn-offline-mirror directory
spalger
pushed a commit
that referenced
this pull request
Nov 20, 2018
6.x/6.6: 2bb70a9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
@kbn/pm
to accept a--prefer-offline
flag that will try to install modules without going to the network, and sets theyarn-offline-mirror
config variable to instruct yarn to build an offline cache that is slightly more efficient/safe than copying from the extracted files in the cache.