-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move optimize into data folder #25944
Conversation
Pinging @elastic/kibana-operations |
Do we have any public documentation mentioning the previous location? |
@jbudz I have to little questions. Should we also update |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💔 Build Failed |
💚 Build Succeeded |
💔 Build Failed |
💚 Build Succeeded |
nit: can remove |
💚 Build Succeeded |
💚 Build Succeeded |
Getting this ready again - I wanted to wait to avoid workflow interruptions when switching between 8.x and 7.x but at the same time don't want to wait too long :) |
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
We can either remove the legacy optimize directory from gitignore, or we can add to eslintignore. We have chosen to go with the latter to prevent accidental commits of the optimize directory and aide in a smoother transition between old branches. This change was made in elastic#25944 and only effects master/8.0, which increases the likelihood a developer runs into it. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
We can either remove the legacy optimize directory from gitignore, or we can add to eslintignore. We have chosen to go with the latter to prevent accidental commits of the optimize directory and aide in a smoother transition between old branches. This change was made in #25944 and only effects master/8.0, which increases the likelihood a developer runs into it. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
We have a general purpose data folder used for application writes, and there's some overlap with this and the optimize folder. We want all writes to go to the same folder so we can set this path to /var/lib/kibana for deb/rpm packages.
https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s08.html
Currently in the data folder we'll extract phantomjs, create a uuid, and store the keystore. This moves bundles and bundle caches there in addition
Closes #15899
Closes #5071