Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@kbn/interpreter] improve build/packaging #26096

Merged
merged 4 commits into from
Nov 23, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Nov 22, 2018

Summary of changes:

  • move all build artifacts under target directory
  • run babel and webpack in parallel
  • support optional watch and sourcemaps in build
  • expose /common /public /plugin /server sub-exports as index.js
  • avoid importing deeply from @kbn/interpreter
  • move a couple missed dependencies from x-pack to kibana
  • remove custom babel-register implementation

@spalger spalger force-pushed the fix/kbn-interpreter-build branch 2 times, most recently from dad892f to 6059fe1 Compare November 23, 2018 01:04
@elastic elastic deleted a comment from elasticmachine Nov 23, 2018
@spalger spalger force-pushed the fix/kbn-interpreter-build branch 3 times, most recently from 8e5e9da to 570b444 Compare November 23, 2018 01:52
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

 - move all build artifacts under `target` directory
 - run babel and webpack in parallel
 - support optional watch and sourcemaps in build
 - expose /common /public /plugin /server sub-exports as index.js
 - avoid importing deeply from `@kbn/interpreter`
 - add necessary dependencies to `@kbn/interpreter`
 - remove unnecessary dependencies from x-pack
@spalger spalger force-pushed the fix/kbn-interpreter-build branch from 570b444 to e8cb356 Compare November 23, 2018 05:39
@spalger spalger requested a review from ppisljar November 23, 2018 05:40
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger requested a review from mistic November 23, 2018 17:22
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you did here was superb, nice job @spalger! LGTM, I have ran it locally and everything looks fine.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit 54f1a73 into elastic:master Nov 23, 2018
spalger pushed a commit to spalger/kibana that referenced this pull request Nov 23, 2018
Summary of changes:

 - move all build artifacts under `target` directory
 - run babel and webpack in parallel
 - support optional watch and sourcemaps in build
 - expose /common /public /plugin /server sub-exports as index.js
 - avoid importing deeply from `@kbn/interpreter`
 - move a couple missed dependencies from x-pack to kibana
 - remove custom babel-register implementation
@spalger spalger removed the v6.5.2 label Nov 23, 2018
spalger pushed a commit that referenced this pull request Nov 24, 2018
* [@kbn/interpreter] improve build/packaging (#26096)

Summary of changes:

 - move all build artifacts under `target` directory
 - run babel and webpack in parallel
 - support optional watch and sourcemaps in build
 - expose /common /public /plugin /server sub-exports as index.js
 - avoid importing deeply from `@kbn/interpreter`
 - move a couple missed dependencies from x-pack to kibana
 - remove custom babel-register implementation

* fix bad conflict resolution
@spalger
Copy link
Contributor Author

spalger commented Nov 24, 2018

6.x/6.6: e618cf4

@spalger spalger deleted the fix/kbn-interpreter-build branch November 24, 2018 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants