-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@kbn/interpreter] improve build/packaging #26096
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
fix/kbn-interpreter-build
branch
2 times, most recently
from
November 23, 2018 01:04
dad892f
to
6059fe1
Compare
spalger
force-pushed
the
fix/kbn-interpreter-build
branch
3 times, most recently
from
November 23, 2018 01:52
8e5e9da
to
570b444
Compare
💚 Build Succeeded |
- move all build artifacts under `target` directory - run babel and webpack in parallel - support optional watch and sourcemaps in build - expose /common /public /plugin /server sub-exports as index.js - avoid importing deeply from `@kbn/interpreter` - add necessary dependencies to `@kbn/interpreter` - remove unnecessary dependencies from x-pack
spalger
force-pushed
the
fix/kbn-interpreter-build
branch
from
November 23, 2018 05:39
570b444
to
e8cb356
Compare
💚 Build Succeeded |
💚 Build Succeeded |
mistic
approved these changes
Nov 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you did here was superb, nice job @spalger! LGTM, I have ran it locally and everything looks fine.
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 23, 2018
Summary of changes: - move all build artifacts under `target` directory - run babel and webpack in parallel - support optional watch and sourcemaps in build - expose /common /public /plugin /server sub-exports as index.js - avoid importing deeply from `@kbn/interpreter` - move a couple missed dependencies from x-pack to kibana - remove custom babel-register implementation
spalger
pushed a commit
that referenced
this pull request
Nov 24, 2018
* [@kbn/interpreter] improve build/packaging (#26096) Summary of changes: - move all build artifacts under `target` directory - run babel and webpack in parallel - support optional watch and sourcemaps in build - expose /common /public /plugin /server sub-exports as index.js - avoid importing deeply from `@kbn/interpreter` - move a couple missed dependencies from x-pack to kibana - remove custom babel-register implementation * fix bad conflict resolution
6.x/6.6: e618cf4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
target
directory@kbn/interpreter