Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev/build] use more performant copy implementation #26109

Merged
merged 3 commits into from
Nov 23, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Nov 23, 2018

Was looking through the build for things that could be sped up, one thing that stood out is the Creating platform-specific archive source directories step. It currently takes about 2.5 minutes on CI and I figured it was something similar to the deep delete slowness we fixed with #24692, so I gave a custom implementation a shot and right away saw massive speed improvements. The current implementation copies the archive source per-platform in 6 seconds on CI 👍

00:10:39.912  info [kibana-oss] Creating platform-specific archive source directories
00:10:45.963    │ debg Generic build source copied into linux specific build directory
00:10:46.346    │ debg Node.js copied into linux specific build directory
00:10:46.346    │ succ ✓ 6 sec

@spalger spalger added WIP Work in progress Team:Operations Team label for Operations Team v7.0.0 v6.6.0 labels Nov 23, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@spalger spalger requested review from mistic and removed request for mistic November 23, 2018 06:02
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger requested a review from jbudz November 23, 2018 14:07
@spalger spalger added review and removed WIP Work in progress labels Nov 23, 2018
@spalger spalger requested a review from mistic November 23, 2018 14:08
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested this locally and it works quite well! I'm just wondering if we have more of those things spread out in other places across our build! We are also using the old copy_all into the copy_source_task and in the optimize_task

@spalger
Copy link
Contributor Author

spalger commented Nov 23, 2018

We could use this in more places, but I'm not trying to make a copy function that solves every need (though it might already solve more than I'm trying to fix). This is purely focused on performance.

@spalger spalger merged commit 18ae6a4 into elastic:master Nov 23, 2018
spalger pushed a commit to spalger/kibana that referenced this pull request Nov 23, 2018
* [dev/build] use more performant copy implementation

* [dev/build] cleanup coments, install task
spalger pushed a commit that referenced this pull request Nov 23, 2018
* [dev/build] use more performant copy implementation

* [dev/build] cleanup coments, install task
@spalger
Copy link
Contributor Author

spalger commented Nov 23, 2018

6.x: ac90d3b

@spalger spalger deleted the implement/build/faster-copy branch November 23, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Operations Team label for Operations Team v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants