-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev/build] use more performant copy implementation #26109
Conversation
Pinging @elastic/kibana-operations |
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I tested this locally and it works quite well! I'm just wondering if we have more of those things spread out in other places across our build! We are also using the old copy_all
into the copy_source_task
and in the optimize_task
We could use this in more places, but I'm not trying to make a copy function that solves every need (though it might already solve more than I'm trying to fix). This is purely focused on performance. |
* [dev/build] use more performant copy implementation * [dev/build] cleanup coments, install task
6.x: ac90d3b |
Was looking through the build for things that could be sped up, one thing that stood out is the
Creating platform-specific archive source directories
step. It currently takes about 2.5 minutes on CI and I figured it was something similar to the deep delete slowness we fixed with #24692, so I gave a custom implementation a shot and right away saw massive speed improvements. The current implementation copies the archive source per-platform in 6 seconds on CI 👍