Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quotes in kbn-i18n build scripts #26120

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

LeanidShutau
Copy link
Contributor

@LeanidShutau LeanidShutau commented Nov 23, 2018

Bug
packages/kbn-i18n/package.json:

...
scripts: {
  "kbn:bootstrap": "run-p 'build:babel:** --quiet' build:tsc",
  "kbn:watch": "run-p 'build:** --watch'",
},
...

These commands throw errors on Windows because of wrong command line arguments parsing ('build:babel:**, --quiet' and build:tsc):

@kbn/i18n: $ run-p 'build:babel:** --quiet' build:tsc
× @kbn/i18n: ERROR: Invalid Option: --quiet'

So yarn kbn bootstrap fails on Windows

Fix
Use cross-platform escaped double quotes instead of single quotes:

...
scripts: {
  "kbn:bootstrap": "run-p \"build:babel:** --quiet\" build:tsc",
  "kbn:watch": "run-p \"build:** --watch\"",
},
...

@LeanidShutau LeanidShutau added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Project:i18n v6.6.0 labels Nov 23, 2018
@LeanidShutau LeanidShutau requested a review from spalger November 23, 2018 13:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@LeanidShutau LeanidShutau self-assigned this Nov 23, 2018
@LeanidShutau LeanidShutau added v6.5.2 Team:Operations Team label for Operations Team and removed Project:i18n labels Nov 23, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@LeanidShutau LeanidShutau removed the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Nov 23, 2018
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeanidShutau LeanidShutau assigned spalger and unassigned LeanidShutau Nov 23, 2018
@spalger spalger merged commit 56e27e6 into elastic:master Nov 23, 2018
@spalger spalger added the v7.0.0 label Nov 23, 2018
spalger pushed a commit to spalger/kibana that referenced this pull request Nov 23, 2018
**Bug**
`packages/kbn-i18n/package.json`:
```
...
scripts: {
  "kbn:bootstrap": "run-p 'build:babel:** --quiet' build:tsc",
  "kbn:watch": "run-p 'build:** --watch'",
},
...
```
These commands throw errors on Windows because of wrong command line arguments parsing (`'build:babel:**`, `--quiet'` and `build:tsc`):
```
@kbn/i18n: $ run-p 'build:babel:** --quiet' build:tsc
× @kbn/i18n: ERROR: Invalid Option: --quiet'
```
So `yarn kbn bootstrap` fails on Windows

**Fix**
Use cross-platform escaped double quotes instead of single quotes:
```
...
scripts: {
  "kbn:bootstrap": "run-p \"build:babel:** --quiet\" build:tsc",
  "kbn:watch": "run-p \"build:** --watch\"",
},
...
```
spalger pushed a commit to spalger/kibana that referenced this pull request Nov 23, 2018
**Bug**
`packages/kbn-i18n/package.json`:
```
...
scripts: {
  "kbn:bootstrap": "run-p 'build:babel:** --quiet' build:tsc",
  "kbn:watch": "run-p 'build:** --watch'",
},
...
```
These commands throw errors on Windows because of wrong command line arguments parsing (`'build:babel:**`, `--quiet'` and `build:tsc`):
```
@kbn/i18n: $ run-p 'build:babel:** --quiet' build:tsc
× @kbn/i18n: ERROR: Invalid Option: --quiet'
```
So `yarn kbn bootstrap` fails on Windows

**Fix**
Use cross-platform escaped double quotes instead of single quotes:
```
...
scripts: {
  "kbn:bootstrap": "run-p \"build:babel:** --quiet\" build:tsc",
  "kbn:watch": "run-p \"build:** --watch\"",
},
...
```
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

spalger pushed a commit that referenced this pull request Nov 23, 2018
**Bug**
`packages/kbn-i18n/package.json`:
```
...
scripts: {
  "kbn:bootstrap": "run-p 'build:babel:** --quiet' build:tsc",
  "kbn:watch": "run-p 'build:** --watch'",
},
...
```
These commands throw errors on Windows because of wrong command line arguments parsing (`'build:babel:**`, `--quiet'` and `build:tsc`):
```
@kbn/i18n: $ run-p 'build:babel:** --quiet' build:tsc
× @kbn/i18n: ERROR: Invalid Option: --quiet'
```
So `yarn kbn bootstrap` fails on Windows

**Fix**
Use cross-platform escaped double quotes instead of single quotes:
```
...
scripts: {
  "kbn:bootstrap": "run-p \"build:babel:** --quiet\" build:tsc",
  "kbn:watch": "run-p \"build:** --watch\"",
},
...
```
spalger pushed a commit that referenced this pull request Nov 23, 2018
Backports the following commits to 6.x:
 - Fix quotes in kbn-i18n build scripts  (#26120)
@spalger
Copy link
Contributor

spalger commented Nov 23, 2018

6.x/6.6: a6367e3
6.5: 227e836

@LeanidShutau LeanidShutau deleted the fix/i18n-package-json-scripts branch November 26, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Operations Team label for Operations Team v6.5.2 v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants