-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quotes in kbn-i18n build scripts #26120
Merged
spalger
merged 1 commit into
elastic:master
from
LeanidShutau:fix/i18n-package-json-scripts
Nov 23, 2018
Merged
Fix quotes in kbn-i18n build scripts #26120
spalger
merged 1 commit into
elastic:master
from
LeanidShutau:fix/i18n-package-json-scripts
Nov 23, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeanidShutau
added
bug
Fixes for quality problems that affect the customer experience
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Project:i18n
v6.6.0
labels
Nov 23, 2018
Pinging @elastic/kibana-platform |
LeanidShutau
added
v6.5.2
Team:Operations
Team label for Operations Team
and removed
Project:i18n
labels
Nov 23, 2018
Pinging @elastic/kibana-operations |
LeanidShutau
removed
the
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
label
Nov 23, 2018
spalger
approved these changes
Nov 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 23, 2018
**Bug** `packages/kbn-i18n/package.json`: ``` ... scripts: { "kbn:bootstrap": "run-p 'build:babel:** --quiet' build:tsc", "kbn:watch": "run-p 'build:** --watch'", }, ... ``` These commands throw errors on Windows because of wrong command line arguments parsing (`'build:babel:**`, `--quiet'` and `build:tsc`): ``` @kbn/i18n: $ run-p 'build:babel:** --quiet' build:tsc × @kbn/i18n: ERROR: Invalid Option: --quiet' ``` So `yarn kbn bootstrap` fails on Windows **Fix** Use cross-platform escaped double quotes instead of single quotes: ``` ... scripts: { "kbn:bootstrap": "run-p \"build:babel:** --quiet\" build:tsc", "kbn:watch": "run-p \"build:** --watch\"", }, ... ```
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 23, 2018
**Bug** `packages/kbn-i18n/package.json`: ``` ... scripts: { "kbn:bootstrap": "run-p 'build:babel:** --quiet' build:tsc", "kbn:watch": "run-p 'build:** --watch'", }, ... ``` These commands throw errors on Windows because of wrong command line arguments parsing (`'build:babel:**`, `--quiet'` and `build:tsc`): ``` @kbn/i18n: $ run-p 'build:babel:** --quiet' build:tsc × @kbn/i18n: ERROR: Invalid Option: --quiet' ``` So `yarn kbn bootstrap` fails on Windows **Fix** Use cross-platform escaped double quotes instead of single quotes: ``` ... scripts: { "kbn:bootstrap": "run-p \"build:babel:** --quiet\" build:tsc", "kbn:watch": "run-p \"build:** --watch\"", }, ... ```
💚 Build Succeeded |
spalger
pushed a commit
that referenced
this pull request
Nov 23, 2018
**Bug** `packages/kbn-i18n/package.json`: ``` ... scripts: { "kbn:bootstrap": "run-p 'build:babel:** --quiet' build:tsc", "kbn:watch": "run-p 'build:** --watch'", }, ... ``` These commands throw errors on Windows because of wrong command line arguments parsing (`'build:babel:**`, `--quiet'` and `build:tsc`): ``` @kbn/i18n: $ run-p 'build:babel:** --quiet' build:tsc × @kbn/i18n: ERROR: Invalid Option: --quiet' ``` So `yarn kbn bootstrap` fails on Windows **Fix** Use cross-platform escaped double quotes instead of single quotes: ``` ... scripts: { "kbn:bootstrap": "run-p \"build:babel:** --quiet\" build:tsc", "kbn:watch": "run-p \"build:** --watch\"", }, ... ```
spalger
pushed a commit
that referenced
this pull request
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Team:Operations
Team label for Operations Team
v6.5.2
v6.6.0
v7.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
packages/kbn-i18n/package.json
:These commands throw errors on Windows because of wrong command line arguments parsing (
'build:babel:**
,--quiet'
andbuild:tsc
):So
yarn kbn bootstrap
fails on WindowsFix
Use cross-platform escaped double quotes instead of single quotes: