[ML] Implement k7 breadcrumbs for ML routes #26774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
v7.0.0
enhancement
|
Pinging @elastic/ml-ui |
peteharverson
requested review from
walterra,
spalger,
alvarezmelissa87 and
jgowdyelastic
spalger
approved these changes
Dec 6, 2018
There was a problem hiding this comment.
LGTM, thanks @peteharverson! Would like to hear from @cchaos before merging this
💚 Build Succeeded |
snide
reviewed
Dec 6, 2018
There was a problem hiding this comment.
With any "create" taxonomy we've attempted to avoid repeating the noun when it's already included in the crumb. I'd change things like ML / Filter lists / Create filter list with ML / Filter lists / Create.
The Create job pattern is the exception (which is fine) because you're using the ML front door as the "jobs" page and don't have it in the crumb.
Know it's a minor detail, but it's the pattern we've attempted with every other app. Thanks for doing this work!
|
@snide I've made edits to some of the Settings and Jobs breadcrumbs to remove repeating nouns as you suggested e.g.
Please could you take another look! |
💚 Build Succeeded |
💔 Build Failed |
chrisronline
pushed a commit
that referenced
this pull request
Dec 12, 2018
* [ML] Implement k7 breadcrumbs for ML routes * [ML] Remove duplicate nouns from jobs and settings breadcrumbs
chrisronline
added a commit
that referenced
this pull request
Dec 13, 2018
* [Monitoring] Cluster alerts table to EUI (#26031) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * [Monitoring] Elasticsearch monitoring to EUI (#26217) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Update snapshots * Fix functional tests * Fix more tests * Remove commented out code * Update token API calls in elaticsearch.js (#26650) * make selection border 1px (#26739) * Reporting phantom and chromium tests should run in parallel. (#26566) * Reporting phantom and chromium tests should run in parallel. * Chromium tests should be done in group 9. * Attempting to use group 2 in ci for chromium tests. * X-pack CI jobs should have 7 groups. * Phantom tests should be in group 7. * [es-management/watcher] implement k7Breadcrumbs (#26719) * [timelion] implement k7Breadcrumbs (#26729) * [timelion] implement k7Breadcrumbs * [timelion] show "Create" breadcrumb by default * [es-management] implement k7Breadcrumbs (#26711) * [es-manaagement] implement k7Breadcrumbs * fix i18n ids * Fixes i18n issue in space nav selector (#26742) ## Summary Wraps the Spaces `NavControlPopover` in `<I18nProvider>`. Fixes #26736 * [Docs] Add beta flag to central management docs (#26558) * Feature/translate ml-jobs-jobs_list(part_1) (#25466) Translate ml -> jobsList(part_1) * Corrected wrong calls from .on to .off (#24575) Closing memory leak * Fix saved objects client _processBatchQueue function to handle errors (#26763) * Fix saved objects client _processBatchQueue function to handle errors * Fix error thrown in try/catch * chore(.gitignore): ignore sublime workspace files (#26516) * Map inspector requests by id so single requests can be reset at a time (#26770) * [ML] Implement k7 breadcrumbs for ML routes (#26774) * [ML] Implement k7 breadcrumbs for ML routes * [ML] Remove duplicate nouns from jobs and settings breadcrumbs * [Reporting] Re-enabled Chromium API tests (#26789) * [Reporting] Test logging * chromium api tests fixed * whitespace * Fix Elasticsearch typo on connection error screen (#26815) `Elastiscearch` -> `Elasticsearch`. * Reporting/reveal document bytes (#26667) * Adding a `size` property to all job-reporting meta-data and showing in reporting details pane * Enable heartbeat telemetry (#25886) This commit allows heartbeat telemetry data to be sent through kibana. The change to beats was introduced in elastic/beats#8621 * Change 'Disenroll' text to be consistent with menu option 'Unenroll'. (#26816) * Upgrading sshpk (#26834) sshpk is an implicit dependency of request@2.88.0 * Re-enable the chromium functional tests (#26822) * Logging when max-bytes is larger than what's set in ES (#26482) * Simple check if ES body-size is smaller than KBN report size * [BeatsCM] Cleanup and refactor (#26636) * Refactor BeatsCM * update deps * update more deps * update for new EUI definitions * update import * Revert "update deps" This reverts commit 759a145. * use _source_includes * remove _source_includes * work-around due to watcher UI tests * Keep all xpack checks safe because we cant trust its there in tests for some reason * VALIDATION. This commit is to ensure the errors in CI are coming from beats * remove validation that this is a beats CM issue * More try/catch to try and find where this error is * testing another call * revert back to dangerouslyGetActiveInjector * ensure expire always is a number * fix swallowed error * Update x-pack/plugins/beats_management/public/lib/compose/kibana.ts Co-Authored-By: mattapperson <me@mattapperson.com> * Update x-pack/plugins/beats_management/public/utils/page_loader.test.ts Co-Authored-By: mattapperson <me@mattapperson.com> * Update x-pack/plugins/beats_management/public/utils/page_loader.ts Co-Authored-By: mattapperson <me@mattapperson.com> * fix for new webpack import * Fix translation map * fix URL path * fix other link * removing tag from beats via tag details screen now uses container * remove debug text * added comment/readme about routing on the client side * enrolled beat UI now works on overview screen * newly enrolled beat now reloads the beats table * fix TS errors * [APM] Transaction group agg size config (#26683) * [APM] Fixes #24204 by adding default configs to kibana.yml * [APM] fixes #25940 by adding APM config to control top transation group agg size * Revert the default configs added to kibana.yml and define joi validations for `xpack.apm.ui.transactionGroupBucketSize` * fix broken test for incorrect config * [APM] add docs entry for `xpack.apm.ui.transactionGroupBucketSize` * [APM] fixes #26784 by updateing import from a default to a named import (#26785) * allow disabling gpu in tests (#26684) * skipping failing tests (#26877) * Feature/translate ml - jobs(part 2) (#25528) Translate ml -> jobs - jobs-list(part_2) * use canvas pipeline in visualize (#25996) * Upgrade to NodeJS 10 (#25157) * feat(NA): upgrade node js version on file configs. * chore(NA): migrate configs and 3rd party dependencies to work on node js 10.x * fix(NA): add missing async function declaration. * chore(NA): updated elastic/good package to work with node10 * chore(NA): update lockfiles. * fix(NA): add missing dep. * fix(NA): types for node 10. * test(NA): fix error return type for node10. * fix(NA): kbn-pm webpack config to unlazy a require using lazy-cache. fix(NA): build to work with node 10. * test(NA): jest integration test for kbn-pluin-helpers. * test(NA): fix jest tests for kbn-es. * fix(NA): use ostmpdir instead of a tmp folder inside the fixtures. * fix(NA): change afterEach on kbn es decompress test. * fix(NA): change afterEach on kbn es decompress test. * fix(NA): readd mock-fs for the tests that still use it on kbn-es and that works on node10. * fix(NA): readd mock-fs for the tests that still use it on kbn-es and that works on node10. * refact(NA): rewrite tests using mock-fs and completely remove this dependency. * fix(NA): failing test implementation using jest mock in order to replace mock-fs. * fix(NA): update jest snapshots to match new ones generated one node 10. * fix(NA): cli/cluster mock to spyOn off method instead off spyOn removeListener as this was changed on Node 10. * fix(NA): tests for cluster_manager to also spyOn off and on instead of addListener and removeListener * test(NA): fix management advance settings image field test flow. * fix(NA): apply missing types for src/core/server/plugins/discovery/plugins_discovery.ts. * test(NA): updated 2 missing snapshots for KuiCodeEditor on kbn-ui-framework. * refact(NA): fix eslint errors. * refact(NA): fix ts code with tslint fix. chore(NA): update jest snapshots. * chore(NA): migrate kbn config schema peer dependency to last used joi version to avoid warning on bootstrap. * fix(NA): tslint errors. * chore(NA): upgrade types node to the last version. * fix(NA): missing utf8 input format encoding when reading a file. * chore(NA): upgrade to node 10.14.1 * fix(NA): Buffer api usage to avoid deprecation warnings. * fixing a11y errors so we can add a11y rules for tslint (#26902) * [DOCS] Deprecate X-Pack-centric watcher endpoints (#26899) * Index lifecycle (#25553) * [WIP] Index lifecycle (#25071) * Index lifecycle management wizard * Adding index lifecycle management files * Updates * Fix errors and add flyout for node details * New diff tool * Scroll to change for review diff * Some feedback on copy * Updating copy, moving components around and fixing bugs with the diff view * Add logic to auto enable a phase when something is set * redesign ilm * Adding server api tests * Removing debug and some tweaks from dave's work * Conditionally show this message * Policy selection cleanup * Updates for better UX * [COPYEDIT | ILM] Copyedit of text in index lifecycle management UI * Use better default text * Remove debug * Adding readme and comments * Update readme * Do not need this anymore * Remove debug or commented out code * Remove these - they are in the tests PR * Toggle system indices * Aliases are not defined here anymore * Handle rollover better in warm phase and remove from cold,delete * adding learn more link component and switching over to using that * fixing UI issue when no policies exist * various fixes * some cleanup * moving number_of_replicas due to API change * modifying some messaging * fixing typo * fixing some diff issues and not adding sattr_name if none chosen * making write alias required for template step and making necessary API changes * removing alias definition from template patching as it needs to be per index * some copy edits for clarity * fixing issue with editing existing policy when rollover starts the warm phase * addressing PR feedback on server side code * addressing PR feedback * removing additional spaces from findMatchingNodes call * changing template to index template in one more place * fixing issue with error message showing when bootstrap is successful * fixing node options for warm and cold phase * adding seconds to duration fields to match what ES supports * changing icon for enabled steps so it does not look like an error indicator * adjusting icon color for enabled lifecycle steps * fixing issue with editing an existing policy with warm phase on rollover enabled * fixing issue with default unit for age dropdowns * fixing issues with shrink action serialization and deserialization * fixing issue with deserialization of ES policy for shrink * removing shrink option from UI when primary shard count is not greater than 1 for hot phase * going straight to create policy when no policies exist * improving lifecycle policy selection * adding active badge instead of checkmark for active lifecycle policy phases * some cleanup of unneeded properties and only showing save as new when it is appropriate * removing stray fullWidth attribute * adding missing minimum for replica count for warm phase * adding scroll to top for review step * fixing issue with start warm phase after rollover introduced by time representaiton change from ES * making shrink options not show for primary shard count of 1 as you can't shrink in that situation * fixing issue with editing existing policy and saveAsNew * bare bones policy table implementation * implementing delete policy behavior * fixing sorting and paging * fixing policy table title * rudimentary navigation flow * fixing delete * Index lifecycle management wizard (#21925) * Index lifecycle management wizard * Adding index lifecycle management files * Updates * Fix errors and add flyout for node details * New diff tool * Scroll to change for review diff * Some feedback on copy * Updating copy, moving components around and fixing bugs with the diff view * Add logic to auto enable a phase when something is set * redesign ilm * Adding server api tests * Removing debug and some tweaks from dave's work * Conditionally show this message * Policy selection cleanup * Updates for better UX * [COPYEDIT | ILM] Copyedit of text in index lifecycle management UI * Use better default text * Remove debug * Adding readme and comments * Update readme * Do not need this anymore * Remove debug or commented out code * Remove these - they are in the tests PR * Toggle system indices * Aliases are not defined here anymore * Handle rollover better in warm phase and remove from cold,delete * adding learn more link component and switching over to using that * fixing UI issue when no policies exist * various fixes * some cleanup * moving number_of_replicas due to API change * modifying some messaging * fixing typo * fixing some diff issues and not adding sattr_name if none chosen * making write alias required for template step and making necessary API changes * removing alias definition from template patching as it needs to be per index * some copy edits for clarity * fixing issue with editing existing policy when rollover starts the warm phase * addressing PR feedback on server side code * addressing PR feedback * removing additional spaces from findMatchingNodes call * changing template to index template in one more place * fixing issue with error message showing when bootstrap is successful * fixing node options for warm and cold phase * adding seconds to duration fields to match what ES supports * changing icon for enabled steps so it does not look like an error indicator * adjusting icon color for enabled lifecycle steps * fixing issue with editing an existing policy with warm phase on rollover enabled * fixing issue with default unit for age dropdowns * fixing issues with shrink action serialization and deserialization * fixing issue with deserialization of ES policy for shrink * removing shrink option from UI when primary shard count is not greater than 1 for hot phase * going straight to create policy when no policies exist * improving lifecycle policy selection * adding active badge instead of checkmark for active lifecycle policy phases * some cleanup of unneeded properties and only showing save as new when it is appropriate * removing stray fullWidth attribute * adding missing minimum for replica count for warm phase * adding scroll to top for review step * fixing issue with start warm phase after rollover introduced by time representaiton change from ES * making shrink options not show for primary shard count of 1 as you can't shrink in that situation * fixing issue with editing existing policy and saveAsNew * adjusting to changes in ES API * adding version and modified date to policies table * implementing new CRUD approach * simplified delete * cleanup edit_policy * removed wizard code * fixing issue with edit policy * fixing issue with closing delete confirmation modal * making max age and max size not mutually exclusive * removing names of covered indices from policy table * changing minimum_age to min_age * first pass at index lifecycle extensions * adding retry button for ilm covered index that is in error * first pass at index lifecycle banner * i18n work * more i18n * fixing issue with node attributes * removing console.log statements * fixing issue with deserializing number_of_shards for edit policy * defaulting shrink to false and fixing ui spacing issue * removing hot phase shard count from warm phase * scrolling to first error when user submits form for edit policy * disabling UI for index management when enabled is false in kibana.yml * disabling index lifecycle management when enabled is false in kibana.yml * extending index management filter to allow for searching fields * add support for filtering to indices with errors for index lifecycle management banner * i18n work * fixing error wrappers * fixing tests * adding view JSON for index lifecycle policy on edit screen * fixing label for i18n on policy JSON flyout * removing console.log statements * fixing tests * removing console.log statements * adding key for banner extensions * fixing bad import for FormattedMessage * add link to edit index lifecycle policy from index management index summary * adding key for map of summary extensions * adding proper icon for retry lifecycle action * factoring out common min age component * factoring out common NodeAllocation component * add copy to clipboard for json policy flyout * adding validation rules for policy names to match ES rules * fixing issues with policy names with non-alphabetic characters like & ^ % ? * moving create policy button to top right and adding fill * adding better empty state for policy list * moving shrink and force merge titles and descriptions to the left * moving show JSON button to right and limiting width of JSON flyout * fixing warning about lifecycle prop type for JSON flyout * fixing issue with warning on prop isShowingErrors * removing outdated README * simplifying constants * moving components to more logical places * moving lib and api files to services * renaming provider to enricher * factoring out common data enricher behavior * consolidating index management extension code * removing unnecessary colon * Revert "removing unnecessary colon" This reverts commit 1971280. * removing unnecessary colon * adding callout to ilm summary for errors * better formatting for banner extensions * Revert "disabling UI for index management when enabled is false in kibana.yml" This reverts commit 45d4e8c. * removing unnecessary code for detecting disabled plugin * adding config prefix of xpack.index_lifecycle_management * making policy link use href and consolidating link encoding logic * removed outdated comment * removed outdated comment * better solution for policy name in URI * fixing issue with index management being disabled and index_lifecycle_management not * adding link to index management list filtered to policy name from index_lifecycle_management policy list * fixing tests * adding popover for stack trace for ilm errors * adding stack trace and phase definition popovers to ilm summary in index management * adding to blacklist for node attributes and not showing node allocation section when there are not any node attributes to choose from * not showing create policy button in upper right for empty state * moving policy name form field to right to be consistent with the rest of the form layout * moving save button to left and using secondary color * added copied to clipboard toast message * moving activate/deactivate buttons to left on edit policy page * deleting unnecessary less file * using spacer instead of style * translating success message for edit policy save * fixing missing props warnings for EuiDescribedFormGroup usages * better error handling borrowed from rollups * disabling delete when a policy is attached to indices * adding remove lifecycle policy action * fixing issue with remove ilm policy showing for non-managed indices` * adding add lifecycle policy action to index management extensions in index lifecycle management * adding confirm modal for remove lifecycle policy * fixing validation * fixing issue with back button and edit policy retaining old policy * removing console.log * making no policy modal for add lifecycle policy make more sense (no add button) * Calling reloadIndices when a lifecycle policy gets added or removed * fixing logic issue with spinner showing * refactoring confirm modal on policy list page * adding an add to index template button on policy list page * fixing console warning about select value being null * fixing issue with modal not opening from index management table manage menu * changing app title and adding i18n for it * more naming changes and adding beta badge * adding filter extension to index management and using it to add filters for index lifecycle management * fixing broken jest test * fixing issue with banners appearing/disappearing based on filters * adding xpack.ilm.ui.enabled to allow cloud to disable the ui * add ability to configure list of node attributes to ignore in kibana.yml for cloud * filtering out reserved system templates from fetch route list * adding warning when user tries to add a policy to a template that already has a policy * fixing a11y issues on edit policy form * incorporating docs team feedback on copy * adding learn more link to add policy to index template modal * fixing app order for management * fixing breadcrumb issue by adding redirect for BASE_PATH (and adding memory leak fix) * making version and covered indices column smaller and adding horizontal scroll and min width * right align actions and better width solution for columns * bigger spacer under callout for no node attributes * restricting width of edit page * fixing typo * removing unnecessary store code for index templates * fixing react warning about boolean type * moving beta badge in line with title on policies screen * better UI for show JSON for edit policy * commenting on the memory leak fix for React Router redirects * fixing fatal error with node allocation flyout * fixing issue with banner not showing * moving unmanaged/managed filter to filter group to make it clearer what they mean * removing unused code * copy changes * adding context menu for policy table instead of icon buttons * adding fix errors badge for phases * removing unnecessary close button in flyout footer * adding spinner when nodeOptions are not present * moving view a list button below input * adding more explanation to add policy to index template modal * adding documentation link for main ILM docs in ES * only showing view nodes link when node attributes are selected * removing colon from flyout title * fixing layout for view nodes button for attributes * making loading spinner larger for node attributes select * fixing issue with button going off end of table * removing title from empty prompt for policy table * fixing max width for edit policy page * copy edits * don't show pager when number of policies is less than minimum page size * making number of replicas optional and adding optional label * fixing sort for policy table * fixing flicker for node allocation * removing redundant message for index policies defined * fixing spacing/alignment issues on error display for summary * fixing issues with pager not showing and controls disappearing when filters applied * adding tests for policy table * more test additions * making search bar incremental for index management * making JSON policy flyout show ES request JSON not internal representation * adding error message when user tries to submit add policy to index without selecting policy * adding validation for missing template on add policy to index template modal * adding tests for ilm index management extensions * adding tests for edit policy * removing learn about node attributes link until docs come * fixing prop type warning * adding missing translations * better tests for edit policy * adding tests for node attribute inputs * better tests for node attributes * fixing policy table test * fixing bad i18n id * updating snapshot * [Telemetry] Pull local Kibana usage stats (#26496) * add kibana stats * fix tests * format the stats for telemetry * fix the os/platform stats * add version to locally-source kibana telemetry stats * use callWithInternalUser * better get_kibana module unit test verification * separate handleKibanaStats * variable rename * fix comment * fix functional test * keep the return object literal from handleLocalStats * validate the payload fields * add warning log if no kibana stats returned * add missing apm-server response error monitor (#26570) * [DOCS] Deprecate /_xpack/security in favor of /_security (#26897) * fix ems hotlink (#26868) * Initialize authorization mode for reporting jobs (#26762) * wrap non error in a try/catch (#26898) * fix(NA): change kbn pm webpack config to generate dist files in mode=none. (#26847) * Fail out of auth flow on first provider failure (#26648) In practical terms, the flexibility afforded by providers being able to recover from the failures of previously configured providers isn't compelling, but the ambiguity is not ideal. * fixing a11y errors so we can add a11y rules to tslint (#26895) * EUI 5.6.0 (#26839) * eui 5.6.0 * Import IconType in infra/types/eui.d.ts * fixing interpreter socket error (#26870) * fixes split chart with no data (#26872) * fixing tooltips for line chart (#26881) * Make space selector a button (#26889) * [ML] Adds isRequired where applicable to timeseries_chart props. (#26880) Adds isRequired to timeseries_chart props to match the minimum required props necessary to render the component without errors reflected in the Minimal initialization test. * Translate share (#26802) * Only show change password form when a password change is possible (#26779) * only show change password form when a password change is possible * cleanup * remove test code * improved message * [Beats CM] Add basic license type (#26935) * Improve wording when creating a space (#26915) * copy tweaks * update save space toast * adjust save toast * fixing issue with multiple execution in console (#26933) * fixing a11y error (#26906) * [i18n] Translate ML - File Datavisualizer (Part 1) (#25641) translate file_datavisualizer folder of Machine Learning (Part 1) * Use new _graph endpoints (#26956) * [ML] Do not pass datafeed query to Discover in custom URL (#26957) * quick ILM fixes (#26966) * fix fatal IE 11 error with undefined TextEncoder * fixing validation issue with hot phase * fixing double scroll bar on IE11 : * Fixing a11y errors in querybar and suggestion_component (#26892) * correcting a11y errors so that we can add a11y rules to tslint * updating the jest snapshot * updating the jest snapshot * do not pass 'sortOrder' to EuiContextMenuItem in share context menu (#26890) * do not pass 'sortOrder' to EuiContextMenuItem in share context menu * add unit test for sortOrder * avoid using lodash * fix merge conflicts with internationization PR * Feat: Workpad Templates (#23966) * Added workpad manager which contains workpad_loader and workpad_templates * Fixed term filter in workpad_templates * design changes * Removed console logs Closes workpad manager modal after cloning template Fixed filtering workpad templates Removed console log Added sample templates Added more templates to test with Removed cloneDeep * case insensitive template search * Case insensitive tag order in popover * added descriptions and tags to sample data workpads * refine list of initial templates * remove sample data templates, make buttons bigger * Added template and tag registries * Fixed workpad loader resizing issue on home page * Moved tags to ui folder * Fixed template class * Fixed properties in templates to match workpad * fix lint errors (#26985) * Fix: Support columns with dots (#26659) Closes #26405 Upgrades tinymath so that columns with dots now work correctly. --- To test, follow the details in #26405. 1. Get some data that has fields with dots in them. Beats data would work, or you can create a test index with just 2 documents as follows: ``` POST test/test { "string":"abc", "with.dot":"abc" } POST test/test { "string":"abcd", "with.dot":"abcd" } ``` 2. Create a pie chart, splitting labels on one of the available fields. Previously, given the POST info above, only `string` would work correctly. Now both (and both of their `.keyword` variants) work correctly.  * upgrade resize-observer-polyfill version (#26990) * Fixing issues with the url.search being null in Node 10 (#26992) Node 10 uses `null` to denote the non-existence of a querystring parameter when `url.parse(urlString, true)` is used, the following changes fix our usages within the security plugin. * Hide logs from deleteAll on task: clean client modules into dll (#26884) * refact(NA): deleteAll function in order to allow it to not log anything out. * fix(NA): add missing no op debug and verbose functions. * refact(NA): wrap log calls into if calls. * [APM] Fix for library frames not collapsing (#26827) * [APM] fixes #26525 - simplified the stackframe grouping algorithm - add support for `stackframe.exclude_from_grouping` - made the rendering more tolerant of edge cases * Made improvements to code readability and added more meaningful test cases * [i18n] Translate untranslated labels (#26416) * Translate some missing translations * Fix issues * Add topNavMenu translations * Fix issues * Fix topNav * Fix issues * Fix issues * Fix kbnTopNav test and parametrs description * [ML] Fix word break in anomalies and jobs tables (#26978) * fixes other bucket request (#26874) * [I18n] Register translations before plugins init (#26078) * Register translations before plugins init * Fix i18n engine initialization * Fix translationPath$ RxJS pipeline * Move translations registration to mixin * Fix arrays concatenation * Use prettier * Fix translations relative paths * Use globby instead of glob * Update docs * Move globby to dependencies * Get rid of translation directories config * Update globby patterns * Search only for current locale translation files * [Infra UI] Fix styling after breaking EUI changes (#27021) This restores the Infrastructure and Logs UIs after upstream changes: * The theme json import now behaves like a ES6 module. * The `<EuiHeaderSection>` now requires the `grow` prop to be `true` in order to grow horizontally. * [i18n] Optimize translation labels for Roles page (#26945) * [i18n] Optimize translation labels * Usage of ng-if instead of ng-show * Update APM readme * [APM] Convert errors API to typescript (#26801) * [I18n] Allow i18n filter usage outside of interpolation expressions (#26803) * [I18n] Allow i18n filter usage outside of interpolation expressions * Remove redundant quotes from translation * Update tests * Resolve comments * Fix wrong filter usage * Introduce `recordOf` schema. Remove redundant declarations. (#26952) * [Infra UI] Fix graphql type generation after package upgrades (#26991) This fixes the infrastructure UI graphql type generation after relevant packages have been upgraded in #25157. * [Monitoring] APM monitoring to EUI (#26344) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Overview page * Update snapshots * Fix functional tests * Beats instances * Fix more tests * Update cluster tests * Logstash UIs * Logstash tests * APM pages * [Monitoring] Beats monitoring to EUI (#26287) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Overview page * Update snapshots * Fix functional tests * Beats instances * Fix more tests * Update cluster tests * [Monitoring] Kibana monitoring to EUI (#26361) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Overview page * Update snapshots * Fix functional tests * Beats instances * Fix more tests * Update cluster tests * Logstash UIs * Logstash tests * APM pages * Kibana pages * [Monitoring] Logstash monitoring to EUI (#26298) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Overview page * Update snapshots * Fix functional tests * Beats instances * Fix more tests * Update cluster tests * Logstash UIs * Logstash tests * Add this translation back in * PR feedback
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Dec 17, 2018
* [Monitoring] Cluster alerts table to EUI (elastic#26031) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * [Monitoring] Elasticsearch monitoring to EUI (elastic#26217) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Update snapshots * Fix functional tests * Fix more tests * Remove commented out code * Update token API calls in elaticsearch.js (elastic#26650) * make selection border 1px (elastic#26739) * Reporting phantom and chromium tests should run in parallel. (elastic#26566) * Reporting phantom and chromium tests should run in parallel. * Chromium tests should be done in group 9. * Attempting to use group 2 in ci for chromium tests. * X-pack CI jobs should have 7 groups. * Phantom tests should be in group 7. * [es-management/watcher] implement k7Breadcrumbs (elastic#26719) * [timelion] implement k7Breadcrumbs (elastic#26729) * [timelion] implement k7Breadcrumbs * [timelion] show "Create" breadcrumb by default * [es-management] implement k7Breadcrumbs (elastic#26711) * [es-manaagement] implement k7Breadcrumbs * fix i18n ids * Fixes i18n issue in space nav selector (elastic#26742) ## Summary Wraps the Spaces `NavControlPopover` in `<I18nProvider>`. Fixes elastic#26736 * [Docs] Add beta flag to central management docs (elastic#26558) * Feature/translate ml-jobs-jobs_list(part_1) (elastic#25466) Translate ml -> jobsList(part_1) * Corrected wrong calls from .on to .off (elastic#24575) Closing memory leak * Fix saved objects client _processBatchQueue function to handle errors (elastic#26763) * Fix saved objects client _processBatchQueue function to handle errors * Fix error thrown in try/catch * chore(.gitignore): ignore sublime workspace files (elastic#26516) * Map inspector requests by id so single requests can be reset at a time (elastic#26770) * [ML] Implement k7 breadcrumbs for ML routes (elastic#26774) * [ML] Implement k7 breadcrumbs for ML routes * [ML] Remove duplicate nouns from jobs and settings breadcrumbs * [Reporting] Re-enabled Chromium API tests (elastic#26789) * [Reporting] Test logging * chromium api tests fixed * whitespace * Fix Elasticsearch typo on connection error screen (elastic#26815) `Elastiscearch` -> `Elasticsearch`. * Reporting/reveal document bytes (elastic#26667) * Adding a `size` property to all job-reporting meta-data and showing in reporting details pane * Enable heartbeat telemetry (elastic#25886) This commit allows heartbeat telemetry data to be sent through kibana. The change to beats was introduced in elastic/beats#8621 * Change 'Disenroll' text to be consistent with menu option 'Unenroll'. (elastic#26816) * Upgrading sshpk (elastic#26834) sshpk is an implicit dependency of request@2.88.0 * Re-enable the chromium functional tests (elastic#26822) * Logging when max-bytes is larger than what's set in ES (elastic#26482) * Simple check if ES body-size is smaller than KBN report size * [BeatsCM] Cleanup and refactor (elastic#26636) * Refactor BeatsCM * update deps * update more deps * update for new EUI definitions * update import * Revert "update deps" This reverts commit 759a145. * use _source_includes * remove _source_includes * work-around due to watcher UI tests * Keep all xpack checks safe because we cant trust its there in tests for some reason * VALIDATION. This commit is to ensure the errors in CI are coming from beats * remove validation that this is a beats CM issue * More try/catch to try and find where this error is * testing another call * revert back to dangerouslyGetActiveInjector * ensure expire always is a number * fix swallowed error * Update x-pack/plugins/beats_management/public/lib/compose/kibana.ts Co-Authored-By: mattapperson <me@mattapperson.com> * Update x-pack/plugins/beats_management/public/utils/page_loader.test.ts Co-Authored-By: mattapperson <me@mattapperson.com> * Update x-pack/plugins/beats_management/public/utils/page_loader.ts Co-Authored-By: mattapperson <me@mattapperson.com> * fix for new webpack import * Fix translation map * fix URL path * fix other link * removing tag from beats via tag details screen now uses container * remove debug text * added comment/readme about routing on the client side * enrolled beat UI now works on overview screen * newly enrolled beat now reloads the beats table * fix TS errors * [APM] Transaction group agg size config (elastic#26683) * [APM] Fixes elastic#24204 by adding default configs to kibana.yml * [APM] fixes elastic#25940 by adding APM config to control top transation group agg size * Revert the default configs added to kibana.yml and define joi validations for `xpack.apm.ui.transactionGroupBucketSize` * fix broken test for incorrect config * [APM] add docs entry for `xpack.apm.ui.transactionGroupBucketSize` * [APM] fixes elastic#26784 by updateing import from a default to a named import (elastic#26785) * allow disabling gpu in tests (elastic#26684) * skipping failing tests (elastic#26877) * Feature/translate ml - jobs(part 2) (elastic#25528) Translate ml -> jobs - jobs-list(part_2) * use canvas pipeline in visualize (elastic#25996) * Upgrade to NodeJS 10 (elastic#25157) * feat(NA): upgrade node js version on file configs. * chore(NA): migrate configs and 3rd party dependencies to work on node js 10.x * fix(NA): add missing async function declaration. * chore(NA): updated elastic/good package to work with node10 * chore(NA): update lockfiles. * fix(NA): add missing dep. * fix(NA): types for node 10. * test(NA): fix error return type for node10. * fix(NA): kbn-pm webpack config to unlazy a require using lazy-cache. fix(NA): build to work with node 10. * test(NA): jest integration test for kbn-pluin-helpers. * test(NA): fix jest tests for kbn-es. * fix(NA): use ostmpdir instead of a tmp folder inside the fixtures. * fix(NA): change afterEach on kbn es decompress test. * fix(NA): change afterEach on kbn es decompress test. * fix(NA): readd mock-fs for the tests that still use it on kbn-es and that works on node10. * fix(NA): readd mock-fs for the tests that still use it on kbn-es and that works on node10. * refact(NA): rewrite tests using mock-fs and completely remove this dependency. * fix(NA): failing test implementation using jest mock in order to replace mock-fs. * fix(NA): update jest snapshots to match new ones generated one node 10. * fix(NA): cli/cluster mock to spyOn off method instead off spyOn removeListener as this was changed on Node 10. * fix(NA): tests for cluster_manager to also spyOn off and on instead of addListener and removeListener * test(NA): fix management advance settings image field test flow. * fix(NA): apply missing types for src/core/server/plugins/discovery/plugins_discovery.ts. * test(NA): updated 2 missing snapshots for KuiCodeEditor on kbn-ui-framework. * refact(NA): fix eslint errors. * refact(NA): fix ts code with tslint fix. chore(NA): update jest snapshots. * chore(NA): migrate kbn config schema peer dependency to last used joi version to avoid warning on bootstrap. * fix(NA): tslint errors. * chore(NA): upgrade types node to the last version. * fix(NA): missing utf8 input format encoding when reading a file. * chore(NA): upgrade to node 10.14.1 * fix(NA): Buffer api usage to avoid deprecation warnings. * fixing a11y errors so we can add a11y rules for tslint (elastic#26902) * [DOCS] Deprecate X-Pack-centric watcher endpoints (elastic#26899) * Index lifecycle (elastic#25553) * [WIP] Index lifecycle (elastic#25071) * Index lifecycle management wizard * Adding index lifecycle management files * Updates * Fix errors and add flyout for node details * New diff tool * Scroll to change for review diff * Some feedback on copy * Updating copy, moving components around and fixing bugs with the diff view * Add logic to auto enable a phase when something is set * redesign ilm * Adding server api tests * Removing debug and some tweaks from dave's work * Conditionally show this message * Policy selection cleanup * Updates for better UX * [COPYEDIT | ILM] Copyedit of text in index lifecycle management UI * Use better default text * Remove debug * Adding readme and comments * Update readme * Do not need this anymore * Remove debug or commented out code * Remove these - they are in the tests PR * Toggle system indices * Aliases are not defined here anymore * Handle rollover better in warm phase and remove from cold,delete * adding learn more link component and switching over to using that * fixing UI issue when no policies exist * various fixes * some cleanup * moving number_of_replicas due to API change * modifying some messaging * fixing typo * fixing some diff issues and not adding sattr_name if none chosen * making write alias required for template step and making necessary API changes * removing alias definition from template patching as it needs to be per index * some copy edits for clarity * fixing issue with editing existing policy when rollover starts the warm phase * addressing PR feedback on server side code * addressing PR feedback * removing additional spaces from findMatchingNodes call * changing template to index template in one more place * fixing issue with error message showing when bootstrap is successful * fixing node options for warm and cold phase * adding seconds to duration fields to match what ES supports * changing icon for enabled steps so it does not look like an error indicator * adjusting icon color for enabled lifecycle steps * fixing issue with editing an existing policy with warm phase on rollover enabled * fixing issue with default unit for age dropdowns * fixing issues with shrink action serialization and deserialization * fixing issue with deserialization of ES policy for shrink * removing shrink option from UI when primary shard count is not greater than 1 for hot phase * going straight to create policy when no policies exist * improving lifecycle policy selection * adding active badge instead of checkmark for active lifecycle policy phases * some cleanup of unneeded properties and only showing save as new when it is appropriate * removing stray fullWidth attribute * adding missing minimum for replica count for warm phase * adding scroll to top for review step * fixing issue with start warm phase after rollover introduced by time representaiton change from ES * making shrink options not show for primary shard count of 1 as you can't shrink in that situation * fixing issue with editing existing policy and saveAsNew * bare bones policy table implementation * implementing delete policy behavior * fixing sorting and paging * fixing policy table title * rudimentary navigation flow * fixing delete * Index lifecycle management wizard (elastic#21925) * Index lifecycle management wizard * Adding index lifecycle management files * Updates * Fix errors and add flyout for node details * New diff tool * Scroll to change for review diff * Some feedback on copy * Updating copy, moving components around and fixing bugs with the diff view * Add logic to auto enable a phase when something is set * redesign ilm * Adding server api tests * Removing debug and some tweaks from dave's work * Conditionally show this message * Policy selection cleanup * Updates for better UX * [COPYEDIT | ILM] Copyedit of text in index lifecycle management UI * Use better default text * Remove debug * Adding readme and comments * Update readme * Do not need this anymore * Remove debug or commented out code * Remove these - they are in the tests PR * Toggle system indices * Aliases are not defined here anymore * Handle rollover better in warm phase and remove from cold,delete * adding learn more link component and switching over to using that * fixing UI issue when no policies exist * various fixes * some cleanup * moving number_of_replicas due to API change * modifying some messaging * fixing typo * fixing some diff issues and not adding sattr_name if none chosen * making write alias required for template step and making necessary API changes * removing alias definition from template patching as it needs to be per index * some copy edits for clarity * fixing issue with editing existing policy when rollover starts the warm phase * addressing PR feedback on server side code * addressing PR feedback * removing additional spaces from findMatchingNodes call * changing template to index template in one more place * fixing issue with error message showing when bootstrap is successful * fixing node options for warm and cold phase * adding seconds to duration fields to match what ES supports * changing icon for enabled steps so it does not look like an error indicator * adjusting icon color for enabled lifecycle steps * fixing issue with editing an existing policy with warm phase on rollover enabled * fixing issue with default unit for age dropdowns * fixing issues with shrink action serialization and deserialization * fixing issue with deserialization of ES policy for shrink * removing shrink option from UI when primary shard count is not greater than 1 for hot phase * going straight to create policy when no policies exist * improving lifecycle policy selection * adding active badge instead of checkmark for active lifecycle policy phases * some cleanup of unneeded properties and only showing save as new when it is appropriate * removing stray fullWidth attribute * adding missing minimum for replica count for warm phase * adding scroll to top for review step * fixing issue with start warm phase after rollover introduced by time representaiton change from ES * making shrink options not show for primary shard count of 1 as you can't shrink in that situation * fixing issue with editing existing policy and saveAsNew * adjusting to changes in ES API * adding version and modified date to policies table * implementing new CRUD approach * simplified delete * cleanup edit_policy * removed wizard code * fixing issue with edit policy * fixing issue with closing delete confirmation modal * making max age and max size not mutually exclusive * removing names of covered indices from policy table * changing minimum_age to min_age * first pass at index lifecycle extensions * adding retry button for ilm covered index that is in error * first pass at index lifecycle banner * i18n work * more i18n * fixing issue with node attributes * removing console.log statements * fixing issue with deserializing number_of_shards for edit policy * defaulting shrink to false and fixing ui spacing issue * removing hot phase shard count from warm phase * scrolling to first error when user submits form for edit policy * disabling UI for index management when enabled is false in kibana.yml * disabling index lifecycle management when enabled is false in kibana.yml * extending index management filter to allow for searching fields * add support for filtering to indices with errors for index lifecycle management banner * i18n work * fixing error wrappers * fixing tests * adding view JSON for index lifecycle policy on edit screen * fixing label for i18n on policy JSON flyout * removing console.log statements * fixing tests * removing console.log statements * adding key for banner extensions * fixing bad import for FormattedMessage * add link to edit index lifecycle policy from index management index summary * adding key for map of summary extensions * adding proper icon for retry lifecycle action * factoring out common min age component * factoring out common NodeAllocation component * add copy to clipboard for json policy flyout * adding validation rules for policy names to match ES rules * fixing issues with policy names with non-alphabetic characters like & ^ % ? * moving create policy button to top right and adding fill * adding better empty state for policy list * moving shrink and force merge titles and descriptions to the left * moving show JSON button to right and limiting width of JSON flyout * fixing warning about lifecycle prop type for JSON flyout * fixing issue with warning on prop isShowingErrors * removing outdated README * simplifying constants * moving components to more logical places * moving lib and api files to services * renaming provider to enricher * factoring out common data enricher behavior * consolidating index management extension code * removing unnecessary colon * Revert "removing unnecessary colon" This reverts commit 1971280. * removing unnecessary colon * adding callout to ilm summary for errors * better formatting for banner extensions * Revert "disabling UI for index management when enabled is false in kibana.yml" This reverts commit 45d4e8c. * removing unnecessary code for detecting disabled plugin * adding config prefix of xpack.index_lifecycle_management * making policy link use href and consolidating link encoding logic * removed outdated comment * removed outdated comment * better solution for policy name in URI * fixing issue with index management being disabled and index_lifecycle_management not * adding link to index management list filtered to policy name from index_lifecycle_management policy list * fixing tests * adding popover for stack trace for ilm errors * adding stack trace and phase definition popovers to ilm summary in index management * adding to blacklist for node attributes and not showing node allocation section when there are not any node attributes to choose from * not showing create policy button in upper right for empty state * moving policy name form field to right to be consistent with the rest of the form layout * moving save button to left and using secondary color * added copied to clipboard toast message * moving activate/deactivate buttons to left on edit policy page * deleting unnecessary less file * using spacer instead of style * translating success message for edit policy save * fixing missing props warnings for EuiDescribedFormGroup usages * better error handling borrowed from rollups * disabling delete when a policy is attached to indices * adding remove lifecycle policy action * fixing issue with remove ilm policy showing for non-managed indices` * adding add lifecycle policy action to index management extensions in index lifecycle management * adding confirm modal for remove lifecycle policy * fixing validation * fixing issue with back button and edit policy retaining old policy * removing console.log * making no policy modal for add lifecycle policy make more sense (no add button) * Calling reloadIndices when a lifecycle policy gets added or removed * fixing logic issue with spinner showing * refactoring confirm modal on policy list page * adding an add to index template button on policy list page * fixing console warning about select value being null * fixing issue with modal not opening from index management table manage menu * changing app title and adding i18n for it * more naming changes and adding beta badge * adding filter extension to index management and using it to add filters for index lifecycle management * fixing broken jest test * fixing issue with banners appearing/disappearing based on filters * adding xpack.ilm.ui.enabled to allow cloud to disable the ui * add ability to configure list of node attributes to ignore in kibana.yml for cloud * filtering out reserved system templates from fetch route list * adding warning when user tries to add a policy to a template that already has a policy * fixing a11y issues on edit policy form * incorporating docs team feedback on copy * adding learn more link to add policy to index template modal * fixing app order for management * fixing breadcrumb issue by adding redirect for BASE_PATH (and adding memory leak fix) * making version and covered indices column smaller and adding horizontal scroll and min width * right align actions and better width solution for columns * bigger spacer under callout for no node attributes * restricting width of edit page * fixing typo * removing unnecessary store code for index templates * fixing react warning about boolean type * moving beta badge in line with title on policies screen * better UI for show JSON for edit policy * commenting on the memory leak fix for React Router redirects * fixing fatal error with node allocation flyout * fixing issue with banner not showing * moving unmanaged/managed filter to filter group to make it clearer what they mean * removing unused code * copy changes * adding context menu for policy table instead of icon buttons * adding fix errors badge for phases * removing unnecessary close button in flyout footer * adding spinner when nodeOptions are not present * moving view a list button below input * adding more explanation to add policy to index template modal * adding documentation link for main ILM docs in ES * only showing view nodes link when node attributes are selected * removing colon from flyout title * fixing layout for view nodes button for attributes * making loading spinner larger for node attributes select * fixing issue with button going off end of table * removing title from empty prompt for policy table * fixing max width for edit policy page * copy edits * don't show pager when number of policies is less than minimum page size * making number of replicas optional and adding optional label * fixing sort for policy table * fixing flicker for node allocation * removing redundant message for index policies defined * fixing spacing/alignment issues on error display for summary * fixing issues with pager not showing and controls disappearing when filters applied * adding tests for policy table * more test additions * making search bar incremental for index management * making JSON policy flyout show ES request JSON not internal representation * adding error message when user tries to submit add policy to index without selecting policy * adding validation for missing template on add policy to index template modal * adding tests for ilm index management extensions * adding tests for edit policy * removing learn about node attributes link until docs come * fixing prop type warning * adding missing translations * better tests for edit policy * adding tests for node attribute inputs * better tests for node attributes * fixing policy table test * fixing bad i18n id * updating snapshot * [Telemetry] Pull local Kibana usage stats (elastic#26496) * add kibana stats * fix tests * format the stats for telemetry * fix the os/platform stats * add version to locally-source kibana telemetry stats * use callWithInternalUser * better get_kibana module unit test verification * separate handleKibanaStats * variable rename * fix comment * fix functional test * keep the return object literal from handleLocalStats * validate the payload fields * add warning log if no kibana stats returned * add missing apm-server response error monitor (elastic#26570) * [DOCS] Deprecate /_xpack/security in favor of /_security (elastic#26897) * fix ems hotlink (elastic#26868) * Initialize authorization mode for reporting jobs (elastic#26762) * wrap non error in a try/catch (elastic#26898) * fix(NA): change kbn pm webpack config to generate dist files in mode=none. (elastic#26847) * Fail out of auth flow on first provider failure (elastic#26648) In practical terms, the flexibility afforded by providers being able to recover from the failures of previously configured providers isn't compelling, but the ambiguity is not ideal. * fixing a11y errors so we can add a11y rules to tslint (elastic#26895) * EUI 5.6.0 (elastic#26839) * eui 5.6.0 * Import IconType in infra/types/eui.d.ts * fixing interpreter socket error (elastic#26870) * fixes split chart with no data (elastic#26872) * fixing tooltips for line chart (elastic#26881) * Make space selector a button (elastic#26889) * [ML] Adds isRequired where applicable to timeseries_chart props. (elastic#26880) Adds isRequired to timeseries_chart props to match the minimum required props necessary to render the component without errors reflected in the Minimal initialization test. * Translate share (elastic#26802) * Only show change password form when a password change is possible (elastic#26779) * only show change password form when a password change is possible * cleanup * remove test code * improved message * [Beats CM] Add basic license type (elastic#26935) * Improve wording when creating a space (elastic#26915) * copy tweaks * update save space toast * adjust save toast * fixing issue with multiple execution in console (elastic#26933) * fixing a11y error (elastic#26906) * [i18n] Translate ML - File Datavisualizer (Part 1) (elastic#25641) translate file_datavisualizer folder of Machine Learning (Part 1) * Use new _graph endpoints (elastic#26956) * [ML] Do not pass datafeed query to Discover in custom URL (elastic#26957) * quick ILM fixes (elastic#26966) * fix fatal IE 11 error with undefined TextEncoder * fixing validation issue with hot phase * fixing double scroll bar on IE11 : * Fixing a11y errors in querybar and suggestion_component (elastic#26892) * correcting a11y errors so that we can add a11y rules to tslint * updating the jest snapshot * updating the jest snapshot * do not pass 'sortOrder' to EuiContextMenuItem in share context menu (elastic#26890) * do not pass 'sortOrder' to EuiContextMenuItem in share context menu * add unit test for sortOrder * avoid using lodash * fix merge conflicts with internationization PR * Feat: Workpad Templates (elastic#23966) * Added workpad manager which contains workpad_loader and workpad_templates * Fixed term filter in workpad_templates * design changes * Removed console logs Closes workpad manager modal after cloning template Fixed filtering workpad templates Removed console log Added sample templates Added more templates to test with Removed cloneDeep * case insensitive template search * Case insensitive tag order in popover * added descriptions and tags to sample data workpads * refine list of initial templates * remove sample data templates, make buttons bigger * Added template and tag registries * Fixed workpad loader resizing issue on home page * Moved tags to ui folder * Fixed template class * Fixed properties in templates to match workpad * fix lint errors (elastic#26985) * Fix: Support columns with dots (elastic#26659) Closes elastic#26405 Upgrades tinymath so that columns with dots now work correctly. --- To test, follow the details in elastic#26405. 1. Get some data that has fields with dots in them. Beats data would work, or you can create a test index with just 2 documents as follows: ``` POST test/test { "string":"abc", "with.dot":"abc" } POST test/test { "string":"abcd", "with.dot":"abcd" } ``` 2. Create a pie chart, splitting labels on one of the available fields. Previously, given the POST info above, only `string` would work correctly. Now both (and both of their `.keyword` variants) work correctly.  * upgrade resize-observer-polyfill version (elastic#26990) * Fixing issues with the url.search being null in Node 10 (elastic#26992) Node 10 uses `null` to denote the non-existence of a querystring parameter when `url.parse(urlString, true)` is used, the following changes fix our usages within the security plugin. * Hide logs from deleteAll on task: clean client modules into dll (elastic#26884) * refact(NA): deleteAll function in order to allow it to not log anything out. * fix(NA): add missing no op debug and verbose functions. * refact(NA): wrap log calls into if calls. * [APM] Fix for library frames not collapsing (elastic#26827) * [APM] fixes elastic#26525 - simplified the stackframe grouping algorithm - add support for `stackframe.exclude_from_grouping` - made the rendering more tolerant of edge cases * Made improvements to code readability and added more meaningful test cases * [i18n] Translate untranslated labels (elastic#26416) * Translate some missing translations * Fix issues * Add topNavMenu translations * Fix issues * Fix topNav * Fix issues * Fix issues * Fix kbnTopNav test and parametrs description * [ML] Fix word break in anomalies and jobs tables (elastic#26978) * fixes other bucket request (elastic#26874) * [I18n] Register translations before plugins init (elastic#26078) * Register translations before plugins init * Fix i18n engine initialization * Fix translationPath$ RxJS pipeline * Move translations registration to mixin * Fix arrays concatenation * Use prettier * Fix translations relative paths * Use globby instead of glob * Update docs * Move globby to dependencies * Get rid of translation directories config * Update globby patterns * Search only for current locale translation files * [Infra UI] Fix styling after breaking EUI changes (elastic#27021) This restores the Infrastructure and Logs UIs after upstream changes: * The theme json import now behaves like a ES6 module. * The `<EuiHeaderSection>` now requires the `grow` prop to be `true` in order to grow horizontally. * [i18n] Optimize translation labels for Roles page (elastic#26945) * [i18n] Optimize translation labels * Usage of ng-if instead of ng-show * Update APM readme * [APM] Convert errors API to typescript (elastic#26801) * [I18n] Allow i18n filter usage outside of interpolation expressions (elastic#26803) * [I18n] Allow i18n filter usage outside of interpolation expressions * Remove redundant quotes from translation * Update tests * Resolve comments * Fix wrong filter usage * Introduce `recordOf` schema. Remove redundant declarations. (elastic#26952) * [Infra UI] Fix graphql type generation after package upgrades (elastic#26991) This fixes the infrastructure UI graphql type generation after relevant packages have been upgraded in elastic#25157. * [Monitoring] APM monitoring to EUI (elastic#26344) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Overview page * Update snapshots * Fix functional tests * Beats instances * Fix more tests * Update cluster tests * Logstash UIs * Logstash tests * APM pages * [Monitoring] Beats monitoring to EUI (elastic#26287) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Overview page * Update snapshots * Fix functional tests * Beats instances * Fix more tests * Update cluster tests * [Monitoring] Kibana monitoring to EUI (elastic#26361) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Overview page * Update snapshots * Fix functional tests * Beats instances * Fix more tests * Update cluster tests * Logstash UIs * Logstash tests * APM pages * Kibana pages * [Monitoring] Logstash monitoring to EUI (elastic#26298) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Overview page * Update snapshots * Fix functional tests * Beats instances * Fix more tests * Update cluster tests * Logstash UIs * Logstash tests * Add this translation back in * PR feedback
chrisronline
added a commit
that referenced
this pull request
Dec 17, 2018
* [Monitoring] Cluster alerts table to EUI (#26031) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * [Monitoring] Elasticsearch monitoring to EUI (#26217) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Update snapshots * Fix functional tests * Fix more tests * Remove commented out code * Update token API calls in elaticsearch.js (#26650) * make selection border 1px (#26739) * Reporting phantom and chromium tests should run in parallel. (#26566) * Reporting phantom and chromium tests should run in parallel. * Chromium tests should be done in group 9. * Attempting to use group 2 in ci for chromium tests. * X-pack CI jobs should have 7 groups. * Phantom tests should be in group 7. * [es-management/watcher] implement k7Breadcrumbs (#26719) * [timelion] implement k7Breadcrumbs (#26729) * [timelion] implement k7Breadcrumbs * [timelion] show "Create" breadcrumb by default * [es-management] implement k7Breadcrumbs (#26711) * [es-manaagement] implement k7Breadcrumbs * fix i18n ids * Fixes i18n issue in space nav selector (#26742) ## Summary Wraps the Spaces `NavControlPopover` in `<I18nProvider>`. Fixes #26736 * [Docs] Add beta flag to central management docs (#26558) * Feature/translate ml-jobs-jobs_list(part_1) (#25466) Translate ml -> jobsList(part_1) * Corrected wrong calls from .on to .off (#24575) Closing memory leak * Fix saved objects client _processBatchQueue function to handle errors (#26763) * Fix saved objects client _processBatchQueue function to handle errors * Fix error thrown in try/catch * chore(.gitignore): ignore sublime workspace files (#26516) * Map inspector requests by id so single requests can be reset at a time (#26770) * [ML] Implement k7 breadcrumbs for ML routes (#26774) * [ML] Implement k7 breadcrumbs for ML routes * [ML] Remove duplicate nouns from jobs and settings breadcrumbs * [Reporting] Re-enabled Chromium API tests (#26789) * [Reporting] Test logging * chromium api tests fixed * whitespace * Fix Elasticsearch typo on connection error screen (#26815) `Elastiscearch` -> `Elasticsearch`. * Reporting/reveal document bytes (#26667) * Adding a `size` property to all job-reporting meta-data and showing in reporting details pane * Enable heartbeat telemetry (#25886) This commit allows heartbeat telemetry data to be sent through kibana. The change to beats was introduced in elastic/beats#8621 * Change 'Disenroll' text to be consistent with menu option 'Unenroll'. (#26816) * Upgrading sshpk (#26834) sshpk is an implicit dependency of request@2.88.0 * Re-enable the chromium functional tests (#26822) * Logging when max-bytes is larger than what's set in ES (#26482) * Simple check if ES body-size is smaller than KBN report size * [BeatsCM] Cleanup and refactor (#26636) * Refactor BeatsCM * update deps * update more deps * update for new EUI definitions * update import * Revert "update deps" This reverts commit 759a145. * use _source_includes * remove _source_includes * work-around due to watcher UI tests * Keep all xpack checks safe because we cant trust its there in tests for some reason * VALIDATION. This commit is to ensure the errors in CI are coming from beats * remove validation that this is a beats CM issue * More try/catch to try and find where this error is * testing another call * revert back to dangerouslyGetActiveInjector * ensure expire always is a number * fix swallowed error * Update x-pack/plugins/beats_management/public/lib/compose/kibana.ts Co-Authored-By: mattapperson <me@mattapperson.com> * Update x-pack/plugins/beats_management/public/utils/page_loader.test.ts Co-Authored-By: mattapperson <me@mattapperson.com> * Update x-pack/plugins/beats_management/public/utils/page_loader.ts Co-Authored-By: mattapperson <me@mattapperson.com> * fix for new webpack import * Fix translation map * fix URL path * fix other link * removing tag from beats via tag details screen now uses container * remove debug text * added comment/readme about routing on the client side * enrolled beat UI now works on overview screen * newly enrolled beat now reloads the beats table * fix TS errors * [APM] Transaction group agg size config (#26683) * [APM] Fixes #24204 by adding default configs to kibana.yml * [APM] fixes #25940 by adding APM config to control top transation group agg size * Revert the default configs added to kibana.yml and define joi validations for `xpack.apm.ui.transactionGroupBucketSize` * fix broken test for incorrect config * [APM] add docs entry for `xpack.apm.ui.transactionGroupBucketSize` * [APM] fixes #26784 by updateing import from a default to a named import (#26785) * allow disabling gpu in tests (#26684) * skipping failing tests (#26877) * Feature/translate ml - jobs(part 2) (#25528) Translate ml -> jobs - jobs-list(part_2) * use canvas pipeline in visualize (#25996) * Upgrade to NodeJS 10 (#25157) * feat(NA): upgrade node js version on file configs. * chore(NA): migrate configs and 3rd party dependencies to work on node js 10.x * fix(NA): add missing async function declaration. * chore(NA): updated elastic/good package to work with node10 * chore(NA): update lockfiles. * fix(NA): add missing dep. * fix(NA): types for node 10. * test(NA): fix error return type for node10. * fix(NA): kbn-pm webpack config to unlazy a require using lazy-cache. fix(NA): build to work with node 10. * test(NA): jest integration test for kbn-pluin-helpers. * test(NA): fix jest tests for kbn-es. * fix(NA): use ostmpdir instead of a tmp folder inside the fixtures. * fix(NA): change afterEach on kbn es decompress test. * fix(NA): change afterEach on kbn es decompress test. * fix(NA): readd mock-fs for the tests that still use it on kbn-es and that works on node10. * fix(NA): readd mock-fs for the tests that still use it on kbn-es and that works on node10. * refact(NA): rewrite tests using mock-fs and completely remove this dependency. * fix(NA): failing test implementation using jest mock in order to replace mock-fs. * fix(NA): update jest snapshots to match new ones generated one node 10. * fix(NA): cli/cluster mock to spyOn off method instead off spyOn removeListener as this was changed on Node 10. * fix(NA): tests for cluster_manager to also spyOn off and on instead of addListener and removeListener * test(NA): fix management advance settings image field test flow. * fix(NA): apply missing types for src/core/server/plugins/discovery/plugins_discovery.ts. * test(NA): updated 2 missing snapshots for KuiCodeEditor on kbn-ui-framework. * refact(NA): fix eslint errors. * refact(NA): fix ts code with tslint fix. chore(NA): update jest snapshots. * chore(NA): migrate kbn config schema peer dependency to last used joi version to avoid warning on bootstrap. * fix(NA): tslint errors. * chore(NA): upgrade types node to the last version. * fix(NA): missing utf8 input format encoding when reading a file. * chore(NA): upgrade to node 10.14.1 * fix(NA): Buffer api usage to avoid deprecation warnings. * fixing a11y errors so we can add a11y rules for tslint (#26902) * [DOCS] Deprecate X-Pack-centric watcher endpoints (#26899) * Index lifecycle (#25553) * [WIP] Index lifecycle (#25071) * Index lifecycle management wizard * Adding index lifecycle management files * Updates * Fix errors and add flyout for node details * New diff tool * Scroll to change for review diff * Some feedback on copy * Updating copy, moving components around and fixing bugs with the diff view * Add logic to auto enable a phase when something is set * redesign ilm * Adding server api tests * Removing debug and some tweaks from dave's work * Conditionally show this message * Policy selection cleanup * Updates for better UX * [COPYEDIT | ILM] Copyedit of text in index lifecycle management UI * Use better default text * Remove debug * Adding readme and comments * Update readme * Do not need this anymore * Remove debug or commented out code * Remove these - they are in the tests PR * Toggle system indices * Aliases are not defined here anymore * Handle rollover better in warm phase and remove from cold,delete * adding learn more link component and switching over to using that * fixing UI issue when no policies exist * various fixes * some cleanup * moving number_of_replicas due to API change * modifying some messaging * fixing typo * fixing some diff issues and not adding sattr_name if none chosen * making write alias required for template step and making necessary API changes * removing alias definition from template patching as it needs to be per index * some copy edits for clarity * fixing issue with editing existing policy when rollover starts the warm phase * addressing PR feedback on server side code * addressing PR feedback * removing additional spaces from findMatchingNodes call * changing template to index template in one more place * fixing issue with error message showing when bootstrap is successful * fixing node options for warm and cold phase * adding seconds to duration fields to match what ES supports * changing icon for enabled steps so it does not look like an error indicator * adjusting icon color for enabled lifecycle steps * fixing issue with editing an existing policy with warm phase on rollover enabled * fixing issue with default unit for age dropdowns * fixing issues with shrink action serialization and deserialization * fixing issue with deserialization of ES policy for shrink * removing shrink option from UI when primary shard count is not greater than 1 for hot phase * going straight to create policy when no policies exist * improving lifecycle policy selection * adding active badge instead of checkmark for active lifecycle policy phases * some cleanup of unneeded properties and only showing save as new when it is appropriate * removing stray fullWidth attribute * adding missing minimum for replica count for warm phase * adding scroll to top for review step * fixing issue with start warm phase after rollover introduced by time representaiton change from ES * making shrink options not show for primary shard count of 1 as you can't shrink in that situation * fixing issue with editing existing policy and saveAsNew * bare bones policy table implementation * implementing delete policy behavior * fixing sorting and paging * fixing policy table title * rudimentary navigation flow * fixing delete * Index lifecycle management wizard (#21925) * Index lifecycle management wizard * Adding index lifecycle management files * Updates * Fix errors and add flyout for node details * New diff tool * Scroll to change for review diff * Some feedback on copy * Updating copy, moving components around and fixing bugs with the diff view * Add logic to auto enable a phase when something is set * redesign ilm * Adding server api tests * Removing debug and some tweaks from dave's work * Conditionally show this message * Policy selection cleanup * Updates for better UX * [COPYEDIT | ILM] Copyedit of text in index lifecycle management UI * Use better default text * Remove debug * Adding readme and comments * Update readme * Do not need this anymore * Remove debug or commented out code * Remove these - they are in the tests PR * Toggle system indices * Aliases are not defined here anymore * Handle rollover better in warm phase and remove from cold,delete * adding learn more link component and switching over to using that * fixing UI issue when no policies exist * various fixes * some cleanup * moving number_of_replicas due to API change * modifying some messaging * fixing typo * fixing some diff issues and not adding sattr_name if none chosen * making write alias required for template step and making necessary API changes * removing alias definition from template patching as it needs to be per index * some copy edits for clarity * fixing issue with editing existing policy when rollover starts the warm phase * addressing PR feedback on server side code * addressing PR feedback * removing additional spaces from findMatchingNodes call * changing template to index template in one more place * fixing issue with error message showing when bootstrap is successful * fixing node options for warm and cold phase * adding seconds to duration fields to match what ES supports * changing icon for enabled steps so it does not look like an error indicator * adjusting icon color for enabled lifecycle steps * fixing issue with editing an existing policy with warm phase on rollover enabled * fixing issue with default unit for age dropdowns * fixing issues with shrink action serialization and deserialization * fixing issue with deserialization of ES policy for shrink * removing shrink option from UI when primary shard count is not greater than 1 for hot phase * going straight to create policy when no policies exist * improving lifecycle policy selection * adding active badge instead of checkmark for active lifecycle policy phases * some cleanup of unneeded properties and only showing save as new when it is appropriate * removing stray fullWidth attribute * adding missing minimum for replica count for warm phase * adding scroll to top for review step * fixing issue with start warm phase after rollover introduced by time representaiton change from ES * making shrink options not show for primary shard count of 1 as you can't shrink in that situation * fixing issue with editing existing policy and saveAsNew * adjusting to changes in ES API * adding version and modified date to policies table * implementing new CRUD approach * simplified delete * cleanup edit_policy * removed wizard code * fixing issue with edit policy * fixing issue with closing delete confirmation modal * making max age and max size not mutually exclusive * removing names of covered indices from policy table * changing minimum_age to min_age * first pass at index lifecycle extensions * adding retry button for ilm covered index that is in error * first pass at index lifecycle banner * i18n work * more i18n * fixing issue with node attributes * removing console.log statements * fixing issue with deserializing number_of_shards for edit policy * defaulting shrink to false and fixing ui spacing issue * removing hot phase shard count from warm phase * scrolling to first error when user submits form for edit policy * disabling UI for index management when enabled is false in kibana.yml * disabling index lifecycle management when enabled is false in kibana.yml * extending index management filter to allow for searching fields * add support for filtering to indices with errors for index lifecycle management banner * i18n work * fixing error wrappers * fixing tests * adding view JSON for index lifecycle policy on edit screen * fixing label for i18n on policy JSON flyout * removing console.log statements * fixing tests * removing console.log statements * adding key for banner extensions * fixing bad import for FormattedMessage * add link to edit index lifecycle policy from index management index summary * adding key for map of summary extensions * adding proper icon for retry lifecycle action * factoring out common min age component * factoring out common NodeAllocation component * add copy to clipboard for json policy flyout * adding validation rules for policy names to match ES rules * fixing issues with policy names with non-alphabetic characters like & ^ % ? * moving create policy button to top right and adding fill * adding better empty state for policy list * moving shrink and force merge titles and descriptions to the left * moving show JSON button to right and limiting width of JSON flyout * fixing warning about lifecycle prop type for JSON flyout * fixing issue with warning on prop isShowingErrors * removing outdated README * simplifying constants * moving components to more logical places * moving lib and api files to services * renaming provider to enricher * factoring out common data enricher behavior * consolidating index management extension code * removing unnecessary colon * Revert "removing unnecessary colon" This reverts commit 1971280. * removing unnecessary colon * adding callout to ilm summary for errors * better formatting for banner extensions * Revert "disabling UI for index management when enabled is false in kibana.yml" This reverts commit 45d4e8c. * removing unnecessary code for detecting disabled plugin * adding config prefix of xpack.index_lifecycle_management * making policy link use href and consolidating link encoding logic * removed outdated comment * removed outdated comment * better solution for policy name in URI * fixing issue with index management being disabled and index_lifecycle_management not * adding link to index management list filtered to policy name from index_lifecycle_management policy list * fixing tests * adding popover for stack trace for ilm errors * adding stack trace and phase definition popovers to ilm summary in index management * adding to blacklist for node attributes and not showing node allocation section when there are not any node attributes to choose from * not showing create policy button in upper right for empty state * moving policy name form field to right to be consistent with the rest of the form layout * moving save button to left and using secondary color * added copied to clipboard toast message * moving activate/deactivate buttons to left on edit policy page * deleting unnecessary less file * using spacer instead of style * translating success message for edit policy save * fixing missing props warnings for EuiDescribedFormGroup usages * better error handling borrowed from rollups * disabling delete when a policy is attached to indices * adding remove lifecycle policy action * fixing issue with remove ilm policy showing for non-managed indices` * adding add lifecycle policy action to index management extensions in index lifecycle management * adding confirm modal for remove lifecycle policy * fixing validation * fixing issue with back button and edit policy retaining old policy * removing console.log * making no policy modal for add lifecycle policy make more sense (no add button) * Calling reloadIndices when a lifecycle policy gets added or removed * fixing logic issue with spinner showing * refactoring confirm modal on policy list page * adding an add to index template button on policy list page * fixing console warning about select value being null * fixing issue with modal not opening from index management table manage menu * changing app title and adding i18n for it * more naming changes and adding beta badge * adding filter extension to index management and using it to add filters for index lifecycle management * fixing broken jest test * fixing issue with banners appearing/disappearing based on filters * adding xpack.ilm.ui.enabled to allow cloud to disable the ui * add ability to configure list of node attributes to ignore in kibana.yml for cloud * filtering out reserved system templates from fetch route list * adding warning when user tries to add a policy to a template that already has a policy * fixing a11y issues on edit policy form * incorporating docs team feedback on copy * adding learn more link to add policy to index template modal * fixing app order for management * fixing breadcrumb issue by adding redirect for BASE_PATH (and adding memory leak fix) * making version and covered indices column smaller and adding horizontal scroll and min width * right align actions and better width solution for columns * bigger spacer under callout for no node attributes * restricting width of edit page * fixing typo * removing unnecessary store code for index templates * fixing react warning about boolean type * moving beta badge in line with title on policies screen * better UI for show JSON for edit policy * commenting on the memory leak fix for React Router redirects * fixing fatal error with node allocation flyout * fixing issue with banner not showing * moving unmanaged/managed filter to filter group to make it clearer what they mean * removing unused code * copy changes * adding context menu for policy table instead of icon buttons * adding fix errors badge for phases * removing unnecessary close button in flyout footer * adding spinner when nodeOptions are not present * moving view a list button below input * adding more explanation to add policy to index template modal * adding documentation link for main ILM docs in ES * only showing view nodes link when node attributes are selected * removing colon from flyout title * fixing layout for view nodes button for attributes * making loading spinner larger for node attributes select * fixing issue with button going off end of table * removing title from empty prompt for policy table * fixing max width for edit policy page * copy edits * don't show pager when number of policies is less than minimum page size * making number of replicas optional and adding optional label * fixing sort for policy table * fixing flicker for node allocation * removing redundant message for index policies defined * fixing spacing/alignment issues on error display for summary * fixing issues with pager not showing and controls disappearing when filters applied * adding tests for policy table * more test additions * making search bar incremental for index management * making JSON policy flyout show ES request JSON not internal representation * adding error message when user tries to submit add policy to index without selecting policy * adding validation for missing template on add policy to index template modal * adding tests for ilm index management extensions * adding tests for edit policy * removing learn about node attributes link until docs come * fixing prop type warning * adding missing translations * better tests for edit policy * adding tests for node attribute inputs * better tests for node attributes * fixing policy table test * fixing bad i18n id * updating snapshot * [Telemetry] Pull local Kibana usage stats (#26496) * add kibana stats * fix tests * format the stats for telemetry * fix the os/platform stats * add version to locally-source kibana telemetry stats * use callWithInternalUser * better get_kibana module unit test verification * separate handleKibanaStats * variable rename * fix comment * fix functional test * keep the return object literal from handleLocalStats * validate the payload fields * add warning log if no kibana stats returned * add missing apm-server response error monitor (#26570) * [DOCS] Deprecate /_xpack/security in favor of /_security (#26897) * fix ems hotlink (#26868) * Initialize authorization mode for reporting jobs (#26762) * wrap non error in a try/catch (#26898) * fix(NA): change kbn pm webpack config to generate dist files in mode=none. (#26847) * Fail out of auth flow on first provider failure (#26648) In practical terms, the flexibility afforded by providers being able to recover from the failures of previously configured providers isn't compelling, but the ambiguity is not ideal. * fixing a11y errors so we can add a11y rules to tslint (#26895) * EUI 5.6.0 (#26839) * eui 5.6.0 * Import IconType in infra/types/eui.d.ts * fixing interpreter socket error (#26870) * fixes split chart with no data (#26872) * fixing tooltips for line chart (#26881) * Make space selector a button (#26889) * [ML] Adds isRequired where applicable to timeseries_chart props. (#26880) Adds isRequired to timeseries_chart props to match the minimum required props necessary to render the component without errors reflected in the Minimal initialization test. * Translate share (#26802) * Only show change password form when a password change is possible (#26779) * only show change password form when a password change is possible * cleanup * remove test code * improved message * [Beats CM] Add basic license type (#26935) * Improve wording when creating a space (#26915) * copy tweaks * update save space toast * adjust save toast * fixing issue with multiple execution in console (#26933) * fixing a11y error (#26906) * [i18n] Translate ML - File Datavisualizer (Part 1) (#25641) translate file_datavisualizer folder of Machine Learning (Part 1) * Use new _graph endpoints (#26956) * [ML] Do not pass datafeed query to Discover in custom URL (#26957) * quick ILM fixes (#26966) * fix fatal IE 11 error with undefined TextEncoder * fixing validation issue with hot phase * fixing double scroll bar on IE11 : * Fixing a11y errors in querybar and suggestion_component (#26892) * correcting a11y errors so that we can add a11y rules to tslint * updating the jest snapshot * updating the jest snapshot * do not pass 'sortOrder' to EuiContextMenuItem in share context menu (#26890) * do not pass 'sortOrder' to EuiContextMenuItem in share context menu * add unit test for sortOrder * avoid using lodash * fix merge conflicts with internationization PR * Feat: Workpad Templates (#23966) * Added workpad manager which contains workpad_loader and workpad_templates * Fixed term filter in workpad_templates * design changes * Removed console logs Closes workpad manager modal after cloning template Fixed filtering workpad templates Removed console log Added sample templates Added more templates to test with Removed cloneDeep * case insensitive template search * Case insensitive tag order in popover * added descriptions and tags to sample data workpads * refine list of initial templates * remove sample data templates, make buttons bigger * Added template and tag registries * Fixed workpad loader resizing issue on home page * Moved tags to ui folder * Fixed template class * Fixed properties in templates to match workpad * fix lint errors (#26985) * Fix: Support columns with dots (#26659) Closes #26405 Upgrades tinymath so that columns with dots now work correctly. --- To test, follow the details in #26405. 1. Get some data that has fields with dots in them. Beats data would work, or you can create a test index with just 2 documents as follows: ``` POST test/test { "string":"abc", "with.dot":"abc" } POST test/test { "string":"abcd", "with.dot":"abcd" } ``` 2. Create a pie chart, splitting labels on one of the available fields. Previously, given the POST info above, only `string` would work correctly. Now both (and both of their `.keyword` variants) work correctly.  * upgrade resize-observer-polyfill version (#26990) * Fixing issues with the url.search being null in Node 10 (#26992) Node 10 uses `null` to denote the non-existence of a querystring parameter when `url.parse(urlString, true)` is used, the following changes fix our usages within the security plugin. * Hide logs from deleteAll on task: clean client modules into dll (#26884) * refact(NA): deleteAll function in order to allow it to not log anything out. * fix(NA): add missing no op debug and verbose functions. * refact(NA): wrap log calls into if calls. * [APM] Fix for library frames not collapsing (#26827) * [APM] fixes #26525 - simplified the stackframe grouping algorithm - add support for `stackframe.exclude_from_grouping` - made the rendering more tolerant of edge cases * Made improvements to code readability and added more meaningful test cases * [i18n] Translate untranslated labels (#26416) * Translate some missing translations * Fix issues * Add topNavMenu translations * Fix issues * Fix topNav * Fix issues * Fix issues * Fix kbnTopNav test and parametrs description * [ML] Fix word break in anomalies and jobs tables (#26978) * fixes other bucket request (#26874) * [I18n] Register translations before plugins init (#26078) * Register translations before plugins init * Fix i18n engine initialization * Fix translationPath$ RxJS pipeline * Move translations registration to mixin * Fix arrays concatenation * Use prettier * Fix translations relative paths * Use globby instead of glob * Update docs * Move globby to dependencies * Get rid of translation directories config * Update globby patterns * Search only for current locale translation files * [Infra UI] Fix styling after breaking EUI changes (#27021) This restores the Infrastructure and Logs UIs after upstream changes: * The theme json import now behaves like a ES6 module. * The `<EuiHeaderSection>` now requires the `grow` prop to be `true` in order to grow horizontally. * [i18n] Optimize translation labels for Roles page (#26945) * [i18n] Optimize translation labels * Usage of ng-if instead of ng-show * Update APM readme * [APM] Convert errors API to typescript (#26801) * [I18n] Allow i18n filter usage outside of interpolation expressions (#26803) * [I18n] Allow i18n filter usage outside of interpolation expressions * Remove redundant quotes from translation * Update tests * Resolve comments * Fix wrong filter usage * Introduce `recordOf` schema. Remove redundant declarations. (#26952) * [Infra UI] Fix graphql type generation after package upgrades (#26991) This fixes the infrastructure UI graphql type generation after relevant packages have been upgraded in #25157. * [Monitoring] APM monitoring to EUI (#26344) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Overview page * Update snapshots * Fix functional tests * Beats instances * Fix more tests * Update cluster tests * Logstash UIs * Logstash tests * APM pages * [Monitoring] Beats monitoring to EUI (#26287) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Overview page * Update snapshots * Fix functional tests * Beats instances * Fix more tests * Update cluster tests * [Monitoring] Kibana monitoring to EUI (#26361) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Overview page * Update snapshots * Fix functional tests * Beats instances * Fix more tests * Update cluster tests * Logstash UIs * Logstash tests * APM pages * Kibana pages * [Monitoring] Logstash monitoring to EUI (#26298) * Convert cluster alerts page to use EUI tables. Also adds baseline support for all monitoring tables * Fix tests * Remove these two files * Keep the original table but offer a new one so existing UIs still work * Use different base table controller for the EUI table * Use EUI specific asc and desc constants * Update summary status * ES nodes * Indices page * ML job listing * Fix tests up * Node listing page * Advanced node page * Advanced index * Fix tests * Fix onBrush * Cluster listing page * Overview page * Update snapshots * Fix functional tests * Beats instances * Fix more tests * Update cluster tests * Logstash UIs * Logstash tests * Add this translation back in * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements k7 breadcrumbs for ML, following the guidelines referenced in #25900 and #25689.
The existing tabs are still present for navigation (replacing these with the EUI style side nav will be considered for a future PR), the following rules are applied:
If the
k7designflag is set tofalse(configured under Kibana - Management - Advanced Settings), the behavior falls back to the current breadcrumb implementation innav_menu.js. This will be removed prior to 7.0.0 once thek7designflag has been disabled.Examples of new k7 breadcrumbs:
Job management
Create job
Create multi metric job wizard
Anomaly Explorer
Single Metric Viewer
Data Visualizer
File Data Visualizer
Settings
Calendar Management
Edit calendar
Filter List Management
Create Filter List
Checklist