-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a11y rules from tslint-microsoft-contrib to tslint #26888
Conversation
💔 Build Failed |
Retest |
💔 Build Failed |
Retest |
💔 Build Failed |
Pinging @elastic/kibana-platform |
💔 Build Failed |
Retest |
💔 Build Failed |
Retest |
💔 Build Failed |
💔 Build Failed |
retest |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
removing non-branch commits removing non-branch commits
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
@azasypkin @stacey-gammon can you please look this over? It's finally ready to merge 🗡 Thanks! |
@azasypkin - do you know why we have a tslint.yaml and a tsconfig.json? The Otherwise, LGTM. |
@timroes told me tslint.yaml is for tslint while tsconfig.json is for the actual compiler, so I went ahead and specified tslint.configFile and my VSCode warnings show up! Woot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@@ -2,15 +2,34 @@ extends: | |||
- tslint:recommended | |||
- tslint-config-prettier | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: likely not necessary change.
Contains changes to package.json and tslint.yaml for a11y rules from https://www.npmjs.com/package/tslint-microsoft-contrib
Please note I won't be merging this PR till these PRs are in:
(Needed both alt and presentation)
cc @timroes @LeeDr