Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Remove duplicate import in file_datavisualizer_directive #27044

Merged
merged 1 commit into from
Dec 12, 2018
Merged

[ML] Remove duplicate import in file_datavisualizer_directive #27044

merged 1 commit into from
Dec 12, 2018

Conversation

peteharverson
Copy link
Contributor

Summary

Removes duplicate import of injectI18nProvider that was added by #25642.

@peteharverson peteharverson added review Project:i18n non-issue Indicates to automation that a pull request should not appear in the release notes v7.0.0 :ml Feature:Anomaly Detection ML anomaly detection v6.6.0 labels Dec 12, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

alvarezmelissa87
alvarezmelissa87 approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@peteharverson peteharverson merged commit 2fc7dee into elastic:master Dec 12, 2018
@peteharverson peteharverson deleted the ml-i18n-filedataviz-import branch December 12, 2018 16:07
@peteharverson
Copy link
Contributor Author

Merged before CI tests passed to fix error introduced by #25642

azasypkin pushed a commit to pavel06081991/kibana that referenced this pull request Dec 12, 2018
@peteharverson @azasypkin
[ML] Remove duplicate import in file_datavisualizer_directive (elasti…
0b1e234 
…c#27044)
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

walterra
walterra reviewed Dec 12, 2018
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pavel06081991 added a commit that referenced this pull request Dec 13, 2018
@pavel06081991
[6.x] [i18n] Translate ML - File Datavisualizer (Part 2) (#25642) (#2…
8596da5 
…7040)

* [i18n] Translate ML - File Datavisualizer (Part 2) (#25642)

translate file_datavisualizer folder of Machine Learning (Part 2)

[ML] Remove duplicate import in file_datavisualizer_directive (#27044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra left review comments

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes Project:i18n review v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peteharverson @elasticmachine @walterra @alvarezmelissa87