-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiles map autozoom #2708
Tiles map autozoom #2708
Conversation
Can you add some details here? Describe the behavior and implementation? As far as I can tell this doesn't address #2034 as it doesn't increase the geohash_grid precision on zoom. It also looks like there's a number of debug statements left in the code. Can you also rebase this on top of master? |
This fix is very straight forward. It justs auto zooms to the feature layer area upon loading of a map. |
This pull contains a number of unrelated commits. Please fix your branch such that it does not contain the extra commits. Also please fix the description to reflect the ticket you are addressing. |
I'd also like to see a toggle to turn this on and off on a per visualization basis. You can inject the toggle into the view options section |
I haven't seen any feedback on this and we're trying to clean up the pull list for release. I'm going to go ahead and close the pull but feel free to reopen when you're ready. |
Thanks Rashid. Sorry but fatherhood has taken its toll on me (I am now the proud father of a little Baptiste !) and I couldn't find any time to clean this up so far. |
🎉 congrats @jmleoni! |
This should fix issue #2034