Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Translate ML - New Job - recognize #27305

Merged
merged 65 commits into from
Dec 19, 2018
Merged

[i18n] Translate ML - New Job - recognize #27305

merged 65 commits into from
Dec 19, 2018

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Dec 17, 2018

Translate ml -> public -> jobs -> new_job -> simple -> recognize

Issue: #25454

Guidline
Readme

Nox911 added 30 commits September 24, 2018 18:58
@Nox911
Merge pull request #1 from elastic/master
c7ec189 
update
@Nox911
Merge pull request #2 from elastic/master
fa01b88 
second merge
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
70f6c7e
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
68587a0
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
42aa7d3
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
efeaefe
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
8a054ed
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
b0d1660
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
62b6ad1
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
acbad4b
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
a850650
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
0a200ce
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
b2a8244
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
b4b979e
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
d349a4f
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
ae285b9
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
3051641
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
6231971
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
f86a3d4
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
cf813c7
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
1aba03f
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
491009b
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
e243126
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
e74bd61
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
8bc5ffa
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
5787937
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
f17fa1e
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
c63b0a6
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
ed62b5b
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
df4fab4
@Nox911 Nox911 requested a review from pavel06081991 December 17, 2018 15:20
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

pavel06081991
pavel06081991 reviewed Dec 18, 2018
View reviewed changes
Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve comments and after that I'll check UI

x-pack/plugins/ml/public/jobs/new_job/simple/recognize/create_job/create_job.html Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/jobs/new_job/simple/recognize/create_job/create_job.html Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/jobs/new_job/simple/recognize/create_job/create_job.html Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/jobs/new_job/simple/recognize/create_job/create_job.html Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/jobs/new_job/simple/recognize/create_job/create_job.html Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/jobs/new_job/simple/recognize/create_job/create_job.html Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/jobs/new_job/simple/recognize/create_job/create_job.html Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/jobs/new_job/simple/recognize/create_job/create_job_controller.js Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/jobs/new_job/simple/recognize/create_job/create_job_controller.js Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/jobs/new_job/simple/recognize/create_job/create_job_controller.js Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

pavel06081991
pavel06081991 approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally and all works good. But please fix one comment

x-pack/plugins/ml/public/jobs/new_job/simple/recognize/create_job/create_job.html Outdated Show resolved Hide resolved
@Nox911 Nox911 requested a review from peteharverson December 18, 2018 14:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

peteharverson
peteharverson approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all LGTM

@Nox911 Nox911 removed the review label Dec 19, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit 9d2deb2 into elastic:master Dec 19, 2018
@Nox911 Nox911 deleted the feature/translate-ml-new_job-simple-recognize branch December 19, 2018 14:34
@maryia-lapata maryia-lapata mentioned this pull request Dec 20, 2018
Merged
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Dec 20, 2018
@Nox911 @maryia-lapata
[i18n] Translate ML - New Job - recognize (elastic#27305)
0b3b63f 
* Translate new_job -> recognize

* Resolve issues from comments

* Fix issue
Nox911 pushed a commit that referenced this pull request Dec 21, 2018
@maryia-lapata @Nox911
[i18n] Translate ML - New Job - recognize (#27305) (#27564)
fe33ad4 
* Translate new_job -> recognize

* Resolve issues from comments

* Fix issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel06081991 pavel06081991 pavel06081991 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees
No one assigned
Labels
backported Feature:Anomaly Detection ML anomaly detection :ml Project:i18n v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nox911 @elasticmachine @peteharverson @pavel06081991