Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Translate ML - New Job - Multi metric #27479

Merged

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Dec 19, 2018

Translate ml -> public -> jobs -> new_job -> simple -> multi_metric

Issue: #25454

Guidline
Readme

Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix comment

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Dec 21, 2018

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally, works good

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out and all LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit 398f067 into elastic:master Jan 3, 2019
@Nox911 Nox911 deleted the feature/translate-ml-new_job-simple-multi_metric branch January 3, 2019 10:42
pavel06081991 pushed a commit to pavel06081991/kibana that referenced this pull request Jan 3, 2019
* Translate new_job  -> multi_metric

* Fix id

* Fix issues
Nox911 pushed a commit that referenced this pull request Jan 3, 2019
* Translate new_job  -> multi_metric

* Fix id

* Fix issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants