Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCR] Create follower index UI form #27864

Merged
merged 8 commits into from
Jan 2, 2019
+1,046 −71
Merged

[CCR] Create follower index UI form #27864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
687a874
Initial setup Follower Index form
sebelga Dec 27, 2018
a6dc496
Working form without client validation
sebelga Dec 31, 2018
3156a2b
Add client side validation for follower index
sebelga Dec 31, 2018
4eb5019
Add client validation to check if index already exist
sebelga Dec 31, 2018
eee029f
Improve error message when leader index does not exist
sebelga Dec 31, 2018
f015b21
Remove update method for follower index
sebelga Dec 31, 2018
e4d828f
Clear api error on field change
sebelga Dec 31, 2018
5d8fb79
Fix i18n error
sebelga Dec 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions x-pack/plugins/cross_cluster_replication/common/constants/base_path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ export const BASE_PATH = '/management/elasticsearch/cross_cluster_replication';
export const BASE_PATH_REMOTE_CLUSTERS = '/management/elasticsearch/remote_clusters';
export const API_BASE_PATH = '/api/cross_cluster_replication';
export const API_REMOTE_CLUSTERS_BASE_PATH = '/api/remote_clusters';
export const API_INDEX_MANAGEMENT_BASE_PATH = '/api/index_management';
4 changes: 3 additions & 1 deletion x-pack/plugins/cross_cluster_replication/public/app/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ import { BASE_PATH } from '../../common/constants';
import {
CrossClusterReplicationHome,
AutoFollowPatternAdd,
AutoFollowPatternEdit
AutoFollowPatternEdit,
FollowerIndexAdd,
} from './sections';

export class App extends Component {
Expand Down Expand Up @@ -52,6 +53,7 @@ export class App extends Component {
<Redirect exact from={`${BASE_PATH}`} to={`${BASE_PATH}/follower_indices`} />
<Route exact path={`${BASE_PATH}/auto_follow_patterns/add`} component={AutoFollowPatternAdd} />
<Route exact path={`${BASE_PATH}/auto_follow_patterns/edit/:id`} component={AutoFollowPatternEdit} />
<Route exact path={`${BASE_PATH}/follower_indices/add`} component={FollowerIndexAdd} />
<Route exact path={`${BASE_PATH}/:section`} component={CrossClusterReplicationHome} />
</Switch>
</div>
Expand Down
19 changes: 19 additions & 0 deletions ..._cluster_replication/public/app/components/__snapshots__/follower_index_form.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`<FollowerIndexForm /> state transitions updateFields() should merge new fields value with existing followerIndex 1`] = `
Object {
"followerIndex": Object {
"leaderIndex": "bar",
"name": "new-name",
},
}
`;

exports[`<FollowerIndexForm /> state transitions updateFormErrors() should merge errors with existing fieldsErrors 1`] = `
Object {
"fieldsErrors": Object {
"leaderIndex": null,
"name": "Some error",
},
}
`;
2 changes: 1 addition & 1 deletion ...plugins/cross_cluster_replication/public/app/components/auto_follow_pattern_page_title.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const AutoFollowPatternPageTitle = ({ title }) => (
iconType="help"
>
<FormattedMessage
id="xpack.crossClusterReplication.readDocsButtonLabel"
id="xpack.crossClusterReplication.readDocsAutoFollowPatternButtonLabel"
defaultMessage="Auto-follow pattern docs"
/>
</EuiButtonEmpty>
Expand Down
Loading