Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Translate ML - util #27971

Merged
merged 74 commits into from
Jan 4, 2019
Merged

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Jan 3, 2019

Translate ml -> public -> util

Issue: #25454

Guidline
Readme

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@Nox911 Nox911 requested a review from pavel06081991 January 3, 2019 13:25
@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some small comments

x-pack/plugins/ml/public/util/index_utils.js Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/util/index_utils.js Outdated Show resolved Hide resolved
@peteharverson peteharverson requested a review from walterra January 4, 2019 10:11
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit 3496dff into elastic:master Jan 4, 2019
@Nox911 Nox911 deleted the feature/translate-ml-util branch January 4, 2019 12:26
pavel06081991 pushed a commit to pavel06081991/kibana that referenced this pull request Jan 4, 2019
* Translate public -> util folder

* Add translations for register_feature.js and breadcrumbs.js

* Resolve issues from review comments
Nox911 pushed a commit that referenced this pull request Jan 4, 2019
* Translate public -> util folder

* Add translations for register_feature.js and breadcrumbs.js

* Resolve issues from review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants