Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky point series test. #28272

Closed
wants to merge 2 commits into from

Conversation

lukeelmers
Copy link
Member

@lukeelmers lukeelmers commented Jan 8, 2019

Attempts to fix this flaky test: #27905

I have been unable to reproduce this failure locally, making the problem particularly difficult to diagnose. Tried throttling my network speed and rerunning a number of times, and it still passes consistently.

Once thing I did notice was that in other tests where we are saving a visualization, we tend to use waitForVisualizationSavedToastGone() after saveVisualizationExpectSuccess(). So I added that here in case the vis is trying to load too soon. Will try rerunning CI several times to see if this is actually helping.

@elasticmachine

This comment has been minimized.

@lukeelmers

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@lukeelmers

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@lukeelmers

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@lukeelmers

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@stacey-gammon

This comment has been minimized.

@stacey-gammon
Copy link
Contributor

@lukeelmers - I commented on the issue, I think this might fix it, but as a by product of the extra wait time for the toast to be gone. What do you think of first trying clickByCssSelectorWhenNotDisabled and adding in a expectToBeOnLandingPage check. If that doesn't fix the issue we can try something else, but I think the fix should be inside visualize_page.js so all callers will get the fix.

@elasticmachine

This comment has been minimized.

@lukeelmers
Copy link
Member Author

Pushed updates based on @stacey-gammon's suggestions in the issue comments.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lukeelmers
Copy link
Member Author

lukeelmers commented Jan 10, 2019

whomp whomp

[00:07:32]                   │ debg findByCssSelector [href="#/visualize"]
[00:10:28]                   └- ✖ fail: "visualize app  point series custom labels and axis titles should preserve saved axis titles after a vis is saved and reopened"
[00:10:28]                   │      Error: Timeout of 180000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

@lukeelmers
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon
Copy link
Contributor

Last build failed on "
UI Functional Tests.test/functional/apps/visualize/_pie_chart·js.visualize app pie chart other bucket should apply correct filter on other bucket" - visualize app pie chart other bucket should apply correct filter on other bucket by clicking on a legend

I am investigating a fix, though am out today and tomorrow so won't be able to make much progress on it. I think some of the checks need to be wrapped in a retry for the pie chart because it takes the filters a bit to refresh/reload (pie chart doesn't emit "render-complete" correctly so we can't rely on that).

@lukeelmers

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lukeelmers
Copy link
Member Author

Closing as this has been confirmed to be stable in #31446.

@lukeelmers lukeelmers closed this Mar 1, 2019
@lukeelmers lukeelmers deleted the fix/flaky-test branch March 1, 2019 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants