-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky point series test. #28272
Fix flaky point series test. #28272
Conversation
7b25fc9
to
b08cfd0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@lukeelmers - I commented on the issue, I think this might fix it, but as a by product of the extra wait time for the toast to be gone. What do you think of first trying |
This comment has been minimized.
This comment has been minimized.
Pushed updates based on @stacey-gammon's suggestions in the issue comments. |
💔 Build Failed |
whomp whomp
|
retest |
💔 Build Failed |
Last build failed on " I am investigating a fix, though am out today and tomorrow so won't be able to make much progress on it. I think some of the checks need to be wrapped in a retry for the pie chart because it takes the filters a bit to refresh/reload (pie chart doesn't emit "render-complete" correctly so we can't rely on that). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2b557fe
to
27abf4b
Compare
💔 Build Failed |
Closing as this has been confirmed to be stable in #31446. |
Attempts to fix this flaky test: #27905
I have been unable to reproduce this failure locally, making the problem particularly difficult to diagnose. Tried throttling my network speed and rerunning a number of times, and it still passes consistently.
Once thing I did notice was that in other tests where we are saving a visualization, we tend to use
waitForVisualizationSavedToastGone()
aftersaveVisualizationExpectSuccess()
. So I added that here in case the vis is trying to load too soon. Will try rerunning CI several times to see if this is actually helping.