Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] Adds new K7 side navigation #28940

Merged
merged 26 commits into from
Jan 31, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
beaf2db
initial commit of K7 side nav
ryankeairns Jan 16, 2019
8630c4d
[ui/persistedLog/recentlyAccessed] support observing history items
Jan 16, 2019
9154ab0
[globalNav] use real recentlyAccessed and navLink data
Jan 16, 2019
89cda2a
fixes header logo and mobile layout
ryankeairns Jan 17, 2019
419b872
handle hidden links and no recents, use size vars
ryankeairns Jan 18, 2019
8eca7f2
handle hidden links and no recents, use size vars
ryankeairns Jan 18, 2019
cf90774
adds prop to wrap flyout link text
ryankeairns Jan 18, 2019
e3c03eb
fix menu scroll for IE
ryankeairns Jan 23, 2019
a050dd8
[chrome/headerGlobalNav] fix typescript issues
Jan 23, 2019
f02f6d7
[chrome/headerGlobalNav] only ignore types that are actually missing
Jan 23, 2019
184e53d
update EUI to 6.6.0
ryankeairns Jan 23, 2019
1cd3614
Revert "update EUI to 6.6.0"
ryankeairns Jan 23, 2019
c29cb18
[chrome] remove HeaderAppMenu component
Jan 24, 2019
9bdda26
[ftr/services/appsMemnu] update for new style
Jan 24, 2019
95d0d39
[ftr/discover] tweak size of discover tests and size-dependent assert…
Jan 24, 2019
97639d1
[chrome] disable offsets in embed mode
Jan 24, 2019
36c1aad
[ftr/discover] try sticking with original screen width
Jan 24, 2019
261b98d
[ftr/discover] try to force screensize before checking axis labels
Jan 24, 2019
46c25f4
[ftr/services/appMenu] ensure menu closed after clicking app
Jan 28, 2019
bdd551c
uptime app icon, mobile header size removed
ryankeairns Jan 29, 2019
795b0fa
Merge branch 'master' of github.com:elastic/kibana into rk/25736-side…
Jan 31, 2019
f882845
[ftr/discover] make assertion resilient to minor changes in vis width
Jan 31, 2019
5ef930d
[chrome] add types for nav apis
Jan 31, 2019
c6268ee
[chrome/recentlyAccessed] display app icons when possible
Jan 31, 2019
57dbb1c
[ftr/discover] make a little wider so scroll doesn't interfer with vi…
Jan 31, 2019
bbdee21
[ftr/services/globalNav] fix test subject
Jan 31, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions src/ui/public/chrome/api/nav.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import { IconType } from '@elastic/eui';
import * as Rx from 'rxjs';

import { KibanaParsedUrl } from 'ui/url/kibana_parsed_url';

export interface NavLink {
title: string;
url: string;
subUrlBase: string;
id: string;
euiIconType: IconType;
active: boolean;
lastSubUrl?: string;
hidden?: boolean;
}

export interface ChromeNavLinks {
getNavLinks$(): Rx.Observable<NavLink>;
getNavLinks(): NavLink[];
navLinkExists(id: string): boolean;
getNavLinkById(id: string): NavLink;
showOnlyById(id: string): void;
untrackNavLinksForDeletedSavedObjects(deletedIds: string[]): void;
trackSubUrlForApp(linkId: string, parsedKibanaUrl: KibanaParsedUrl): void;
}
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import '@elastic/eui/src/components/header/variables';

.header-global-wrapper {
width: 100%;
position: fixed;
Expand All @@ -6,23 +8,19 @@
}

.header-global-wrapper + .app-wrapper:not(.hidden-chrome) {
top: 48px;
left: 0;
top: $euiHeaderChildSize;
left: $euiHeaderChildSize;

// HOTFIX: Temporary fix for flyouts not inside portals
// SASSTODO: Find an actual solution
.euiFlyout {
top: 48px;
top: $euiHeaderChildSize;
}
}

// Mobile header is smaller
@include euiBreakpoint('xs','s') {
.header-global-wrapper + .app-wrapper {
top: 36px;

.euiFlyout {
top: 36px;
}
@include euiBreakpoint('xs', 's') {
.header-global-wrapper + .app-wrapper:not(.hidden-chrome) {
left: 0;
}
}
Loading