[Monitoring] Await promise properly #29001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/stack-monitoring |
💔 Build Failed |
pickypg
reviewed
Jan 18, 2019
| @@ -103,7 +103,7 @@ export class BulkUploader { | |||
| if (payload) { | |||
| try { | |||
| this._log.debug(`Uploading bulk stats payload to the local cluster`); | |||
| this._onPayload(payload); | |||
| await this._onPayload(payload); | |||
There was a problem hiding this comment.
You should be able to await this on the tests that mock Elasticsearch, then assert that it sent the payload (or failed) with itself returning until it did that while also avoiding an exception being thrown from this method.
There was a problem hiding this comment.
I think this will work: be5c697
Thoughts?
There was a problem hiding this comment.
Pinging my favorite Chris @pickypg!
💚 Build Succeeded |
|
cc @mattapperson @justinkambic Either of you able to look at this this week? |
mattapperson
approved these changes
Jan 29, 2019
chrisronline
deleted the
monitoring/handle_async_code_in_bulk_uploader
branch
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Jan 29, 2019
* Await this promise * Add one additional log message and a test around that
chrisronline
added a commit
that referenced
this pull request
Jan 29, 2019
|
Backport: 6.x: 67dc8c0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28989
Properly awaits the promise.
Unfortunately, I couldn't figure a good way to add a test for this, or modify the existing tests. Any thoughts here would be appreciated
cc @pickypg