[ML] Fixes to text spacings in data visualizer cards #29438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
non-issue
peteharverson
requested review from
walterra,
alvarezmelissa87 and
jgowdyelastic
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
snide
reviewed
Jan 29, 2019
| @@ -1,9 +1,10 @@ | |||
| .ml-field-title-bar { | |||
| color: $euiColorEmptyShade; | |||
| font-size: $euiFontSizeL; | |||
| line-height: $euiSizeL; | |||
There was a problem hiding this comment.
This works, but @include euiFontSizeL will give you size and line height together in a more stable format that's more vertical rhythm aware. It should even remove your need for the padding (didn't test).
https://github.com/elastic/eui/blob/master/src/global_styling/mixins/_typography.scss#L81-L84
There was a problem hiding this comment.
Thanks for the suggestion @snide. I've switched out the font-size and line-height for @include euiFontSizeL. Opted to retain just padding-bottom after testing.
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Jan 29, 2019
* [ML] Fixes to text spacings in data visualizer cards * [ML] Switch to using euiFontSizeL include for field title bar
peteharverson
added a commit
that referenced
this pull request
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a couple of minor styling issues on the Data Visualizer cards, with text spacing and the padding used in the title bar:
Before:
After:
Checklist