Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out security realm deprecations on Cloud #30018

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Feb 4, 2019

Summary

Related #26368

This filters out the Security realm config deprecation from the Upgrade Assistant UI and API when running on a Cloud or ECE environment.

We're doing to improve the UX of upgrading to 7.0 on Cloud to avoid confusing users by asking them to update a setting they cannot update until they actually upgrade their elasticsearch.yml for the 7.0 rolling upgrade.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the type is fixed.

@joshdover joshdover force-pushed the upgrade-assistant-cloud branch from 88184e6 to d2586bf Compare February 5, 2019 04:17
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joshdover joshdover merged commit 20ffce2 into elastic:master Feb 5, 2019
@joshdover joshdover deleted the upgrade-assistant-cloud branch February 5, 2019 06:17
joshdover added a commit to joshdover/kibana that referenced this pull request Feb 5, 2019
@joshdover joshdover added the non-issue Indicates to automation that a pull request should not appear in the release notes label Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker non-issue Indicates to automation that a pull request should not appear in the release notes review Team:Operations Team label for Operations Team v6.7.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants