Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide dashboard edit mode on small screen sizes #30103

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Feb 5, 2019

Summary

With #29896 we'll introduce a responsive mode for dashboards, where on screen sizes s and xs all panels will just be shown full with below each other (so making the grid a list). Since we cannot really edit that dashboard anymore in that configuration, since it relies on the grid to be present, we decided to remove the Edit button on small screens.

This PR adds the capability to set a custom CSS class to kbnTopNav items and uses it to hide the edit button on s and xs screens.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@timroes timroes added release_note:enhancement Feature:Dashboard Dashboard related features v7.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! TY!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@flash1293
Copy link
Contributor

Code LGTM!

@timroes timroes merged commit 8b8f4c5 into elastic:master Feb 6, 2019
@timroes timroes deleted the hide-edit-dashboard branch February 6, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants