Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] General ML style tweaks for K7 compatibility #30536

Merged
merged 2 commits into from
Feb 12, 2019

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Feb 8, 2019

Adds some padding to the top of the navigation bar on all of the data visualizer and settings pages as they don't use the time picker.
These pages also had some oddities where a scrollbar would constantly be present and the background colour was being overridden.

Before:
image

After:
image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@jgowdyelastic jgowdyelastic requested review from a team as code owners February 8, 2019 16:12
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@jgowdyelastic jgowdyelastic changed the title [ML] [WIP] General ML style tweaks for K7 compatibility [ML] General ML style tweaks for K7 compatibility Feb 8, 2019
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also tested on IE11.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit 7c48cd3 into elastic:master Feb 12, 2019
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 12, 2019
* [ML] [WIP] General ML style tweaks for K7 compatibility

* file data viz clean up
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 12, 2019
* [ML] [WIP] General ML style tweaks for K7 compatibility

* file data viz clean up
jgowdyelastic added a commit that referenced this pull request Feb 12, 2019
* [ML] [WIP] General ML style tweaks for K7 compatibility

* file data viz clean up
jgowdyelastic added a commit that referenced this pull request Feb 12, 2019
* [ML] [WIP] General ML style tweaks for K7 compatibility

* file data viz clean up
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants