-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] General ML style tweaks for K7 compatibility #30536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
jgowdyelastic
assigned walterra, alvarezmelissa87, peteharverson and jgowdyelastic and unassigned walterra, alvarezmelissa87 and peteharverson
Feb 8, 2019
jgowdyelastic
requested review from
peteharverson,
walterra and
alvarezmelissa87
February 8, 2019 18:00
Pinging @elastic/ml-ui |
jgowdyelastic
changed the title
[ML] [WIP] General ML style tweaks for K7 compatibility
[ML] General ML style tweaks for K7 compatibility
Feb 8, 2019
jgowdyelastic
force-pushed
the
k7-style-tweaks
branch
from
February 11, 2019 09:20
2860100
to
251cd12
Compare
peteharverson
approved these changes
Feb 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Also tested on IE11.
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 12, 2019
* [ML] [WIP] General ML style tweaks for K7 compatibility * file data viz clean up
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 12, 2019
* [ML] [WIP] General ML style tweaks for K7 compatibility * file data viz clean up
jgowdyelastic
added a commit
that referenced
this pull request
Feb 12, 2019
jgowdyelastic
added a commit
that referenced
this pull request
Feb 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some padding to the top of the navigation bar on all of the data visualizer and settings pages as they don't use the time picker.
These pages also had some oddities where a scrollbar would constantly be present and the background colour was being overridden.
Before:
After:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.